<?xml version="1.0" encoding="utf-8"?>
<feed xmlns="http://www.w3.org/2005/Atom">
	<title type="html"><![CDATA[PunBB Forums - Bug in update_users_online]]></title>
	<link rel="self" href="http://punbb.informer.com/forums/feed/atom/topic/21787/"/>
	<updated>2009-09-11T11:58:49Z</updated>
	<generator>PunBB</generator>
	<id>http://punbb.informer.com/forums/topic/21787/bug-in-updateusersonline/</id>
		<entry>
			<title type="html"><![CDATA[Re: Bug in update_users_online]]></title>
			<link rel="alternate" href="http://punbb.informer.com/forums/post/130602/#p130602"/>
			<content type="html"><![CDATA[<p><a href="http://punbb.informer.com/trac/changeset/1325">Fixed</a> (I hope).</p>]]></content>
			<author>
				<name><![CDATA[Parpalak]]></name>
				<uri>http://punbb.informer.com/forums/user/13581/</uri>
			</author>
			<updated>2009-09-11T11:58:49Z</updated>
			<id>http://punbb.informer.com/forums/post/130602/#p130602</id>
		</entry>
		<entry>
			<title type="html"><![CDATA[Re: Bug in update_users_online]]></title>
			<link rel="alternate" href="http://punbb.informer.com/forums/post/128616/#p128616"/>
			<content type="html"><![CDATA[<p>We will <a href="http://punbb.informer.com/trac/ticket/259">investigate</a> this problem, thank for reporting.</p>]]></content>
			<author>
				<name><![CDATA[Slavok]]></name>
				<uri>http://punbb.informer.com/forums/user/13265/</uri>
			</author>
			<updated>2009-06-23T08:45:23Z</updated>
			<id>http://punbb.informer.com/forums/post/128616/#p128616</id>
		</entry>
		<entry>
			<title type="html"><![CDATA[Bug in update_users_online]]></title>
			<link rel="alternate" href="http://punbb.informer.com/forums/post/128539/#p128539"/>
			<content type="html"><![CDATA[<p>Lines 1541-1542 in functions.php, the code doesn&#039;t do what the comment says.<br /></p><div class="codebox"><pre><code>// If the entry is older than &quot;o_timeout_visit&quot;, update last_visit for the user in question, then delete him/her from the online list
if ($cur_user[&#039;idle&#039;] != &#039;0&#039;)</code></pre></div><p>This causes the following problem :</p><p>User A is inactive for longer than &quot;o_timeout_online&quot;<br />User B browses the board, user A is removed from the list of online users (idle = 1)<br />User A is still inactive (reading/writing a very long post)<br />User B browses the board, user A is completely removed from the online table and sees his date of last visit modified to the date of his last action, <strong>THUS loses track of his unread messages</strong>.</p><p>Users should always be considered as online (idle or not) for as long as <strong>o_timeout_visit</strong>. My users tend to idle a lot, so I had configured &quot;o_timeout_visit&quot; to 24 hours back in version 1.2.</p><p>The code should be :<br /></p><div class="codebox"><pre><code>// If the entry is older than &quot;o_timeout_visit&quot;, update last_visit for the user in question, then delete him/her from the online list
if ($cur_user[&#039;logged&#039;] &lt; ($now-$forum_config[&#039;o_timeout_visit&#039;]))</code></pre></div><p>like it was before.</p>]]></content>
			<author>
				<name><![CDATA[bedroom]]></name>
				<uri>http://punbb.informer.com/forums/user/5754/</uri>
			</author>
			<updated>2009-06-19T18:34:33Z</updated>
			<id>http://punbb.informer.com/forums/post/128539/#p128539</id>
		</entry>
</feed>
