PunBB Forums - error_reporting setting in include/essentials.php

Re: error_reporting setting in include/essentials.php

dummy@example.com (Parpalak) — Wed, 20 May 2009 11:46:46 +0000

dummy@example.com (Parpalak) — Thu, 07 May 2009 09:29:02 +0000

Maybe it's better to connect error_reporting with the FORUM_DEBUG constant. If FORUM_DEBUG is defined, all errors and notices should be displayed.

dummy@example.com (Cereal) — Thu, 07 May 2009 07:46:32 +0000

hmm,

in my opinion all code should start whit an e_all, this will force devs and extension devs to write decent and correct php code.

dummy@example.com (Slavok) — Thu, 07 May 2009 07:30:16 +0000

Yes, you're right. Thanks for reporting, fixed.

dummy@example.com (bedroom) — Wed, 06 May 2009 13:34:28 +0000

Lines 65-66 in include/essentials.php :

// Make sure PHP reports all errors except E_NOTICE. PunBB supports E_ALL, but a lot of scripts it may interact with, do not.
error_reporting(E_ALL);

It seems to me that either the comment is wrong, or the code should read

error_reporting(E_ALL & ~E_NOTICE);

Am I right ?