1

Topic: redirect function replaces semicolons too aggressively

The following lines are found in the function "redirect" found in  includes/functions.php.

// Do a little spring cleaning
$destination_url = str_replace(array("\r", "\n", '%0a', '%0d', ';'), '', $destination_url);

\r, \n, 0A, and 0D seem fine to me, but I am not sure why we want to strip semicolons.  This non-discriminating replace breaks html entities like

&

which results in being redirected to a 'Bad or outdated request' page.

Re: redirect function replaces semicolons too aggressively

Yes, we know, I've already posted about this wink