Topic: Error with seo sitemap help plz :)

Hello gy's

Im having this error on my page, for some seo related issue's, coud you gys possible help me out and tell me what to do plz ?:) error can be found here:

http://www.animeresource.org/sitemap.php

<?php

function makeurl($type, $id, $name, $navoegsel = NULL) {
    # Type must be "f" for forum, "t" for topic or "p" for post
    # ID is the id of the content wanted
    # Name is the title of the category or topic
    

    $words = explode(" ", $name);
    $url;
    foreach ($words as $word) {
        if(strlen($word) > 3)
            $url .= '-' . $word;
    }
    $url = strtr($url,'ÀÁÂÃÄÅàáâãäåÒÓÔÕÖØòóôõöøÈÉÊËèéêëÇçÌÍÎÏìíîïÙÚÛÜùúûüÿÑñ/','AAAAAAaaaaaaOOOOOOooooooEEEEeeeeCcIIIIiiiiUUUUuuuuyNn-');
    $url = urlencode($type . $id . $url . ".html");
    
    if(isset($navoegsel))
        $url = $url."#".$navoegsel;

    return $url;
}

?>

Re: Error with seo sitemap help plz :)

bumpy

Re: Error with seo sitemap help plz :)

DO NOT bump... Especially less than 24 hours from when you posted.

Maybe the error on your screen might give it away......

Fatal error: Cannot redeclare makeurl() (previously declared in /home/special/public_html/include/rewrite.php:3) in /home/special/public_html/include/rewrite.php on line 22

Re: Error with seo sitemap help plz :)

Ye I wish it was that eassy, I will share the code of the sitemap and the rewrite.php.

sitemap:

<?php
/***********************************************************************

  Copyright (C) 2002-2005  Neal Poole (smartys@gmail.com)

  This file is part of PunBB.

  PunBB is free software; you can redistribute it and/or modify it
  under the terms of the GNU General Public License as published
  by the Free Software Foundation; either version 2 of the License,
  or (at your option) any later version.

  PunBB is distributed in the hope that it will be useful, but
  WITHOUT ANY WARRANTY; without even the implied warranty of
  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  GNU General Public License for more details.

  You should have received a copy of the GNU General Public License
  along with this program; if not, write to the Free Software
  Foundation, Inc., 59 Temple Place, Suite 330, Boston,
  MA  02111-1307  USA

************************************************************************/

define('PUN_QUIET_VISIT', 1);
define('PUN_ROOT', './');
require PUN_ROOT.'include/common.php';
require PUN_ROOT.'include/rewrite.php';

// false = write to file, true = dynamic
$dynamic = true;

// This only matters if you're writing to the file
$filename = 'sitemap.xml';


// Get the topics
$result = $db->query('SELECT t.id as topic_id, subject, last_post, sticky, num_replies FROM '.$db->prefix.'topics AS t LEFT JOIN '.$db->prefix.'forum_perms AS fp ON (fp.forum_id=t.forum_id AND fp.group_id=3) WHERE (fp.read_forum IS NULL OR fp.read_forum=1) AND t.moved_to IS NULL ORDER BY last_post DESC') or error('Unable to fetch topic list', __FILE__, __LINE__, $db->error());

// Get the forums
$result2 = $db->query('SELECT c.id AS cid, c.cat_name, f.id AS fid, f.forum_name, f.forum_desc, f.redirect_url, f.moderators, f.num_topics, f.num_posts, f.last_post, f.last_post_id, f.last_poster FROM '.$db->prefix.'categories AS c INNER JOIN '.$db->prefix.'forums AS f ON c.id=f.cat_id LEFT JOIN '.$db->prefix.'forum_perms AS fp ON (fp.forum_id=f.id AND fp.group_id='.$pun_user['g_id'].') WHERE fp.read_forum IS NULL OR fp.read_forum=1 ORDER BY c.disp_position, c.id, f.disp_position') or error('Unable to fetch category/forum list', __FILE__, __LINE__, $db->error());

$output = '<?xml version="1.0" encoding="UTF-8"?>'."\n";
$output .= '<urlset xmlns="http://www.google.com/schemas/sitemap/0.84">'."\n";

// The board itself
$output .= "<url>\n";
$output .= "\t<loc>".$pun_config['o_base_url']."/</loc>\n";
$output .= "\t<lastmod>".gmdate('Y-m-d\TH:i:s+00:00', time())."</lastmod>\n";
$output .= "\t<priority>1.0</priority>\n";
$output .= "</url>\n\n";


// Output the data for the forums
while ($cur_forum = $db->fetch_assoc($result2))
{
    $lastmodified = gmdate('Y-m-d\TH:i:s+00:00', $cur_forum['last_post']);
    $viewforum = makeurl("f", $cur_forum['fid'], $cur_forum['forum_name']);
    $priority = '1.0';

    $output .= "<url>\n";
    $output .= "\t<loc>".$pun_config['o_base_url']."/".$viewforum."</loc>\n";
    $output .= "\t<lastmod>$lastmodified</lastmod>\n";
    $output .= "\t<priority>$priority</priority>\n";
    $output .= "</url>\n\n";
        
    if ($cur_forum['num_topics'] >= $pun_config['o_disp_topics_default'])
    {
        $num_pages = ceil($cur_forum['num_topics'] / $pun_config['o_disp_topics_default']);

        //Add page number for subsequent pages
        for ($i = 2; $i <= $num_pages; $i++)
        {
            $output .= "<url>\n";
            $output .= "\t<loc>".$pun_config['o_base_url']."/".$viewforum."&p=".$i."</loc>\n";
            $output .= "\t<lastmod>$lastmodified</lastmod>\n";
            $output .= "\t<priority>$priority</priority>\n";
            $output .= "</url>\n\n";
        }
    }
}

// Output the data for the topics
while ($cur_topic = $db->fetch_assoc($result))
{
    $lastmodified = gmdate('Y-m-d\TH:i:s+00:00', $cur_topic['last_post']);
    $viewtopic = makeurl("t", $cur_topic['topic_id'], $cur_topic['subject']);
    $priority = ($cur_topic['sticky'] == '1') ? '1.0' : '0.5';

    $output .= "<url>\n";
    $output .= "\t<loc>".$pun_config['o_base_url']."/".$viewtopic."</loc>\n";
    $output .= "\t<lastmod>$lastmodified</lastmod>\n";
    $output .= "\t<priority>$priority</priority>\n";
    $output .= "</url>\n\n";
        
    if ($cur_topic['num_replies'] >= $pun_config['o_disp_posts_default'])
    {
        // We add one because the first post is not counted as a reply but needs to be
        // taken into account for display
        $num_pages = ceil(($cur_topic['num_replies'] + 1) / $pun_config['o_disp_posts_default']);

        for ($i = 2; $i <= $num_pages; $i++)
        {
            $output .= "<url>\n";
            $output .= "\t<loc>".$pun_config['o_base_url']."/".$viewtopic."&p=".$i."</loc>\n";
            $output .= "\t<lastmod>$lastmodified</lastmod>\n";
            $output .= "\t<priority>$priority</priority>\n";
            $output .= "</url>\n\n";
        }
    }
}
$output .= "</urlset>\n";

// If we chose dynamic, we output the sitemap
// Otherwise, we write it to the file
if ($dynamic)
{
    header('Content-type: application/xml');
    echo $output;
}
else
{
    $file = fopen($filename, "w");
    fwrite($file, $output);
    fclose($file);
    echo "Done";
}
?>

And the rewrite.

<?php

function makeurl($type, $id, $name, $navoegsel = NULL) {
    # Type must be "f" for forum, "t" for topic or "p" for post
    # ID is the id of the content wanted
    # Name is the title of the category or topic
    

    $words = explode(" ", $name);
    $url;
    foreach ($words as $word) {
        if(strlen($word) > 3)
            $url .= '-' . $word;
    }
    $url = strtr($url,'ÀÁÂÃÄÅàáâãäåÒÓÔÕÖØòóôõöøÈÉÊËèéêëÇçÌÍÎÏìíîïÙÚÛÜùúûüÿÑñ/','AAAAAAaaaaaaOOOOOOooooooEEEEeeeeCcIIIIiiiiUUUUuuuuyNn-');
    $url = urlencode($type . $id . $url . ".html");
    
    if(isset($navoegsel))
        $url = $url."#".$navoegsel;

    return $url;
}

?>

Im really hoping for some help cause I cant make much of it. Every help is apriciate it.

Greetings Special.

Re: Error with seo sitemap help plz :)

Try removing

require PUN_ROOT.'include/rewrite.php';

from sitemap.php

http://fluxbb.org

Free PunBB Hosting - lots of mods, easy to customize

Re: Error with seo sitemap help plz :)

Smartys wrote:

Try removing

require PUN_ROOT.'include/rewrite.php';

from sitemap.php

Woohoo ^^ I love you man, I was trying to figure it out forever XD I thaught it was some titel duplicate problem Xd. Thanxs a lot man apriciate it.

Re: Error with seo sitemap help plz :)

Undiging the topic wink

I have this error :
XML analyse error : bad construction
Location : http://www.forum-des-portables-asus.fr/sitemap.php
Line 28, Column 88 :    <loc>http://www.forum-des-portables-asus.fr/f32-Actualite-Asus-nouveaux-modeles.html&p=2</loc>
----------------------------------------------------------------------------------------------^

May be can you help ?

Regards