• Smartys
  • Former PunBB Developer
  • Offline
  • Registered: 2004-04-30
  • Posts: 7,844

Topic: admin_maintenence.php

        $truncate_sql = ($db_type != 'sqlite') ? 'TRUNCATE TABLE ' : 'DELETE FROM ';
        $db->query($truncate_sql.$db->prefix.'search_matches') or error('Unable to empty search index match table', __FILE__, __LINE__, $db->error());
        $db->query($truncate_sql.$db->prefix.'search_words') or error('Unable to empty search index words table', __FILE__, __LINE__, $db->error());

Shouldn't it truncate search_cache as well?

  • From: 127.0.0.1
  • Registered: 2001-11-02
  • Posts: 9,167

Re: admin_maintenence.php

The cached search results are still valid and usable, so no.

"Programming is like sex: one mistake and you have to support it for the rest of your life."

Rickard's Website

  • Smartys
  • Former PunBB Developer
  • Offline
  • Registered: 2004-04-30
  • Posts: 7,844

Re: admin_maintenence.php

The Page wrote:

If you've added, edited or removed posts manually in the database or if you're having problems searching, you should rebuild the search index

If you add, edit, or remove posts manually, then any cached search results with them in it are invalid

  • From: 127.0.0.1
  • Registered: 2001-11-02
  • Posts: 9,167

Re: admin_maintenence.php

And by manually you mean directly in the database? If so, how do you suggest we prevent that from happening?

"Programming is like sex: one mistake and you have to support it for the rest of your life."

Rickard's Website

  • Smartys
  • Former PunBB Developer
  • Offline
  • Registered: 2004-04-30
  • Posts: 7,844

Re: admin_maintenence.php

There isn't a way to stop people from doing things to the database manually tongue
But my point is, when people rebuild the search index, their cached results should be cleared. I mean, if the issue is manually doing something to posts, then the search cache can conflict