• Smartys
  • Former PunBB Developer
  • Offline
  • Registered: 2004-04-30
  • Posts: 7,844

Topic: We could use the cache here...

Checking out admin_ranks.php we could use the ranks cache smile
Same with admin_bans (assuming we change cache.php to use the order clause for it, which is probably a good idea to do anyway)

Oh, and my feature request for caching censoring will just go here too, because it's on topic and I'm sitting at school bored tongue

  • From: 127.0.0.1
  • Registered: 2001-11-02
  • Posts: 9,167

Re: We could use the cache here...

Use the cache for what? Do you mean displaying the admin page? I generated those based on the database because it's less code. If the cache is somehow not working, the admin page wouldn't either, so I'd have to check if the cache was valid and if it wasn't, fetch it from the database anyway.

"Programming is like sex: one mistake and you have to support it for the rest of your life."

Rickard's Website

  • Smartys
  • Former PunBB Developer
  • Offline
  • Registered: 2004-04-30
  • Posts: 7,844

Re: We could use the cache here...

Yes, but it's one less query! big_smile

  • Smartys
  • Former PunBB Developer
  • Offline
  • Registered: 2004-04-30
  • Posts: 7,844

Re: We could use the cache here...

Oh, and plus, the ban cache isn't extra code: it's already in common.php! tongue
Seriously, I would just add it: we use the cache in admin_options and admin_permissions, why not in ranks and bans as well?

  • From: 127.0.0.1
  • Registered: 2001-11-02
  • Posts: 9,167

Re: We could use the cache here...

I'll investigate.

"Programming is like sex: one mistake and you have to support it for the rest of your life."

Rickard's Website