<![CDATA[PunBB Forums — rewrite rules]]> https://punbb.informer.com/forums/topic/18548/rewrite-rules/ Mon, 03 Mar 2008 12:57:39 +0000 PunBB <![CDATA[Re: rewrite rules]]> https://punbb.informer.com/forums/post/110878/#p110878 Changed it into:

rewrite_rules.php

'/^gallery(\.html?|\/)?$/i'                             => 'index.php?gallery',
'/^gallery[\/_-]album[\/_-]?(.*?|\/)(\.html?|\/)?$/i'  => 'index.php?gallery=&album=$1'

Folder_based.php

'gallery'        => 'gallery/',
'gallery_album'  => 'gallery/album/$1/'

And I had to change manifest.xml because all the scripts and css used PUN_ROOT and then with folder_based they did not load, changed it into $base_url.

Thanks for all the help daris smile

]]> Mon, 03 Mar 2008 12:57:39 +0000 https://punbb.informer.com/forums/post/110878/#p110878 <![CDATA[Re: rewrite rules]]> https://punbb.informer.com/forums/post/110877/#p110877 rewrite_rules.php:

$pun_rewrite_rules_gallery = array(
  '/^gallery(\.html?|\/)?$/i'       => 'index.php?gallery=',
  '/^gallery[\/_-]album[\/_-]?(.*?)(\.html?|\/)?$/i'  => 'index.php?gallery=&album=$1'
);

Folder_based.php:

$pun_url_gallery = array(
  'gallery'        => 'gallery/',
  'gallery_album'  => 'gallery/album/$1/'
);

]]> Mon, 03 Mar 2008 12:33:55 +0000 https://punbb.informer.com/forums/post/110877/#p110877 <![CDATA[Re: rewrite rules]]> https://punbb.informer.com/forums/post/110875/#p110875 Thanks daris, it works smile

the only thing that does not work is folder_based.php, he does not seem to do something with / but he does with - hmm

]]> Mon, 03 Mar 2008 12:09:25 +0000 https://punbb.informer.com/forums/post/110875/#p110875 <![CDATA[Re: rewrite rules]]> https://punbb.informer.com/forums/post/110870/#p110870 I replaced:

'/^gallery[\/_-]album[\/_-]?(.*?)(\.html?|\/)?$/i'  => 'index.php?gallery&gallery=$1'

with:

'/^gallery[\/_-]album[\/_-]?(.*?)(\.html?|\/)?$/i'  => 'index.php?gallery=&album=$1'

and it works big_smile

Simple method for check what is wrong:

echo '<pre>';
print_r($_GET);
echo '</pre>';

and it prints:

Array
(
    [gallery] =>
    [amp;album] => Lytebox
)

album is not set, amp;album is set wink

It explode url by "&":

$query_string = explode('&', $url_parts[1]);

(60 line of rewrite_rules.php)

]]> Mon, 03 Mar 2008 11:13:06 +0000 https://punbb.informer.com/forums/post/110870/#p110870 <![CDATA[Re: rewrite rules]]> https://punbb.informer.com/forums/post/110771/#p110771 Thanks for trying daris, I also tried your code but I am now using index.php?gallery&album=$1

I tried to replace it in your code but I still do not get the album sad

[edit] version that I now use you can download here http://kierownik.nl/download.php?actie=bekijk&id=13

]]> Sun, 02 Mar 2008 11:07:50 +0000 https://punbb.informer.com/forums/post/110771/#p110771 <![CDATA[Re: rewrite rules]]> https://punbb.informer.com/forums/post/110769/#p110769 I installed your extension, changed some code and it works. Here is changed gallery.php file (between /***) and rewrite rule which i used:

/^gallery[\/_-]album[\/_-]?(.*?)(\.html?|\/)?$/i'  => 'extensions/gallery/gallery.php?gallery=$1'

]]> Sun, 02 Mar 2008 10:55:00 +0000 https://punbb.informer.com/forums/post/110769/#p110769 <![CDATA[Re: rewrite rules]]> https://punbb.informer.com/forums/post/110757/#p110757 Yep now I see, changed it into:
  '/^gallery[\/_-]album[\/_-]?([A-Za-z0-9-]+).*(\.html?|\/)?$/i'  => 'index.php?gallery&album=$1'

but now going to http://pundemo.kierownik.nl/gallery-album-Lightbox.html will not show that album

phoe phoe, that sef url thing is more difficult than I thought roll

[edit] It seems that $_GET['album'] cannot be found hmm

]]> Sun, 02 Mar 2008 02:10:58 +0000 https://punbb.informer.com/forums/post/110757/#p110757 <![CDATA[Re: rewrite rules]]> https://punbb.informer.com/forums/post/110756/#p110756 The link I'm now seeing is
http://pundemo.kierownik.nl/gallery-album-Lightbox.html
Do you see why that doesn't match the regex?

]]> Sun, 02 Mar 2008 02:02:42 +0000 https://punbb.informer.com/forums/post/110756/#p110756 <![CDATA[Re: rewrite rules]]> https://punbb.informer.com/forums/post/110755/#p110755 changed it to
  '/^gallery_album[\/_-]?([A-Za-z0-9-]+).*(\.html?|\/)?$/i'  => 'index.php?gallery&album=$1'

but still get the Bad request hmm

]]> Sun, 02 Mar 2008 01:58:34 +0000 https://punbb.informer.com/forums/post/110755/#p110755 <![CDATA[Re: rewrite rules]]> https://punbb.informer.com/forums/post/110754/#p110754 Yes. Replace [0-9] there with [a-z]

]]> Sun, 02 Mar 2008 01:49:04 +0000 https://punbb.informer.com/forums/post/110754/#p110754 <![CDATA[Re: rewrite rules]]> https://punbb.informer.com/forums/post/110753/#p110753 searched the web about arbitrary elements but could not find any good explanation for it in my language so I used http://babelfish.altavista.com/tr that tells me that arbitrary elements are random elements. What I am then asking myself is, what elements.

I know that everyting looks like I want to, so too how the links should look like e.g. gallery/album/Lightbox but then after clicking I get the Bad request.

I think my mistake is in the line:
  '/^gallery_album[\/_-]?([0-9]+).*(\.html?|\/)?$/i'  => 'index.php?gallery?album=$1'

]]> Sun, 02 Mar 2008 01:45:23 +0000 https://punbb.informer.com/forums/post/110753/#p110753 <![CDATA[Re: rewrite rules]]> https://punbb.informer.com/forums/post/110752/#p110752 Aha
http://pundemo.kierownik.nl/gallery.htm … m=Lightbox
You shouldn't be adding arbitrary elements to the URL. You should be using pun_link for that.

]]> Sun, 02 Mar 2008 01:29:34 +0000 https://punbb.informer.com/forums/post/110752/#p110752 <![CDATA[Re: rewrite rules]]> https://punbb.informer.com/forums/post/110751/#p110751 And what is the problem you're having?

]]> Sun, 02 Mar 2008 01:27:51 +0000 https://punbb.informer.com/forums/post/110751/#p110751 <![CDATA[Re: rewrite rules]]> https://punbb.informer.com/forums/post/110744/#p110744 Latest SVN = 1537

rewrite_rules.php

<?php

$pun_rewrite_rules_gallery = array(
  '/^gallery(\.html)?$/i'                             => 'index.php?gallery',
  '/^gallery_album[\/_-]?([0-9]+).*(\.html?|\/)?$/i'  => 'index.php?gallery?album=$1'
);

$pun_rewrite_rules = array_merge($pun_rewrite_rules, $pun_rewrite_rules_gallery);

Default.php

<?php

// Make sure no one attempts to run this script "directly"
if (!defined('PUN'))
  exit;

$pun_url_gallery = array(
  'gallery'       => 'index.php?gallery',
  'gallery_album' => 'index.php?gallery&album=$1'
);

$pun_url = array_merge($pun_url, $pun_url_gallery);

File_based.php

<?php

// Make sure no one attempts to run this script "directly"
if (!defined('PUN'))
  exit;

$pun_url_gallery = array(
  'gallery'       => 'gallery.html',
  'gallery_album' => 'gallery.html&album=$1'
);

$pun_url = array_merge($pun_url, $pun_url_gallery);

File_based_(fancy).php

<?php

// Make sure no one attempts to run this script "directly"
if (!defined('PUN'))
  exit;

$pun_url_gallery = array(
  'gallery'         => 'gallery.html',
  'gallery_album'  => 'gallery/album_$1.html'
);

$pun_url = array_merge($pun_url, $pun_url_gallery);

Folder_based.php

<?php

// Make sure no one attempts to run this script "directly"
if (!defined('PUN'))
  exit;

$pun_url_gallery = array(
  'gallery'        => 'gallery',
  'gallery_album'  => 'gallery/album/$1'
);

$pun_url = array_merge($pun_url, $pun_url_gallery);
echo "<li class=\"topactive\"><a href=\"".pun_link ( $pun_url['gallery_album'], array($li_gallery_name, sef_friendly ( $li_gallery_name ) ) )."\"><span>".htmlentities ( $dir )."</span></a></li>";

and $li_gallery_name gives the &_GET['album']

]]> Sat, 01 Mar 2008 23:37:13 +0000 https://punbb.informer.com/forums/post/110744/#p110744 <![CDATA[Re: rewrite rules]]> https://punbb.informer.com/forums/post/110743/#p110743 Try using the latest SVN. If it still doesn't work, repost all the code you're using now in your extension.

]]> Sat, 01 Mar 2008 23:29:24 +0000 https://punbb.informer.com/forums/post/110743/#p110743