PunBB Forums — Too long title on topic posts page

Re: Too long title on topic posts page

null@example.com (Papillon) — Mon, 07 Dec 2009 15:35:11 +0000

Could you fix this after all? I see that this thread title for instance is just as you wanted... how did you it go with your own forum?

Re: Too long title on topic posts page

null@example.com (cigs) — Thu, 05 Nov 2009 12:10:31 +0000

no -- it didnt work -- looks like it stays the same

Re: Too long title on topic posts page

null@example.com (Angel) — Wed, 04 Nov 2009 14:31:12 +0000

Try replacing the code you got from viewtopic.php with this:

// Setup breadcrumbs
$forum_page['crumbs'] = array(
    array($forum_config['o_board_title'], forum_link($forum_url['index'])),
    array($cur_topic['forum_name'], forum_link($forum_url['forum'], array($cur_topic['forum_id'], sef_friendly($cur_topic['forum_name']))))
);

If that works, tell me. I have to leave for work, like, right now so I can't test/remove the code from functions.php

Re: Too long title on topic posts page

null@example.com (cigs) — Wed, 04 Nov 2009 09:50:49 +0000

viewtopic.php
lines: 230-235

// Setup breadcrumbs
$forum_page['crumbs'] = array(
    array($forum_config['o_board_title'], forum_link($forum_url['index'])),
    array($cur_topic['forum_name'], forum_link($forum_url['forum'], array($cur_topic['forum_id'], sef_friendly($cur_topic['forum_name'])))),
    array($cur_topic['subject'], forum_link($forum_url['topic'], array($id, sef_friendly($cur_topic['subject']))))
);

include/functions.php
lines: 501-533

// Generate breadcrumb navigation
function generate_crumbs($reverse)
{
    global $lang_common, $forum_url, $forum_config, $forum_page;

    $return = ($hook = get_hook('fn_generate_crumbs_start')) ? eval($hook) : null;
    if ($return != null)
        return $return;

    if (empty($forum_page['crumbs']))
        $forum_page['crumbs'][0] = $forum_config['o_board_title'];

    $crumbs = '';
    $num_crumbs = count($forum_page['crumbs']);

    if ($reverse)
    {
        for ($i = ($num_crumbs - 1); $i >= 0; --$i)
            $crumbs .= (is_array($forum_page['crumbs'][$i]) ? forum_htmlencode($forum_page['crumbs'][$i][0]) : forum_htmlencode($forum_page['crumbs'][$i])).((isset($forum_page['page']) && $i == ($num_crumbs - 1)) ? ' ('.$lang_common['Page'].' '.forum_number_format($forum_page['page']).')' : '').($i > 0 ? $lang_common['Title separator'] : '');
    }
    else
        for ($i = 0; $i < $num_crumbs; ++$i)
        {
            if ($i < ($num_crumbs - 1))
                $crumbs .= ''.(($i >= 1) ? ''.$lang_common['Crumb separator'].'' : '').(is_array($forum_page['crumbs'][$i]) ? ''.forum_htmlencode($forum_page['crumbs'][$i][0]).'' : forum_htmlencode($forum_page['crumbs'][$i])).' ';
            else
                $crumbs .= ''.(($i >= 1) ? ''.$lang_common['Crumb separator'].'' : '').(is_array($forum_page['crumbs'][$i]) ? ''.forum_htmlencode($forum_page['crumbs'][$i][0]).'' : forum_htmlencode($forum_page['crumbs'][$i])).' ';
        }

    ($hook = get_hook('fn_generate_crumbs_end')) ? eval($hook) : null;

    return $crumbs;
}

where do i fix to remove

.....- PunBB 1.3 discussion - PunBB Forums

for example on this forum topic page ... ???

Re: Too long title on topic posts page

null@example.com (Slavok) — Tue, 03 Nov 2009 09:55:27 +0000

The page title is generated based on the page breadcrumbs. Setting breadcrumbs for a viewtopic page is done at 231-235 lines of "viewtopic.php". The function "generate_crumbs" (502 line of "/include/functions.php") generates the resulting string. Will this information be enough for you?

Too long title on topic posts page

null@example.com (cigs) — Tue, 03 Nov 2009 08:56:02 +0000

I noticed, it is too long title on topic posts page ... I think it is not too good for SEO

How to make title on topic name only???

I also dont like "(Page1)" and whatever in title tag ...

</strong> tag could be nicer</p><p>for example this topic:</p><div class="codebox"><pre><code><title>Too long title on topic posts page (Page 1) - PunBB 1.3 discussion - PunBB Forums