PunBB Forums — [not bug] Bad hd_visit_elements hook location in header.php

Re: [not bug] Bad hd_visit_elements hook location in header.php

null@example.com (Lion) — Mon, 14 Nov 2011 18:15:07 +0000

Ok, thanks for the infos.
Everythings works great now.

Re: [not bug] Bad hd_visit_elements hook location in header.php

null@example.com (dimkalinux) — Sun, 13 Nov 2011 19:58:14 +0000

Its not error.

It changed in 1.4 for adding menu elements by simple adding entries in $visit_elements array or $visit_links array. In 1.4 extensions must extend $visit_links or $visit_elements arrays for adding new elements.

We use this new method in pun_pm for 1.4 - https://github.com/punbb/extensions/blo … t.xml#L474

[not bug] Bad hd_visit_elements hook location in header.php

null@example.com (Lion) — Sun, 13 Nov 2011 18:55:20 +0000

In header.php, the hd_visit_elements hook is located on line 206 BEFORE the declaration of $visit_elements[''] (on line 208).

It causes an error when using extensions like pun_pm who extends the content of $visit_elements[''].
The error is gone when the hook is moved after the variable declaration.

In the 1.3.6 version of header.php, the hook was after the variable declaration.

So I assume the new location of the hook is really an error in the code of PunBB 1.4 ?