PunBB Forums — parser.php - tags, that musn't be closed.

Re: parser.php - tags, that musn't be closed.

null@example.com (keeshii) — Sat, 19 Oct 2013 09:39:56 +0000

Install this extension: om_close_tag_test.zip. It adds the tag "username", which will be replaced by the name of user displaying the forum.

Now try to write a message like this:

Hello [username]! Your name is [username], right?

And the following error will be displayed:

[username] was opened within itself, this is not allowed

Re: parser.php - tags, that musn't be closed.

null@example.com (dimkalinux) — Tue, 15 Oct 2013 07:48:29 +0000

keeshi, can you make example for non-closed tag?

parser.php - tags, that musn't be closed.

null@example.com (keeshii) — Tue, 17 Sep 2013 19:00:28 +0000

I tried to add to bbcode some new tags, which don't have closing element. I added name of tag to array $tags_open and not to $tags_closed, but parser keep telling me, that I haven't closed my new tag during validation.

I suggest to change this fragment of code in parser.php:

@@ -480,13 +486,16 @@
             }
 
             if (in_array($current_tag, array_keys($tags_limit_bbcode)))
                 $limit_bbcode = $tags_limit_bbcode[$current_tag];
 
-            $open_tags[] = $current_tag;
-            $open_args[] = $current_arg;
-            $opened_tag++;
+            // add open_tags to stack only if they must be closed.
+            if (!in_array($current_tag, $tags_opened) || in_array($current_tag, $tags_closed)) {
+                $open_tags[] = $current_tag;
+                $open_args[] = $current_arg;
+                $opened_tag++;
+            }
             $new_text .= $current;
             continue;
         }
     }

This did the trick for me.

I know that arrays $tags_open and $tags_closed are equal, but now it is hard to make an extension, which adds non-closing tags into bbcode.