[Release] AP_Broadcast_Email 1.0 (Page 2 of 3)

Can anyone help me?

Seems I am having the same problem too now. Need something that would "limit" the number of emails sent out by the AP_Broadcast_Email to a batch of say 500 emails at a time in different time intervals. Or something like that? ...I dunno.

I seem to be on a roll with useless nuggets of info today. This is an alteration for line 55 in the broadcast mail plugin, again for a pgsql database. Change line ~55 to:

$sql = "SELECT count (username) AS usercount FROM ".$db->prefix."users WHERE username != 'Guest'";

Change the registered email address of all your banned members to something fictional That's what I've been doing.

Whenever I ban someone I change there email to banned_1@mydomain.com, banned_2@mydomain.com etc, I also change there password so they cant request a new one if the Ban Process ever fails me

Change this:

else if (isset($_POST['send_message']))
{

        require_once PUN_ROOT.'include/email.php';

        // Display the admin navigation menu
        generate_admin_menu($plugin);

        $sql = "SELECT username, email
                                FROM ".$db->prefix."users
                                WHERE username != 'Guest'
                                ORDER BY username";

to this:

else if (isset($_POST['send_message']))
{

        require_once PUN_ROOT.'include/email.php';

        // Display the admin navigation menu
        generate_admin_menu($plugin);

//--------------------------------------------------------------------//

        $banned_array = array();
        $idcheck = $db->query('SELECT username FROM '.$db->prefix.'bans') or error('Unable to fetch banned users', __FILE__, __LINE__, $db->error());

        while (false !== ($banned = $db->fetch_assoc($idcheck)))
        {
                $banned_array[] = '\''.$db->escape($banned['username']).'\'';
        }

        $banned_array[] = '\'Guest\'';

//--------------------------------------------------------------------//

        $sql = "SELECT username, email
                        FROM ".$db->prefix."users
                        WHERE username NOT IN (".implode(', ', $banned_array).")
                        ORDER BY username";

It should have worked fine if you applied the changes correctly.

Any chance you could post a copy of the code as it was when you modified that code? I'm curious now.

Plus, for the failure bit, changing this line:

pun_mail($mail_to, $mail_subject, $mail_message);

to

@pun_mail($mail_to, $mail_subject, $mail_message);

should, I believe, cause it to ignore/suppress the errors and continue.

Ok, here it is:

else if (isset($_POST['send_message']))
{

        require_once PUN_ROOT.'include/email.php';
        @set_time_limit(0);

        // Display the admin navigation menu
        generate_admin_menu($plugin);
// added by MattF--------------------------------------------------- //
        $banned_array = array();
        $idcheck = $db->query('SELECT username FROM punbb_bans') or error('Unable to fetch banned users', __FILE__, __LINE__, $db->error());

        while (false !== ($banned = $db->fetch_assoc($idcheck)))
                {
                    $banned_array[] = '\''.$db->escape($banned['username']).'\'';
                }

        $banned_array[] = '\'Guest\'';
        // ------------------------------------------------------------------- //

        $sql = "SELECT username, email
                                FROM ".$db->prefix."users
                                WHERE username NOT IN (".implode(', ', $banned_array).")
                                ORDER BY username";
        $result = $db->query($sql) or error('Could not get users from the database', __FILE__, __LINE__, $db->error());
        while($row = $db->fetch_assoc($result))

The problem with the banned users was the database prefix, we use only 'pun_'. While everywhere the prefix is called by its variable ($db->prefix) you named it 'punbb_' in your line starting with '$idcheck.....'. Although, I wonder why I did not get any error message (Unable to fetch banned users)?

Thx, I'll try this.

EDIT: Unfortunately the main problem is not solved by the '@' in front of the function name.

wobo

I guess so because after fixing that prefix there was no error related to the banned user patch.

The problem with the whole thing is, there is no way to test such a thing as mass mailings. I already received mails from people who complained that they received the mail twice.

wobo

In principle you are right, but in this case here such a test would not show me such an error as I get with the plugin because I don't know what causes this error. The problem is that there is no info at all how many mails were sent until the error occurred or which address caused the error.

wobo

Sorry, but I disagree. Why should /include/email.php bypass any errors? If a mail gets sent via /include/email.php (like during the registration process or by a topic subscription) I definitely want to know when there is an error with an address, so I can ask the user to fix his profile's mail info.

Broadcast_Email plugin is rather a loop construct where I don't want to end the loop whenever an error occurs. So this loop construct should contain the error handling like, in simple words :

if return(pun_mail) = 1 then
  print "error with user_id [ID number]"
  go on

Sorry, I'm not a coder but you may get what I mean.

Broadcast_Email is a fine plugin, I was desperately searching for a forum mass mail routine. But it is useless for me if only one mail address in a large database is faulty.

wobo

Yes, I think so, although my knowledge is not good enough (by far) to actually tweak the broadcast code,
Like, because I learned Latin in school I understand most Italian documents but I would not be able to write one myself.

wobo