[ Closed ] PunBB 1.2.16 (Page 2 of 3)

MattF · 2007-11-20 17:02

MattF
Senior Member
Offline

From: South Yorkshire, England
Registered: 2007-03-15
Posts: 1,956

Re: PunBB 1.2.16

MattF wrote:

Cheers for the update. Just one quickie. With the profile.php change, would it not be simpler to just make that a preliminary check in profile.php near the top of the file, so that it acts as a cover all incase anyone mods their file later on with something problematical?

Just prodding on this one. Would a general check of:

if (isset($_POST['form_sent']))
{
    if ($pun_user['g_id'] < PUN_GUEST)
        {
        confirm_referrer('profile.php');
         }
}

at the top of profile.php prevent any future possibility of that occuring with any additions to profile.php, i.e: mods?

Cheers,

Matt

Rickard · 2007-11-20 17:18

Rickard
PunBB Developer
Offline

From: 127.0.0.1
Registered: 2001-11-02
Posts: 9,167

Re: PunBB 1.2.16

MattF wrote:

Cheers for the update. Just one quickie. With the profile.php change, would it not be simpler to just make that a preliminary check in profile.php near the top of the file, so that it acts as a cover all incase anyone mods their file later on with something problematical?

confirm_referrer() is gone in 1.3. See http://blog.punbb.org/2007/09/18/preven … f-attacks/

"Programming is like sex: one mistake and you have to support it for the rest of your life."

MattF · 2007-11-20 17:23

MattF
Senior Member
Offline

From: South Yorkshire, England
Registered: 2007-03-15
Posts: 1,956

Re: PunBB 1.2.16

Aye. I'd read that blog entry awhile ago. I know I'm going against the flow here, but I must admit, I'll probably be running 1.2* for a good while after 1.3 comes out. In all honesty, there's not really anything which a bit of coding can't sort which I don't have that I want in 1.2*.

gil · 2007-11-20 21:31

gil
Member
Offline

Registered: 2005-10-12
Posts: 45

Re: PunBB 1.2.16

gil wrote:

About documentation, the http://punbb.org/docs/install.html is not up to date :
There are several "1.2.12" in place of "1.2.14" (and a "12_to_1212_update.php" of course).
Sorry to only discover serious problems
(note; the install.html file in 1.2.14 zip package is OK)

Sorry, I was not present for the 1.2.15 version

Fil1958 · 2007-11-21 06:21

Fil1958
Member
Offline

From: Divided States Of Europa
Registered: 2005-06-21
Posts: 18

Re: PunBB 1.2.16

Smartys wrote:

Makes sense. Try this code from login.php instead

$redirect_url = (isset($_SERVER['HTTP_REFERER']) && preg_match('#^'.preg_quote($pun_config['o_base_url']).'/(.*?)\.php#i

Yes I tried this code, but redirect_url is always index.php anywhere !?

Exemple, if I read a topic (http://domain.com/forum/viewtopic.php?pid=1618#p1618) , after login in I am on index.php and not in the topic that I read

Why ?

Sorry I speak English like a Spanish cow :/
Multy Forums Free (Multi PunBB Project) (on stand by)
http://multy.forums.free.fr/forum_demo/

Smartys · 2007-11-21 11:59

Smartys
Former PunBB Developer
Offline

Registered: 2004-04-30
Posts: 7,844

Re: PunBB 1.2.16

I would need to check out the site

Fil1958 · 2007-11-21 13:22

Fil1958
Member
Offline

From: Divided States Of Europa
Registered: 2005-06-21
Posts: 18

Re: PunBB 1.2.16

Thanks for reply Smartys

The board is here -> http://clopotelfrance.free.fr/forum/index.php

This is a free service from our IProvider -> http://www.free.fr/

Sorry I speak English like a Spanish cow :/
Multy Forums Free (Multi PunBB Project) (on stand by)
http://multy.forums.free.fr/forum_demo/

D9r · 2007-11-21 18:46

D9r
Senior Member
Offline

From: Atlanta, Georgia
Registered: 2004-08-18
Posts: 148

Re: PunBB 1.2.16

Fil1958 wrote:

Some problems with redirect_url when login in
My domain -> http://domain.com/
PunBB base url -> http://domain.com/forum
After login in the redirect url is http://domain.com/forum//forum/index.php

You own 'domain.com'? Awesome! How much did it cost to get it?

Domain.com is a real domain. For examples it's recommended to use Example.com, Example.net, and Example.org.

Dean
One of these days, I'm going to upgrade my forum.
D9r.com - homepage
Tucker & DeKalb County, Georgia -- news, events, zoning, politics, directory
HiveMinds.info - International Web Developer Forum (lots of smart folks here)

Smartys · 2007-11-21 18:56

Smartys
Former PunBB Developer
Offline

Registered: 2004-04-30
Posts: 7,844

Re: PunBB 1.2.16

Fil1958 wrote:

Thanks for reply Smartys
The board is here -> http://clopotelfrance.free.fr/forum/index.php
This is a free service from our IProvider -> http://www.free.fr/

I can't log in until I get my activation email, which seems to be taking a while

Edit: I'm still waiting, and I registered a second account to a different email account that also hasn't gotten the activation email

bingiman · 2007-11-22 12:13

bingiman
Senior Member
Offline

From: Canada
Registered: 2007-02-18
Posts: 760

Re: PunBB 1.2.16

This line of code is still a problem:

    // Prefix with o_base_url (unless it's there already)
    if (strpos($destination_url, $pun_config['o_base_url']) !== 0)
        $destination_url = $pun_config['o_base_url'].'/'.$destination_url;

    // Do a little spring cleaning
    $destination_url = preg_replace('/([\r\n])|(%0[ad])|(;[\s]*data[\s]*:)/i', '', $destination_url);

This is what's causing the problem on this thread:

http://punbb.org/forums/viewtopic.php?id=17591

I removed it and put the old code back and it works every time.

Smartys · 2007-11-22 12:57

Smartys
Former PunBB Developer
Offline

Registered: 2004-04-30
Posts: 7,844

Re: PunBB 1.2.16

I can't replicate it, and the fact that it occurs in the plugin likely means the plugin is doing something wrong that wasn't caught before
Could you paste the code for the plugin in that thread?

bingiman · 2007-11-22 19:06

bingiman
Senior Member
Offline

From: Canada
Registered: 2007-02-18
Posts: 760

Re: PunBB 1.2.16

I sent you an email Smarty's with some login info to test yourself.

Cheers!
Bingiman

Smartys · 2007-11-22 19:22

Smartys
Former PunBB Developer
Offline

Registered: 2004-04-30
Posts: 7,844

Re: PunBB 1.2.16

Don't send it via the email form, it has issues sending to PunBB.org emails (I'm assuming that's why I don't have your email)

bingiman · 2007-11-22 21:09

bingiman
Senior Member
Offline

From: Canada
Registered: 2007-02-18
Posts: 760

Re: PunBB 1.2.16

I am assuming you received the email though?

elbekko · 2007-11-22 21:11

elbekko
Senior Member
Offline

From: Leuven, Belgium
Registered: 2005-06-14
Posts: 2,653

Re: PunBB 1.2.16

He said he didn't...

bingiman · 2007-11-22 21:20

bingiman
Senior Member
Offline

From: Canada
Registered: 2007-02-18
Posts: 760

Re: PunBB 1.2.16

Actually, he never said that. He said there are issues. Anyway, he doesn't need it I guess because he knows there is an issue. If you need to check it still Smartys my email is: shedrock@sympatico.ca

elbekko · 2007-11-22 21:31

elbekko
Senior Member
Offline

From: Leuven, Belgium
Registered: 2005-06-14
Posts: 2,653

Re: PunBB 1.2.16

Smartys wrote:

(I'm assuming that's why I don't have your email)

Mmh?

bingiman · 2007-11-22 21:42

bingiman
Senior Member
Offline

From: Canada
Registered: 2007-02-18
Posts: 760

Re: PunBB 1.2.16

hmm...sometimes I think I am dumb. or maybe just overworked. Sorry about that elbekko...my bad.

HJH · 2007-11-23 14:50

HJH
Member
Offline

Registered: 2005-11-03
Posts: 36

Re: PunBB 1.2.16

Hello All, developers,

I think there is still an oversight in the code for 1.2.16:
in include/functions.php, look for line:

if ($register_globals === "" || $register_globals === "0" || strtolower($register_globals) === "off")

I think you will find that should be:

if ($register_globals === "" || $register_globals === "0" || strtolower($register_globals) === "off"))

Hendrik-Jan

Smartys · 2007-11-23 15:04

Smartys
Former PunBB Developer
Offline

Registered: 2004-04-30
Posts: 7,844

Re: PunBB 1.2.16

HJH wrote:

Hello All, developers,
I think there is still an oversight in the code for 1.2.16:
in include/functions.php, look for line:
if ($register_globals === "" || $register_globals === "0" || strtolower($register_globals) === "off")
I think you will find that should be:
if ($register_globals === "" || $register_globals === "0" || strtolower($register_globals) === "off"))

Hendrik-Jan

Mmm, no, that's an extra closing parenthesis: that would give a parse error

HJH · 2007-11-23 15:43

HJH
Member
Offline

Registered: 2005-11-03
Posts: 36

Re: PunBB 1.2.16

Hmm, then I must have opened one before, as I get an error without it...
I'll check my code.

edit: found it; I had:
if ($register_globals === "" || $register_globals === "0" || strtolower($register_globals === "off"))

now I have:
if ($register_globals === "" || $register_globals === "0" || strtolower($register_globals) === "off")

as it should be. Sorry!

Rador8 · 2007-11-25 01:42

Rador8
Member
Offline

Registered: 2004-08-13
Posts: 77

Re: PunBB 1.2.16

Hi everybody,

Thanks for the new version.

dude07 · 2007-12-02 19:16

dude07
Member
Offline

Registered: 2007-04-19
Posts: 84

Re: PunBB 1.2.16

Fil1958 wrote:

Hi all
Some problems with redirect_url when login in
My domain -> http://domain.com/
PunBB base url -> http://domain.com/forum
After login in the redirect url is http://domain.com/forum//forum/index.php
What can I do please ?

Have this same issue. Haven't modified login.php. The suggestion from Smartys didn't help.

Smartys · 2007-12-02 19:22

Smartys
Former PunBB Developer
Offline

Registered: 2004-04-30
Posts: 7,844

Re: PunBB 1.2.16

Link?

dude07 · 2007-12-02 19:39

dude07
Member
Offline

Registered: 2007-04-19
Posts: 84

Re: PunBB 1.2.16

Sorry. I removed the patch.

[ Closed ] PunBB 1.2.16 (Page 2 of 3)

Posts: 26 to 50 of 72

26 Reply by MattF 2007-11-20 17:02

Re: PunBB 1.2.16

27 Reply by Rickard 2007-11-20 17:18

Re: PunBB 1.2.16

28 Reply by MattF 2007-11-20 17:23

Re: PunBB 1.2.16

29 Reply by gil 2007-11-20 21:31

Re: PunBB 1.2.16

30 Reply by Fil1958 2007-11-21 06:21 (edited by Fil1958 2007-11-21 06:32)

Re: PunBB 1.2.16

31 Reply by Smartys 2007-11-21 11:59

Re: PunBB 1.2.16

32 Reply by Fil1958 2007-11-21 13:22

Re: PunBB 1.2.16

33 Reply by D9r 2007-11-21 18:46 (edited by D9r 2007-11-21 19:04)

Re: PunBB 1.2.16

34 Reply by Smartys 2007-11-21 18:56 (edited by Smartys 2007-11-21 19:43)

Re: PunBB 1.2.16

35 Reply by bingiman 2007-11-22 12:13

Re: PunBB 1.2.16

36 Reply by Smartys 2007-11-22 12:57

Re: PunBB 1.2.16

37 Reply by bingiman 2007-11-22 19:06

Re: PunBB 1.2.16

38 Reply by Smartys 2007-11-22 19:22

Re: PunBB 1.2.16

39 Reply by bingiman 2007-11-22 21:09

Re: PunBB 1.2.16

40 Reply by elbekko 2007-11-22 21:11

Re: PunBB 1.2.16

41 Reply by bingiman 2007-11-22 21:20

Re: PunBB 1.2.16

42 Reply by elbekko 2007-11-22 21:31

Re: PunBB 1.2.16

43 Reply by bingiman 2007-11-22 21:42

Re: PunBB 1.2.16

44 Reply by HJH 2007-11-23 14:50

Re: PunBB 1.2.16

45 Reply by Smartys 2007-11-23 15:04

Re: PunBB 1.2.16

46 Reply by HJH 2007-11-23 15:43 (edited by HJH 2007-11-23 16:02)

Re: PunBB 1.2.16

47 Reply by Rador8 2007-11-25 01:42

Re: PunBB 1.2.16

48 Reply by dude07 2007-12-02 19:16

Re: PunBB 1.2.16

49 Reply by Smartys 2007-12-02 19:22

Re: PunBB 1.2.16

50 Reply by dude07 2007-12-02 19:39

Re: PunBB 1.2.16

Posts: 26 to 50 of 72