PunBB 1.1.2 - Impressions

diff -crbB punbb-1.1.1/upload/footer.php punbb-1.1.2/upload/footer.php
*** punbb-1.1.1/upload/footer.php    Thu Jan  8 22:43:30 2004
--- punbb-1.1.2/upload/footer.php    Sat Feb 14 02:33:11 2004
***************
*** 72,79 ****
                              <select name="id" onchange="window.location=('viewforum.php?id='+this.options[this.selectedIndex].value)">
  <?php
  
!     if ($cur_user['status'] < PUN_MOD)
!         $extra = ' WHERE f.admmod_only=\'0\'';
  
      $result = $db->query('SELECT c.id AS cid, c.cat_name, f.id AS fid, f.forum_name FROM '.$db->prefix.'categories AS c INNER JOIN '.$db->prefix.'forums AS f ON c.id=f.cat_id'.$extra.' ORDER BY c.disp_position, c.id, f.disp_position') or error('Unable to fetch category/forum list', __FILE__, __LINE__, $db->error());
  
--- 72,78 ----
                              <select name="id" onchange="window.location=('viewforum.php?id='+this.options[this.selectedIndex].value)">
  <?php
  
!     $extra_sql = ($cur_user['status'] < PUN_MOD) ? ' WHERE f.admmod_only=\'0\'' : '';
  
      $result = $db->query('SELECT c.id AS cid, c.cat_name, f.id AS fid, f.forum_name FROM '.$db->prefix.'categories AS c INNER JOIN '.$db->prefix.'forums AS f ON c.id=f.cat_id'.$extra.' ORDER BY c.disp_position, c.id, f.disp_position') or error('Unable to fetch category/forum list', __FILE__, __LINE__, $db->error());
  

That must be a bug, if you're renaming it to extra_sql, in the next line it should also be extra_sql instead of extra, right?

Marc

BTW, having the diff file makes a big difference, since I can implement it as if it was a mod, line by line, without having to reapply all my changes. Thanks a lot!

Well, it's certainly fancier. Not sure I like it better, though. I'll have to get used to it
The problem is that modding only works if there are few changes. If this was a new release, I'd be going through hell to implement it.

BTW, I'm curious about the exit(); lines that you've been adding after the header(Location:...); I thought the parser would never execute code after that, but now I am not so sure it might be the client that upon receipt changes the request. I miss the Server.Transfer and Response.Redirect commands... sniff

Marc

I have now moved every release starting from 1.1 into a subversion repository. I didn't bother to start from 1.0 since files has been moved all over the place, but sure it's possible if you know what file moved where.

I'm going to sort out a few minor issues before I post the url to the repo.

I'm sorry, but I have no idea what you just said.

The hdiff's aren't patches, they are visual representations of the differences between two versions. If you want to patch, you should use the patch-files.

Lys nyheten på framsidan angående PunBB 1.1.2-releasen.

Alltså jag fattar fan inte vad du menar. "Changed files" innehåller de filer som uppdaterats sedan förra releasen. Patch-filen innehåller information om vad som förändrats i de olika skripten och denna patch-fil kan köras genom unix-kommandot patch som då automatiskt uppdaterar alla filer som är påverkade. Vad är det som är konstigt med det?

strunt samma. allt är ju trots allt löst