1 Topic by axa

  • axa
  • Member
  • Offline
  • From: Charlotte, NC
  • Registered: 2007-02-18
  • Posts: 63

Topic: Am I headed for a fall ?

I am running 1.2.16 with a number of the more common mods - private messaging, calendar, upload etc...
Up until and including 1.2.16 I would always update manually using the hdiff as a guide - as you know, numerous mods ensure this is the safest way to update.

I have been reticent to update to 1.2.17 as the hdiff looks a little daunting to me - with absolutely no php knowledge at all - I rely on common sense and very careful copying/pasting. Previous updates have been relatively easy with the hdiff.

Am I relatively safe waiting for 1.3 to come out before I update ?
I am sure the 1.3 install/upgrade will accommodate my mods, but am fearful that I should update to 1.2.17 first.

Comments ?

Landen Meadows Residents Forum - http://www.landenmeadows.net

axa's Website

  • Smartys
  • Former PunBB Developer
  • Offline
  • Registered: 2004-04-30
  • Posts: 7,844

Re: Am I headed for a fall ?

No, upgrade ASAP.

3 Reply by axa

  • axa
  • Member
  • Offline
  • From: Charlotte, NC
  • Registered: 2007-02-18
  • Posts: 63

Re: Am I headed for a fall ?

Oh hell, I feared you might say that.
HDIFF here we come....

Landen Meadows Residents Forum - http://www.landenmeadows.net

axa's Website

4 Reply by axa

  • axa
  • Member
  • Offline
  • From: Charlotte, NC
  • Registered: 2007-02-18
  • Posts: 63

Re: Am I headed for a fall ?

Well, thank God for backups.
After upgrading to 1.2.17, all well except for the following 2 issues..

Clicking on the "logout" link redirects to the forums.php, and does not log out sad (Any suggestions ?)
IE6 meses up the index page a little bit by inserting a good few blank lines after the title of the 2nd post appearing on my portal - suppose I can live with that.

Landen Meadows Residents Forum - http://www.landenmeadows.net

axa's Website

  • Smartys
  • Former PunBB Developer
  • Offline
  • Registered: 2004-04-30
  • Posts: 7,844

Re: Am I headed for a fall ?

Clicking on the "logout" link redirects to the forums.php, and does not log out sad (Any suggestions ?)

That means you didn't apply the hdiff correctly or you added more logout links somewhere. 1.2.17 introduced a new parameter, the CSRF token, that you need to add to the link. The hdiff adds it in the generate_navlinks function.

6 Reply by axa (edited by axa 2008-04-15 02:47)

  • axa
  • Member
  • Offline
  • From: Charlotte, NC
  • Registered: 2007-02-18
  • Posts: 63

Re: Am I headed for a fall ?

Smartys wrote:

Clicking on the "logout" link redirects to the forums.php, and does not log out sad (Any suggestions ?)

That means you didn't apply the hdiff correctly or you added more logout links somewhere. 1.2.17 introduced a new parameter, the CSRF token, that you need to add to the link. The hdiff adds it in the generate_navlinks function.

I know you don't have much info - but would you have an idea which of the updated files in the hdiff would contain the error ? the link on my logout points to 

http://www.landenmeadows.net/login.php?action=out&id=2
Landen Meadows Residents Forum - http://www.landenmeadows.net

axa's Website

  • Smartys
  • Former PunBB Developer
  • Offline
  • Registered: 2004-04-30
  • Posts: 7,844

Re: Am I headed for a fall ?

include/functions.php, the generate_navlinks function wink

8 Reply by axa

  • axa
  • Member
  • Offline
  • From: Charlotte, NC
  • Registered: 2007-02-18
  • Posts: 63

Re: Am I headed for a fall ?

Oddly, functions.php was the only one I struggled with when reading the hdiff.
Obviouly my functions.php has been highly modified while applying mods - the lines called to be corrected by the hdiff do not even show up in my functions.php, namely

852:     // Prefix with o_base_url (unless it's there already)    
853:     if (strpos($destination_url, $pun_config['o_base_url']) !== 0)    
854:         $destination_url = $pun_config['o_base_url'].'/'.$destination_url;    
855:
856:     // Do a little spring cleaning
Landen Meadows Residents Forum - http://www.landenmeadows.net

axa's Website

9 Reply by axa

  • axa
  • Member
  • Offline
  • From: Charlotte, NC
  • Registered: 2007-02-18
  • Posts: 63

Re: Am I headed for a fall ?

Well, for better or for worse it seems to be fixed now.
I grabbed the functions.php from the zipped, "changed files" download. Since I have the punportal mod installed, I inserted the word "portal" in front of all the "nav..." lines such as navlogout, navprofile etc.
I am sure someone could fine an unsavory term for the way I fixed, or, erm, "rigged" this, but it works for the mean time.

Landen Meadows Residents Forum - http://www.landenmeadows.net

axa's Website