Topic: Private threads

Hi,

In my one of the forums i want so that one user should NOT be able to see other user's thread at all. User should see only his threads. How do i achieve this ?

Thanks.

2

Re: Private threads

With difficulty. It requires a notable amount of alteration to do it properly.

Re: Private threads

Hi,

No probs. please tell me how to do it.

Thanks.

4

Re: Private threads

If you know how to code, you can most likely figure it yourself. If you cannot, then I wouldn't advise attempting it.

Re: Private threads

Hi,

I tried, i was checking if the username was same as the thread starter's name then it would show else it won't. But this is not enough as I am not familiar with punbb code etc. If i use the above criteria then only poster will see the post, mods and admins won't be able to see the code. So I need mods and admins to see all the posts.

Please help.

Thanks.

6

Re: Private threads

if ($pun_user['g_id'] < PUN_GUEST || [add the poster == topic poster check here])
{
    [whatever code here]
}

That code above will allow mods and admins to view/post too. Just replace your poster == topic poster check with that code above.

However, remember that you also have to account for post.php, search.php and possibly some other scripts to make the topics truly invisible.

Re: Private threads

What is code for ?

Admin and Mods ? PUN_ADMIN and PUN_MOD ?

Thanks.

8

Re: Private threads

kikloo wrote:

What is code for ?

Admin and Mods ? PUN_ADMIN and PUN_MOD ?

Thanks.

Did you actually read my post above, i.e:

That code above will allow mods and admins to view/post too.

Re: Private threads

Hi,

Yes sorry. How to get the username of the logged in user ? The logged in user's username is required so that I can compare it with the poster's username.

// check if this is private forum
if ($_GET["id"]  == "7")
{
        echo "pass: 1";
        if ($cur_topic['poster'] == "kikloo") // here i need to put logged in user's username
        {
                // do stuff
        }
}

Thanks.

10 (edited by MattF 2008-06-15 19:34)

Re: Private threads

$pun_user['username']

Also, change this:

if ($_GET["id"]  == "7")

to this:

if (intval($_GET["id"])  == "7")

You're not doing anything notable with it, but it's good form to be secure in methodology throughout.

11 (edited by kikloo 2008-06-15 19:54)

Re: Private threads

Hi,

Excellent works like a chram. Here's the code in case anyone needs it. You have to add some code in viewforum.php:

Find - Starts on line: 138 and ends at line: 142:

// If there are topics in this forum.
if ($db->num_rows($result))
{
        while ($cur_topic = $db->fetch_assoc($result))
        {

After above, Add:

                if (intval($_GET["id"])  == "5")
                {
                        if ($pun_user['g_id'] < PUN_GUEST || $cur_topic['poster'] == $pun_user['username'])
                        {

Find:

                                                        <td class="tcr"><?php echo $last_post ?></td>
                                                </tr>
<?php

After Add:

          }
}

Hope this works.

Thanks.

12

Re: Private threads

Hi,

But as Mattf said, this requires more customization specially in post.php and search.php to make it turly invisible. I am working on it.

Thanks.

13

Re: Private threads

Your code above has a typo. This:

if (intval($_GET["id"]  == "5"))

should be:


if (intval($_GET["id"])  == "5")

Btw, you also need to add viewtopic.php to your list of files to modify.

14 (edited by MattF 2008-06-15 19:57)

Re: Private threads

Also, you can condense this:

                if (intval($_GET["id"]) == "5")
                {
                        if ($pun_user['g_id'] < PUN_GUEST || $cur_topic['poster'] == $pun_user['username'])
                        {

into a single if statement:

                        if (intval($_GET["id"]) == "5" && ($pun_user['g_id'] < PUN_GUEST || $cur_topic['poster'] == $pun_user['username']))
                        {

15 (edited by kikloo 2008-06-15 19:58)

Re: Private threads

Hi,

This is fixed. I am using the new condensed version!

Thanks.

16

Re: Private threads

HI,

okay I found a prob. the threads are not showing up in any forum if a guest is online. How to fix ?

Thanks.

17

Re: Private threads

What else have you changed?

18

Re: Private threads

Hi,

Nothing I just used your last code which was condensed.

Thanks.

19

Re: Private threads

That code alone could not create the symptoms you describe. Post your viewforum.php.

20 (edited by kikloo 2008-06-17 13:56)

Re: Private threads

Hi,

Here it is:

<?php
/***********************************************************************

  Copyright (C) 2002-2005  Rickard Andersson (rickard@punbb.org)

  This file is part of PunBB.

  PunBB is free software; you can redistribute it and/or modify it
  under the terms of the GNU General Public License as published
  by the Free Software Foundation; either version 2 of the License,
  or (at your option) any later version.

  PunBB is distributed in the hope that it will be useful, but
  WITHOUT ANY WARRANTY; without even the implied warranty of
  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  GNU General Public License for more details.

  You should have received a copy of the GNU General Public License
  along with this program; if not, write to the Free Software
  Foundation, Inc., 59 Temple Place, Suite 330, Boston,
  MA  02111-1307  USA

************************************************************************/


define('PUN_ROOT', './');
require PUN_ROOT.'include/common.php';


if ($pun_user['g_read_board'] == '0')
        message($lang_common['No view']);


$id = isset($_GET['id']) ? intval($_GET['id']) : 0;
if ($id < 1)
        message($lang_common['Bad request']);

// Load the viewforum.php language file
require PUN_ROOT.'lang/'.$pun_user['language'].'/forum.php';

// Fetch some info about the forum
$result = $db->query('SELECT f.forum_name, f.redirect_url, f.moderators, f.num_topics, f.sort_by, fp.post_topics FROM '.$db->prefix.'forums AS f LEFT JOIN '.$db->prefix.'forum_perms AS fp ON (fp.forum_id=f.id AND fp.group_id='.$pun_user['g_id'].') WHERE (fp.read_forum IS NULL OR fp.read_forum=1) AND f.id='.$id) or error('Unable to fetch forum info', __FILE__, __LINE__, $db->error());
if (!$db->num_rows($result))
        message($lang_common['Bad request']);

$cur_forum = $db->fetch_assoc($result);

// Is this a redirect forum? In that case, redirect!
if ($cur_forum['redirect_url'] != '')
{
        header('Location: '.$cur_forum['redirect_url']);
        exit;
}

// Sort out who the moderators are and if we are currently a moderator (or an admin)
$mods_array = array();
if ($cur_forum['moderators'] != '')
        $mods_array = unserialize($cur_forum['moderators']);

$is_admmod = ($pun_user['g_id'] == PUN_ADMIN || ($pun_user['g_id'] == PUN_MOD && array_key_exists($pun_user['username'], $mods_array))) ? true : false;

// Can we or can we not post new topics?
if (($cur_forum['post_topics'] == '' && $pun_user['g_post_topics'] == '1') || $cur_forum['post_topics'] == '1' || $is_admmod)
        $post_link = "\t\t".'<p class="postlink conr"><a href="post.php?fid='.$id.'">'.$lang_forum['Post topic'].'</a></p>'."\n";
else
        $post_link = '';


// Determine the topic offset (based on $_GET['p'])
$num_pages = ceil($cur_forum['num_topics'] / $pun_user['disp_topics']);

$p = (!isset($_GET['p']) || $_GET['p'] <= 1 || $_GET['p'] > $num_pages) ? 1 : $_GET['p'];
$start_from = $pun_user['disp_topics'] * ($p - 1);

// Generate paging links
$paging_links = $lang_common['Pages'].': '.paginate($num_pages, $p, 'viewforum.php?id='.$id);


$page_title = pun_htmlspecialchars($pun_config['o_board_title'].' / '.$cur_forum['forum_name']);
define('PUN_ALLOW_INDEX', 1);
require PUN_ROOT.'header.php';

?>
<div class="linkst">
        <div class="inbox">
                <p class="pagelink conl"><?php echo $paging_links ?></p>
<?php echo $post_link ?>
                <ul><li><a href="index.php"><?php echo $lang_common['Index'] ?></a>&nbsp;</li><li>&raquo;&nbsp;<?php echo pun_htmlspecialchars($cur_forum['forum_name']) ?></li></ul>
                <div class="clearer"></div>
        </div>
</div>

<div id="vf" class="blocktable">
        <h2><span><?php echo pun_htmlspecialchars($cur_forum['forum_name']) ?></span></h2>
        <div class="box">
                <div class="inbox">
                        <table cellspacing="0">
                        <thead>
                                <tr>
                                        <th class="tcl" scope="col"><?php echo $lang_common['Topic'] ?></th>
                                        <th class="tc2" scope="col"><?php echo $lang_common['Replies'] ?></th>
                                        <th class="tc3" scope="col"><?php echo $lang_forum['Views'] ?></th>
                                        <th class="tcr" scope="col"><?php echo $lang_common['Last post'] ?></th>
                                </tr>
                        </thead>
                        <tbody>
<?php

// Fetch list of topics to display on this page
if ($pun_user['is_guest'] || $pun_config['o_show_dot'] == '0')
{
        // Without "the dot"
        $sql = 'SELECT id, poster, subject, posted, last_post, last_post_id, last_poster, num_views, num_replies, closed, sticky, moved_to FROM '.$db->prefix.'topics WHERE forum_id='.$id.' ORDER BY sticky DESC, '.(($cur_forum['sort_by'] == '1') ? 'posted' : 'last_post').' DESC LIMIT '.$start_from.', '.$pun_user['disp_topics'];
}
else
{
        // With "the dot"
        switch ($db_type)
        {
                case 'mysql':
                case 'mysqli':
                        $sql = 'SELECT p.poster_id AS has_posted, t.id, t.subject, t.poster, t.posted, t.last_post, t.last_post_id, t.last_poster, t.num_views, t.num_replies, t.closed, t.sticky, t.moved_to FROM '.$db->prefix.'topics AS t LEFT JOIN '.$db->prefix.'posts AS p ON t.id=p.topic_id AND p.poster_id='.$pun_user['id'].' WHERE t.forum_id='.$id.' GROUP BY t.id ORDER BY sticky DESC, '.(($cur_forum['sort_by'] == '1') ? 'posted' : 'last_post').' DESC LIMIT '.$start_from.', '.$pun_user['disp_topics'];
                        break;

                case 'sqlite':
                        $sql = 'SELECT p.poster_id AS has_posted, t.id, t.subject, t.poster, t.posted, t.last_post, t.last_post_id, t.last_poster, t.num_views, t.num_replies, t.closed, t.sticky, t.moved_to FROM '.$db->prefix.'topics AS t LEFT JOIN '.$db->prefix.'posts AS p ON t.id=p.topic_id AND p.poster_id='.$pun_user['id'].' WHERE t.id IN(SELECT id FROM '.$db->prefix.'topics WHERE forum_id='.$id.' ORDER BY sticky DESC, '.(($cur_forum['sort_by'] == '1') ? 'posted' : 'last_post').' DESC LIMIT '.$start_from.', '.$pun_user['disp_topics'].') GROUP BY t.id ORDER BY t.sticky DESC, t.last_post DESC';
                        break;

                default:
                        $sql = 'SELECT p.poster_id AS has_posted, t.id, t.subject, t.poster, t.posted, t.last_post, t.last_post_id, t.last_poster, t.num_views, t.num_replies, t.closed, t.sticky, t.moved_to FROM '.$db->prefix.'topics AS t LEFT JOIN '.$db->prefix.'posts AS p ON t.id=p.topic_id AND p.poster_id='.$pun_user['id'].' WHERE t.forum_id='.$id.' GROUP BY t.id, t.subject, t.poster, t.posted, t.last_post, t.last_post_id, t.last_poster, t.num_views, t.num_replies, t.closed, t.sticky, t.moved_to, p.poster_id ORDER BY sticky DESC, '.(($cur_forum['sort_by'] == '1') ? 'posted' : 'last_post').' DESC LIMIT '.$start_from.', '.$pun_user['disp_topics'];
                        break;

        }
}

$result = $db->query($sql) or error('Unable to fetch topic list', __FILE__, __LINE__, $db->error());

// If there are topics in this forum.
if ($db->num_rows($result))
{
        while ($cur_topic = $db->fetch_assoc($result))
        {
                if (intval($_GET["id"])  == "5" && ($pun_user['g_id'] < PUN_GUEST || $cur_topic['poster'] == $pun_user['username']))
                {
                        $icon_text = $lang_common['Normal icon'];
                        $item_status = '';
                        $icon_type = 'icon';

                        if ($cur_topic['moved_to'] == null)
                                $last_post = '<a href="viewtopic.php?pid='.$cur_topic['last_post_id'].'#p'.$cur_topic['last_post_id'].'">'.format_time($cur_topic['last_post']).'</a> <span class="byuser">'.$lang_common['by'].'&nbsp;'.pun_htmlspecialchars($cur_topic['last_poster']).'</span>';
                        else
                                $last_post = '&nbsp;';

                        if ($pun_config['o_censoring'] == '1')
                                $cur_topic['subject'] = censor_words($cur_topic['subject']);

                        if ($cur_topic['moved_to'] != 0)
                                $subject = $lang_forum['Moved'].': <a href="viewtopic.php?id='.$cur_topic['moved_to'].'">'.pun_htmlspecialchars($cur_topic['subject']).'</a> <span class="byuser">'.$lang_common['by'].'&nbsp;'.pun_htmlspecialchars($cur_topic['poster']).'</span>';
                        else if ($cur_topic['closed'] == '0')
                                $subject = '<a href="viewtopic.php?id='.$cur_topic['id'].'">'.pun_htmlspecialchars($cur_topic['subject']).'</a> <span class="byuser">'.$lang_common['by'].'&nbsp;'.pun_htmlspecialchars($cur_topic['poster']).'</span>';
                        else
                        {
                                $subject = '<a href="viewtopic.php?id='.$cur_topic['id'].'">'.pun_htmlspecialchars($cur_topic['subject']).'</a> <span class="byuser">'.$lang_common['by'].'&nbsp;'.pun_htmlspecialchars($cur_topic['poster']).'</span>';
                                $icon_text = $lang_common['Closed icon'];
                                $item_status = 'iclosed';
                        }

                        if (!$pun_user['is_guest'] && $cur_topic['last_post'] > $pun_user['last_visit'] && $cur_topic['moved_to'] == null)
                        {
                                $icon_text .= ' '.$lang_common['New icon'];
                                $item_status .= ' inew';
                                $icon_type = 'icon inew';
                                $subject = '<strong>'.$subject.'</strong>';
                                $subject_new_posts = '<span class="newtext">[&nbsp;<a href="viewtopic.php?id='.$cur_topic['id'].'&amp;action=new" title="'.$lang_common['New posts info'].'">'.$lang_common['New posts'].'</a>&nbsp;]</span>';
                        }
                        else
                                $subject_new_posts = null;

                        // Should we display the dot or not? :)
                        if (!$pun_user['is_guest'] && $pun_config['o_show_dot'] == '1')
                        {
                                if ($cur_topic['has_posted'] == $pun_user['id'])
                                        $subject = '<strong>&middot;</strong>&nbsp;'.$subject;
                                else
                                        $subject = '&nbsp;&nbsp;'.$subject;
                        }

                        if ($cur_topic['sticky'] == '1')
                        {
                                $subject = '<span class="stickytext">'.$lang_forum['Sticky'].': </span>'.$subject;
                                $item_status .= ' isticky';
                                $icon_text .= ' '.$lang_forum['Sticky'];
                        }

                        $num_pages_topic = ceil(($cur_topic['num_replies'] + 1) / $pun_user['disp_posts']);

                        if ($num_pages_topic > 1)
                                $subject_multipage = '[ '.paginate($num_pages_topic, -1, 'viewtopic.php?id='.$cur_topic['id']).' ]';
                        else
                                $subject_multipage = null;

                        // Should we show the "New posts" and/or the multipage links?
                        if (!empty($subject_new_posts) || !empty($subject_multipage))
                        {
                                $subject .= '&nbsp; '.(!empty($subject_new_posts) ? $subject_new_posts : '');
                                $subject .= !empty($subject_multipage) ? ' '.$subject_multipage : '';
                        }

?>
                                        <tr><?php if ($item_status != '') echo ' class="'.trim($item_status).'"'; ?>>
                                                <td class="tcl">
                                                        <div class="intd">
                                                                <div class="<?php echo $icon_type ?>"><div class="nosize"><?php echo trim($icon_text) ?></div></div>
                                                                <div class="tclcon">
                                                                        <?php echo $subject."\n" ?>
                                                                </div>
                                                        </div>
                                                </td>
                                                <td class="tc2"><?php echo ($cur_topic['moved_to'] == null) ? $cur_topic['num_replies'] : '&nbsp;' ?></td>
                                                <td class="tc3"><?php echo ($cur_topic['moved_to'] == null) ? $cur_topic['num_views'] : '&nbsp;' ?></td>
                                                <td class="tcr"><?php echo $last_post ?></td>
                                        </tr>
<?php
                }
        }
}
else
{

?>
                                <tr>
                                        <td class="tcl" colspan="4"><?php echo $lang_forum['Empty forum'] ?></td>
                                </tr>
<?php

}

?>
                        </tbody>
                        </table>
                </div>
        </div>
</div>

<div class="linksb">
        <div class="inbox">
                <p class="pagelink conl"><?php echo $paging_links ?></p>
<?php echo $post_link ?>
                <ul><li><a href="index.php"><?php echo $lang_common['Index'] ?></a>&nbsp;</li><li>&raquo;&nbsp;<?php echo pun_htmlspecialchars($cur_forum['forum_name']) ?></li></ul>
                <div class="clearer"></div>
        </div>
</div>
<?php

$forum_id = $id;
$footer_style = 'viewforum';
require PUN_ROOT.'footer.php';

Thanks.

21 (edited by MattF 2008-06-16 20:10)

Re: Private threads

The whole file, not just an excerpt of it.

22

Re: Private threads

MattF wrote:

The whole file, not just an excerpt of it.

Hi,

Done.

Thanks.

23 (edited by MattF 2008-06-17 18:18)

Re: Private threads

Change this:

if (intval($_GET["id"])  == "5" && ($pun_user['g_id'] < PUN_GUEST || $cur_topic['poster'] == $pun_user['username']))

to this:

if ($id != "5" || ($id == "5" && ($pun_user['g_id'] < PUN_GUEST || $cur_topic['poster'] == $pun_user['username'])))

That should do the trick. I'd had one of my slightly dense moments with that first code I posted. big_smile