1 (edited by Anatoly 2008-10-27 13:12)

Topic: Markup update

Hey!

I've just committed new markup into main 1.3 development brunch.

You are welcome to try it out.
Please, post all the markup-related issues to this topic.

EDIT: Pre-markup-update extensions possibly will not work and need to be updated! Official extensions will be updated after 1.3RC2 release.

EDIT2: You may download the latest revision by clicking the Zip Archive link in the bottom of the /punbb/branches/punbb-1.3-dev/upload page in the Trac source browser.


PS: 1.3RC2 is to be released after 2-3 days of new markup testing.

Carpe diem

Re: Markup update

Wait... I don't get it. You said:

Merged new markup (based on markup by Paul Sullivan) into main PunBB 1.3 development branch.
Some functions added to functions.php. Updated install.php and db_update.php. URL schemes updated.
Lots of hooks added.
Mostly imported from FluxBB.

So, PunBB and FluxBB are the same, technically?

Re: Markup update

Garciat wrote:

So, PunBB and FluxBB are the same, technically?

Not exactly the same, but nearly the same. See the project history for additional details.

Re: Markup update

Garciat wrote:

So, PunBB and FluxBB are the same, technically?

Yes, they are for now.

When FluxBB has forked from PunBB, we had no our own devteam. And we did like the work and vision of former PunBB developers. That is why we aimed to have 1.3 release based on and compatible (at the level of extensions) with FluxBB then.
But we do not want to wait for FluxBB for the unpredictable period of time anymore.
Now our devs have learned the PunBB core deeply and we've formed our own vision of the further PunBB development.
We want to finish 1.3 and start new PunBB branch implementing the good practices and ideas we have.

Carpe diem

5 (edited by User33 2008-10-26 19:16)

Re: Markup update

On the final steps of the installation, the CSS files relative paths are wrong.

<link rel="stylesheet" type="text/css" href="style/Oxygen/Oxygen.css" />
<link rel="stylesheet" type="text/css" href="style/Oxygen/Oxygen_forms.css" />
<link rel="stylesheet" type="text/css" href="style/Oxygen/Oxygen_cs.css" />
<!--[if lte IE 7]><link rel="stylesheet" type="text/css" href="style/Oxygen/Oxygen_ie.css" /><![endif]-->

"../" Should be added to each one of them.

Edit: Actually, should be replaced by: [Lines 1777-1780 on 'admin/install.php']

<link rel="stylesheet" type="text/css" href="<?php echo FORUM_ROOT ?>style/Oxygen/Oxygen.css" />
<link rel="stylesheet" type="text/css" href="<?php echo FORUM_ROOT ?>style/Oxygen/Oxygen_cs.css" />
<!--[if lte IE 6]><link rel="stylesheet" type="text/css" href="<?php echo FORUM_ROOT ?>style/Oxygen/Oxygen_ie6.css" /><![endif]-->
<!--[if IE 7]><link rel="stylesheet" type="text/css" href="<?php echo FORUM_ROOT ?>style/Oxygen/Oxygen_ie7.css" /><![endif]-->

Edit: 'lang/English/admin_common.php' and 'lang/English/admin_ban.php' are missing?

Edit:

Notice: Use of undefined constant FORUM_MAX_POSTSIZE - assumed 'FORUM_MAX_POSTSIZE' in Z:\repository\punbb_rc2\lang\English\misc.php on line 14

when viewing 'moderate.php?get_host=127.0.0.1'.

Re: Markup update

Thanks for reporting. Paths on install page were fixed in [691].

Re: Markup update

Garciat wrote:

Edit:

Notice: Use of undefined constant FORUM_MAX_POSTSIZE - assumed 'FORUM_MAX_POSTSIZE' in Z:\repository\punbb_rc2\lang\English\misc.php on line 14

when viewing 'moderate.php?get_host=127.0.0.1'.

Same error but when i want post.

Notice: Use of undefined constant FORUM_MAX_POSTSIZE - assumed 'FORUM_MAX_POSTSIZE' in /home/www/site1/www/test/forum/lang/English/post.php on line 10

Re: Markup update

Yop, it's me again.

I found this notice :

Notice: Undefined index: Check for versions in /home/www/site1/www/test/forum/admin/settings.php on line 1011

Go to Administration -> Settings -> Features see at the end (Check for versions).

Re: Markup update

Is it a fresh install or a migration from another version?

10 (edited by admin-gzw 2008-10-27 15:17)

Re: Markup update

Slavok wrote:

Is it a fresh install or a migration from another version?

Migration from 1.2.20.

EDIT

It disappear with the last SVN. smile

Re: Markup update

Lol, i think the day punbb 1.3 i released with the day Ubuntu 8.10 is released tongue

PunBB, the FluxBB of tomorrow - today!

12 (edited by User33 2008-10-28 21:00)

Re: Markup update

When the installation is done, and I visit the forum's index, I get:

Your PunBB database is out-of-date and must be upgraded in order to continue. Please run db_update.php in order to complete the upgrade process.

Then, when I run 'db_update.php', I get:

Your database is already as up-to-date as this script can make it.

I used: SQLite, "localhost", and DB name "test". Using latest dev version.

Re: Markup update

Garciat wrote:

...Then, when I run 'db_update.php', I get:

Your database is already as up-to-date as this script can make it.

I used: SQLite, "localhost", and DB name "test". Using latest dev version.

Revision number please (it must be included to the archive file name, if you've downloaded zip from SVN).
Try the latter "latest version" :-)

Carpe diem

14 (edited by User33 2008-10-29 12:18)

Re: Markup update

I'm going to try rev719 right now and see if I get the same error.

Edit: I get this alert on 'Administration » Start » Information':

Database version mismatch Your PunBB database is meant to be used in conjunction with a newer version of the PunBB code. This mismatch can lead to your forum not working properly. It is suggested that you upgrade your forum to the newest version of PunBB.

The forum works ok, though.

15

Re: Markup update

HTML:

<li class="info-lastpost">
    <span class="label">Last post</span>
    <strong>Today 12:14:15</strong>
    <cite>by Garciat</cite>
</li>

CSS:

.brd .main-content .main-item li.info-lastpost cite,
.brd .main-content .main-item li.info-lastpost span {
     display: block;
     padding: 0 1em;
     font-style: normal;
     font-weight: normal;
     }

<cite>'s 'display: block' moves "by Garciat" to a new line. This is OK for the forum index because the forum description is also on a new line. However, on the topic view, this just makes the row higher for no reason.

Re: Markup update

Thanks for testing.

Garciat wrote:

<cite>'s 'display: block' moves "by Garciat" to a new line. This is OK for the forum index because the forum description is also on a new line. However, on the topic view, this just makes the row higher for no reason.

Try to use the very long username - propose alternative solutions )

Carpe diem

17

Re: Markup update

What's the max length for the username?

18

Re: Markup update

It can't be more than 25 and less than 3

Re: Markup update

Looks like it is ready: PunBB 1.3 RC2 is to be published tomorrow morning.

Carpe diem

20 (edited by User33 2008-10-30 22:33)

Re: Markup update

[REV 767] File: /admin/index.php

W3C Markup Validator wrote:

Error  Line 126, Column 7: end tag for "ul" omitted, but OMITTAG NO was specified.

Replace lines 216-219 in '/admin/index.php':

                    </ul>
                </div>
            </div>
<?php endif; endif; ($hook = get_hook('ain_items_end')) ? eval($hook) : null; ?>        </div>

with:

<?php endif; ?>                    </ul>
                </div>
            </div>
<?php endif; ($hook = get_hook('ain_items_end')) ? eval($hook) : null; ?>        </div>

Re: Markup update

Garciat wrote:

[REV 767] File: /admin/index.php

W3C Markup Validator wrote:

Error  Line 126, Column 7: end tag for "ul" omitted, but OMITTAG NO was specified.

Fixed.
Thanks.

Carpe diem