1 Topic by whatrevolution (edited by whatrevolution 2008-12-22 14:58)

  • From: Paducah, KY
  • Registered: 2008-02-21
  • Posts: 60

Topic: [Release] Quick Smilies (dynamic list & full-size preview)

Version 0.1.4: Download

The smilies list on post forms is now generated from the /img/smilies/ directory file list.

http://www.honestlyillustrated.com/off-site/screenshots/honest_quick_smilies_0.1.2.png

All images in that directory are now available in posts.  The ASCII smiles ( smile big_smile ) are unchanged, and all named smiley codes ( cool lol ) are now the image file name, without the filetype extension:  So, filename.png now has BBCode :filename: and otherfile.gif has :otherfile: and so on.

width="15" height="15" is found in PunBB 1.3.2 <img> tags, in /include/parser.php, function do_smilies($text), and can be modified to read:

/include/parser.php Line 767:

global $forum_config, $base_url, $smilies, $smilies_h, $smilies_w;

/include/parser.php Line 774:

$text = preg_replace("#(?<=[>\s])".preg_quote($smiley_text, '#')."(?=\W)#m", '<img src="'.$base_url.'/img/smilies/'.$smiley_img.'" width="'.$smilies_w[$smiley_img].'" height="'.$smilies_h[$smiley_img].'" alt="'.substr($smiley_img, 0, strrpos($smiley_img, '.')).'" />', $text);

Making the above changes to /include/parser.php will allow smilies <img> tags to have the real image width & height inside of posts, but still use 15x15 in the BBCode toolbar, as in the provided screenshot.

I used GD functions to measure the images, so check this page:
forum.domain/admin/index.php?action=phpinfo

For this info:

PHPInfo wrote:

GD Support     enabled
GD Version     2.0 or higher
[...]
GIF Read Support     enabled
GIF Create Support     enabled
JPG Support     enabled
PNG Support     enabled
WBMP Support     enabled

Use the same GD version I have, and only upload images saved in file formats you have GD support enabled for.

Make the following modification in /extensions/pun_bbcode/bar.php:
Edit: Moved to it's own thread.

The combined result will be:
http://www.honestlyillustrated.com/off-site/screenshots/honest_quick_smilies_0.1.4.png

whatrevolution's Website

  • Registered: 2008-11-16
  • Posts: 528

Re: [Release] Quick Smilies (dynamic list & full-size preview)

Excellent work.
For now I'm going to resist installing this.
I've a feeling my users would love it but I am trying to keep thinks as text-based as possible. Looks good though!!

  • From: Paducah, KY
  • Registered: 2008-02-21
  • Posts: 60

Re: [Release] Quick Smilies (dynamic list & full-size preview)

Thanks, esupergood.  I'm going to let this rest for now, and am considering merging it into the pun_bbcode package.

whatrevolution's Website

  • KeyDog
  • KeyDog
  • Global Moderator
  • Offline
  • Registered: 2008-12-12
  • Posts: 1,693

Re: [Release] Quick Smilies (dynamic list & full-size preview)

definitely very good.
animated gifs also work?
example?
thx

  • From: Paducah, KY
  • Registered: 2008-02-21
  • Posts: 60

Re: [Release] Quick Smilies (dynamic list & full-size preview)

KeyDog wrote:

animated gifs also work?

A few of the images in the screenshots are animated, it's just that the screenshot itself is not animated.  They work just as well as any other image.

Thanks for your approval.  I didn't mean to compete with your extension you posted yesterday, I already had it nearly finished by that time.

whatrevolution's Website

  • KeyDog
  • KeyDog
  • Global Moderator
  • Offline
  • Registered: 2008-12-12
  • Posts: 1,693

Re: [Release] Quick Smilies (dynamic list & full-size preview)

fine by me. not doing it for credit or monetary sake smile and yours is better in that it chooses all images from folder ; that was annoying me with mine... could i use your code that says gett all from folder if I change created by to include your name?

7 Reply by whatrevolution (edited by whatrevolution 2008-12-19 10:47)

  • From: Paducah, KY
  • Registered: 2008-02-21
  • Posts: 60

Re: [Release] Quick Smilies (dynamic list & full-size preview)

KeyDog wrote:

could i use your code

Yes, it's GPL, as stated in the extension data. wink

BTW, you can add more ASCII smiles (typed as big_smile =O $_$ @_@ etc) by placing them in the array like you did before.

whatrevolution's Website

8 Reply by KeyDog (edited by KeyDog 2008-12-19 13:02)

  • KeyDog
  • KeyDog
  • Global Moderator
  • Offline
  • Registered: 2008-12-12
  • Posts: 1,693

Re: [Release] Quick Smilies (dynamic list & full-size preview)

Just followed those instructions on a test forum I have and got the following screenshots...
My test forum is on 1.3.2
maybe you could install a test forum standard installation and then implement this "extension" (lot of code changing big_smile ) - if it works; add the changed files to the zip or rar whatever.

what is working great is that it gets the :myname: i ve added to folder img and it even adds it to help - def love that (that part of code should be standard in next release I think)

here what i get after following your steps:

http://www.dumpt.com/img/files/59dq3me0ig6zxd3dhdsx_thumb.gif

see Firefox screenshot here

http://www.dumpt.com/img/files/9jgvha7w14p4e36hpg2j_thumb.gif

see google chrome screenshot here

  • From: Paducah, KY
  • Registered: 2008-02-21
  • Posts: 60

Re: [Release] Quick Smilies (dynamic list & full-size preview)

KeyDog wrote:

Just followed those instructions on a test forum I have and got the following screenshots...

I'm unable to see your screenshots on dumpt.com; I tried Firefox 3 and K-meleon.

KeyDog wrote:

maybe you could install a test forum standard installation and then implement this "extension" (lot of code changing  ) - if it works; add the changed files to the zip or rar whatever.

I don't want to leap into that with the holiday so near.  I'll do it after a few more extensions and mods.

KeyDog wrote:

what is working great is that it gets the :myname: i ve added to folder img and it even adds it to help - def love that (that part of code should be standard in next release I think)

Agreed.  Now it needs a cache.  I'm still considering options.

whatrevolution's Website

10 Reply by KeyDog (edited by KeyDog 2008-12-19 13:20)

  • KeyDog
  • KeyDog
  • Global Moderator
  • Offline
  • Registered: 2008-12-12
  • Posts: 1,693

Re: [Release] Quick Smilies (dynamic list & full-size preview)

http://rapidshare.com/files/174847985/screenshotie7.gif

the box is screwing it up my end
couldnt see it in firefox or chrome at all
this screenshot is a IE7 one

and when i hover over images it doesnt show them in that box.

can you maybe tell me again which line exactely you put it in ?

  • From: Paducah, KY
  • Registered: 2008-02-21
  • Posts: 60

Re: [Release] Quick Smilies (dynamic list & full-size preview)

KeyDog wrote:

the box is screwing it up my end [...]
and when i hover over images it doesnt show them in that box.

The above instructions are all the steps I did, but they are only notes, not a manual.  I'll package it more neatly later.

I just confirmed my copy works in: IE 6, Firefox 3, K-Meleon, Opera 9.

whatrevolution's Website

12 Reply by KeyDog (edited by KeyDog 2008-12-20 10:53)

  • KeyDog
  • KeyDog
  • Global Moderator
  • Offline
  • Registered: 2008-12-12
  • Posts: 1,693

Re: [Release] Quick Smilies (dynamic list & full-size preview)

fair enough smile good work anyway. thanks again.

PS: i dont thinks its browser issue... but of height .... of quick reply... but maybe a developer can look at it hopefully and tell us if somethings bug y  in 1.3.2 ....

13 Reply by whatrevolution (edited by whatrevolution 2008-12-19 14:59)

  • From: Paducah, KY
  • Registered: 2008-02-21
  • Posts: 60

Re: [Release] Quick Smilies (dynamic list & full-size preview)

I found the problem, and corrected opening post.

Move the function bbCodePreview() in /extensions/pun_bbcode/scripts.js to /extensions/pun_bbcode/bar.php, I forgot it had an inline bit of PHP for $base_url.

whatrevolution's Website

14 Reply by KeyDog (edited by KeyDog 2008-12-19 16:58)

  • KeyDog
  • KeyDog
  • Global Moderator
  • Offline
  • Registered: 2008-12-12
  • Posts: 1,693

Re: [Release] Quick Smilies (dynamic list & full-size preview)

its working now in IE7, but placing of the postentry is stil lthe same as in my previous sceenshot post. i.e its too far down. i see the smilies in original size now though big_smile way cool  smile

also
its not visible in FF and Chrome due to this issue maybe that fluxbb has aswell=?
http://fluxbb.org/forums/topic/2369/tex … port-form/

  • From: Paducah, KY
  • Registered: 2008-02-21
  • Posts: 60

Re: [Release] Quick Smilies (dynamic list & full-size preview)

Yes, that is caused by crappy CSS.  These things happen all the time in CSS... it seems simple, until you understand it. smile

I haven't encountered that one yet, though.  It looks like the form elements are floating, and the CSS designer didn't use a page element below it to force the blue container to full height.

It's not a problem with this extension, at least.

whatrevolution's Website

16 Reply by KeyDog (edited by KeyDog 2008-12-20 10:36)

  • KeyDog
  • KeyDog
  • Global Moderator
  • Offline
  • Registered: 2008-12-12
  • Posts: 1,693

Re: [Release] Quick Smilies (dynamic list & full-size preview)

well its a work in progress smile sure they'll fix it
but question: how strongly is your css modified then?
if you could tell me what you've modified in yours from original maybe i can get it full height
thx.

  • From: Paducah, KY
  • Registered: 2008-02-21
  • Posts: 60

Re: [Release] Quick Smilies (dynamic list & full-size preview)

I built mine from Oxygen_WS.  Most of my changes have been in StyleName_cs.css, and shouldn't have effected that form's container.

whatrevolution's Website

18 Reply by whatrevolution (edited by whatrevolution 2008-12-22 14:59)

  • From: Paducah, KY
  • Registered: 2008-02-21
  • Posts: 60

Re: [Release] Quick Smilies (dynamic list & full-size preview)

I separated the bar.php modification from this thread, to [Release] Smiley Browser (JavaScripted scrolling smilies list).

I also updated this extension to 0.1.4, in opening post.

whatrevolution's Website

19 Reply by Khalid-S (edited by Khalid-S 2009-03-04 21:00)

  • Registered: 2009-02-22
  • Posts: 23

Re: [Release] Quick Smilies (dynamic list & full-size preview)

Thanks whatrevolution

I have changed the line 774 but I still get small smilies in posts.

http://b3.s3.quickshareit.com/picture1d5737.png

Original smilie size

http://b6.s3.p.quickshareit.com/files/krkrrd5b4b.gif http://b5.s3.p.quickshareit.com/files/rollf9ca0.png

Last one is a .gif animated smilie. How can I fix this? Thanks.

  • Registered: 2009-02-22
  • Posts: 23

Re: [Release] Quick Smilies (dynamic list & full-size preview)

It worked after I disabled Rich Pedley's eSmiley extension. Thanks.