• YonasH
  • PunBB Extensions Dev.
  • Offline
  • From: Dublin, IE
  • Registered: 2007-02-10
  • Posts: 148

Topic: No close mark inside the topic

Hello

There is no "close" info in closed topics. Like here http://punbb.informer.com/forums/topic/ … rol-panel/
There is some object generated, but is hidden in css


My sugestion of solution:

viewtopic.php (line 194)

if ($forum_user['may_post'])
    $forum_page['page_post']['posting'] = '<p class="posting"><a class="newpost" href="'.forum_link($forum_url['new_reply'], $id).'"><span>'.$lang_topic['Post reply'].'</span></a></p>';
else if (!$forum_user['may_post'] && !$forum_user['is_guest'] && $cur_topic['closed'] != '1')
    $forum_page['page_post']['posting'] = '<p class="posting">'.$lang_topic['No permission'].'</p>';
if (!$forum_user['may_post'] && $forum_user['is_guest'])
    $forum_page['page_post']['posting'] = '<p class="posting">'.sprintf($lang_topic['Login to post'], '<a href="'.forum_link($forum_url['login']).'">'.$lang_common['login'].'</a>', '<a href="'.forum_link($forum_url['register']).'">'.$lang_common['register'].'</a>').'</p>';

it's very strange code. To many conditions, unnecessary double checks, two if constructions... roll
change to:

if ($forum_user['may_post'])
    $forum_page['page_post']['posting'] = '<p class="posting"><a class="newpost" href="'.forum_link($forum_url['new_reply'], $id).'"><span>'.$lang_topic['Post reply'].'</span></a></p>';
else if ($forum_user['is_guest'])
    $forum_page['page_post']['posting'] = '<p class="posting">'.sprintf($lang_topic['Login to post'], '<a href="'.forum_link($forum_url['login']).'">'.$lang_common['login'].'</a>', '<a href="'.forum_link($forum_url['register']).'">'.$lang_common['register'].'</a>').'</p>';
else if ($cur_topic['closed'] == '1')
    $forum_page['page_post']['posting'] = '<p class="posting">'.$lang_topic['Topic closed info'].'</p>';
else
    $forum_page['page_post']['posting'] = '<p class="posting">'.$lang_topic['No permission'].'</p>';

lang\English\topic.php (line 10)

after:
'Topic closed'             =>    '[ Closed ]',

add:
'Topic closed info'        =>    'This topic is closed',
YonasH's repository + Extensions Directory = PunBB Extensions Online Library (in progress....)

Away. I will be back soon.
  • Utchin
  • PunBB senior member
  • Offline
  • Registered: 2007-02-09
  • Posts: 760

Re: No close mark inside the topic

Cheers. Will fix soon.

Sorry. Unactive due to personal life.
  • From: Russia
  • Registered: 2008-07-22
  • Posts: 713

Re: No close mark inside the topic

Thanks, I have applied your solution.

I should like to draw the attention of creators of language packs to the recent changes in the file lang/English/topic.php. Please, make the necessary changes to your language packs.

PunBB team intentions, personal tasks.

Parpalak's Website