• bedroom
  • Extension Developer
  • Offline
  • Registered: 2005-12-01
  • Posts: 27

Topic: error_reporting setting in include/essentials.php

Lines 65-66 in include/essentials.php :

// Make sure PHP reports all errors except E_NOTICE. PunBB supports E_ALL, but a lot of scripts it may interact with, do not.
error_reporting(E_ALL);

It seems to me that either the comment is wrong, or the code should read

error_reporting(E_ALL & ~E_NOTICE);

Am I right ?

  • Slavok
  • PunBB Developer
  • Offline
  • From: Russia
  • Registered: 2008-06-11
  • Posts: 1,238

Re: error_reporting setting in include/essentials.php

Yes, you're right. Thanks for reporting, fixed.

Slavok's Website

  • Cereal
  • Senior Member
  • Offline
  • From: Belgium
  • Registered: 2006-06-05
  • Posts: 123

Re: error_reporting setting in include/essentials.php

hmm,

in my opinion all code should start whit an e_all, this will force devs and extension devs to write decent and correct php code.

~Cereal
I've finally learned what "upward compatible" means. It means we get to keep all our old mistakes.
The limits of language are the limits of one's world.

Cereal's Website

  • From: Russia
  • Registered: 2008-07-22
  • Posts: 713

Re: error_reporting setting in include/essentials.php

Maybe it's better to connect error_reporting with the FORUM_DEBUG constant. If FORUM_DEBUG is defined, all errors and notices should be displayed.

PunBB team intentions, personal tasks.

Parpalak's Website

  • From: Russia
  • Registered: 2008-07-22
  • Posts: 713

Re: error_reporting setting in include/essentials.php

Changed.

PunBB team intentions, personal tasks.

Parpalak's Website