Topic: relative url as forum_root ?
the first thing i learned on php that relative urls are bad
they never works as expect on diffrent options (include from other directories , running as cron , and can security risk if you dont handle included file checks)
here is 2 links hack that will make punbb much better
if (!defined('FORUM_ROOT')) define('FORUM_ROOT', './');
if (!defined('FORUM_ROOT')) define('FORUM_ROOT',dirname(__FILE__).DIRECTORY_SEPARATOR);
if (!defined('FORUM_ROOT')) exit('The constant FORUM_ROOT must be defined and point to a valid PunBB installation root directory.');
change to :
if (!defined('FORUM_ROOT')) define('FORUM_ROOT',dirname(dirname(__FILE__)).DIRECTORY_SEPARATOR);
this way , when i builld integration i dont need to care about forum_root define (and i saw some posts around that ppl got lost tring to figure out forum_root dir)
the point about __FILE__ is thats its allways return the currect working file .
few more points :
punbb allways uses '/' as DIRECTORY SEPARATOR this might couse some problems on some configuration of windows iis
the fix is very simple , use php language const : DIRECTORY_SEPARATOR
or if you want to make it simple , just put define('DS',DIRECTORY_SEPARATOR);
somewhere so we can all use it as
also i think its will be better to set few consts for development ( will help ext developers as well) for example
same for languages && other stuff that used alot at punbb
its not a really a bug , but its imporvment , for security and for code writing.
i hope i will get punbb developers comments as well.