PunBB 1.2 - What's to come (Page 12 of 13)

And yes, I can release the news plugin as well.

Todd wrote:

It's just clean!

"There are two ways of constructing a software design; one way is to make it so simple that there are obviously no deficiencies, and the other way is to make it so complicated that there are no obvious deficiencies. The first method is far more difficult." ~C. A. R. Hoare~

I downloaded it yesterday and being the sort of person I am documented the database schema.

the text is mighty small on my monitor - but I the 'View->TextSize' doesn't increase it...  Well - I can read it.  But this is an acessibility issue in that the size must be fixed instead of relative.  I suspect that's just down to the stylesheet.

Secondly I suspect there's a missing primary key on subscriptsion( user_id, topic_id)

thirdly I though a little renaming of the various 'id' columns might be in order so that (e.g.) subscriptions.topic_id joins to topics.topic_id instead of topics.id.  In my view this would make the database more self-documenting.

cats_five wrote:

Secondly I suspect there's a missing primary key on subscriptsion( user_id, topic_id)

Are you sure? From the installation script:

$sql = 'CREATE TABLE '.$db_prefix."subscriptions (
        user_id INT(10) UNSIGNED NOT NULL DEFAULT 0,
        topic_id INT(10) UNSIGNED NOT NULL DEFAULT 0,
        PRIMARY KEY (user_id, topic_id)
        ) TYPE=MyISAM;";

cats_five wrote:

thirdly I though a little renaming of the various 'id' columns might be in order so that (e.g.) subscriptions.topic_id joins to topics.topic_id instead of topics.id.  In my view this would make the database more self-documenting.

This really is a matter of taste. Personally, I make it a habit to not include the table name in primary keys such as id in topics. For me, a column named id is obviously the primary key identifier for that table.

From my 1.1.5 download:

    case 'mysql':
        $sql = 'CREATE TABLE '.$db_prefix."subscriptions (
            user_id INT(10) UNSIGNED NOT NULL DEFAULT '0',
            topic_id INT(10) UNSIGNED NOT NULL DEFAULT '0'
            ) TYPE=MyISAM;";
         break;
    $queries[] = 'CREATE INDEX '.$db_prefix.'subscriptions_user_id_idx ON '.$db_prefix.'subscriptions(user_id)';
    $queries[] = 'CREATE INDEX '.$db_prefix.'subscriptions_topic_id_idx ON '.$db_prefix.'subscriptions(topic_id)';

Is this something that's amended in V1.2?  Plus unless MySQL is different to other databases, there would be no need for the index on 'user_id' if there is one on 'user_id, topic_id'.  Also in a *large* database it is possible that a unique one on 'topic_id, user_id' would be preferable.  Have come across problems in databases with this kind of key if the distribution of data is very perverse.

cats_five wrote:

From my 1.1.5 download:

    case 'mysql':
        $sql = 'CREATE TABLE '.$db_prefix."subscriptions (
            user_id INT(10) UNSIGNED NOT NULL DEFAULT '0',
            topic_id INT(10) UNSIGNED NOT NULL DEFAULT '0'
            ) TYPE=MyISAM;";
         break;
    $queries[] = 'CREATE INDEX '.$db_prefix.'subscriptions_user_id_idx ON '.$db_prefix.'subscriptions(user_id)';
    $queries[] = 'CREATE INDEX '.$db_prefix.'subscriptions_topic_id_idx ON '.$db_prefix.'subscriptions(topic_id)';

Is this something that's amended in V1.2?  Plus unless MySQL is different to other databases, there would be no need for the index on 'user_id' if there is one on 'user_id, topic_id'.  Also in a *large* database it is possible that a unique one on 'topic_id, user_id' would be preferable.  Have come across problems in databases with this kind of key if the distribution of data is very perverse.

Well, you posted this in the PunBB 1.2 topic so I assumed you were talking about 1.2. The situation has been remedied in 1.2 where there's one index on both columns (the primary key) instead of one on each.