1 (edited by cici 2005-01-31 14:05)

Topic: Missing quotes in email.php?

I have found that when a board name contains whitespaces or even accented characters, some SMTP servers are rather unhappy. Adding double quotes fixes that. It might have been fixed already, but the fix is not present at the distribution (punbb-1.2.tar.bz2).

Diff for email.php follows:
--- email.php-orig      2004-12-31 16:40:34.000000000 +0100
+++ email.php   2005-01-31 14:41:41.000000000 +0100
@@ -65,18 +65,18 @@

        // Default sender/return address
        if (!$from)
-               $from = $pun_config['o_board_title'].' '.$lang_common['Mailer'].' <'.$pun_config['o_webmaster_email'].'>';
+               $from = '"'.$pun_config['o_board_title'].' '.$lang_common['Mailer'].'" <'.$pun_config['o_webmaster_email'].'>';

        // Make sure the from line doesn't contain a colon (the character, that is :D)
        $from = str_replace(':', ' ', $from);

        // Detect what linebreak we should use for the headers

Re: Missing quotes in email.php?

Good idea.

"Programming is like sex: one mistake and you have to support it for the rest of your life."