• Connorhd
  • Connorhd
  • Former PunBB Developer
  • Offline
  • From: Leeds, UK
  • Registered: 2004-06-13
  • Posts: 4,195

Topic: Open links in new windows

ok to end the debate i have been forced to release this mod, however i don't agree with it tongue

open parser.php
find line 273

    return '<a href="'.$full_url.'">'.$link.'</a>';

replace with

    return '<a href="'.$full_url.'" onclick="window.open(this.href); return false;">'.$link.'</a>';

find line 284

    $img_tag = '<a href="'.$url.'"><'.$lang_common['Image link'].'></a>';

replace with

    $img_tag = '<a href="'.$url.'" onclick="window.open(this.href); return false;"><'.$lang_common['Image link'].'></a>';

i think thats it but i'm not sure, and its valid (even if its not really correct)

FluxBB.
Connorhd.co.uk.

Connorhd's Website

2 Reply by chuvi

  • chuvi
  • Junior Member
  • Offline
  • From: Moscow, Russia
  • Registered: 2004-07-07
  • Posts: 7

Re: Open links in new windows

Maybe just add "target" attribute?

return '<a href="'.$full_url.'" target="_blank">'.$link.'</a>';

chuvi's Website

  • Connorhd
  • Connorhd
  • Former PunBB Developer
  • Offline
  • From: Leeds, UK
  • Registered: 2004-06-13
  • Posts: 4,195

Re: Open links in new windows

no its not valid

FluxBB.
Connorhd.co.uk.

Connorhd's Website

  • From: Lima - Perú
  • Registered: 2004-09-23
  • Posts: 104

Re: Open links in new windows

thanks for this mod connorhd

El Mejor Lugar de la Red - Corporación Azakur4

Azakur4's Website

5 Reply by dot

  • dot
  • Member
  • Offline
  • From: Rocky Mountains
  • Registered: 2004-07-30
  • Posts: 31

Re: Open links in new windows

Yes, thank you for your work...

6 Reply by Rod

  • Rod
  • Senior Member
  • Offline
  • From: Rouen, France
  • Registered: 2004-07-19
  • Posts: 591

Re: Open links in new windows

It's a radical mod !!! sad

So ... it's possible to do this ?

in head add

<script type="text/javascript">
         <!--
    function externalLinks() {
        if (!document.getElementsByTagName) return;
            var anchors = document.getElementsByTagName("a");
            for (var i=0; i<anchors.length; i++) {
            var anchor = anchors[i];
                if (anchor.getAttribute("href") &&
                anchor.getAttribute("rel") == "external")
                anchor.target = "_blank";
                }
            }
        window.onload = externalLinks;
           -->
        </script>

The script searchs on the whole site ... where a rel=external is inside the links.


If javascript is disable, it degrades well ... and it's according about W3C


In code we have

<a href="http://punbb.org" rel="external">The Best Forum, PunBB</a>

In this case, by default, a link has no target ... but by creating a specific BBcode ...

[url-win]http://punbb.org[/url-win]

Or, of course

[url-win=http://punbb.org]PunBB.Org in a New Window[/url]

In this case, it adds in final code rel="external"


.... POSSIBLE ?

http://www.sortons.net
http://www.fantasya.net

Rod's Website

7 Reply by Mako

  • Mako
  • Senior Member
  • Offline
  • Registered: 2003-08-24
  • Posts: 200

Re: Open links in new windows

Have you been smoking hashish?

"You start coding. I'll go find out what they want." - Computer Analyst to Programmer

8 Reply by Miles

  • Registered: 2005-01-28
  • Posts: 49

Re: Open links in new windows

The problem with this mod is that it prevents users from opening links in new tabs.

  • Connorhd
  • Connorhd
  • Former PunBB Developer
  • Offline
  • From: Leeds, UK
  • Registered: 2004-06-13
  • Posts: 4,195

Re: Open links in new windows

please don't start that again, i made this mod to stop that go read the half dozen other topics on it

FluxBB.
Connorhd.co.uk.

Connorhd's Website

10 Reply by Rod

  • Rod
  • Senior Member
  • Offline
  • From: Rouen, France
  • Registered: 2004-07-19
  • Posts: 591

Re: Open links in new windows

However Connorhd smile your mod is "extrem" : with your mod, all links become externals ... no ?

http://www.sortons.net
http://www.fantasya.net

Rod's Website

  • Connorhd
  • Connorhd
  • Former PunBB Developer
  • Offline
  • From: Leeds, UK
  • Registered: 2004-06-13
  • Posts: 4,195

Re: Open links in new windows

all posted links become external, if you don't like it make your own mod

FluxBB.
Connorhd.co.uk.

Connorhd's Website

  • From: -8 GMT
  • Registered: 2004-05-04
  • Posts: 1,396

Re: Open links in new windows

see what happens when you try to please one group Connorhd, you are chastized by another. wink

~James
FluxBB - Less is more

13 Reply by Rod

  • Rod
  • Senior Member
  • Offline
  • From: Rouen, France
  • Registered: 2004-07-19
  • Posts: 591

Re: Open links in new windows

Connorhd wrote:

all posted links become external, if you don't like it make your own mod

don't bite please ... mmmmmm after reflexion, I like it .. smile

http://www.sortons.net
http://www.fantasya.net

Rod's Website