• Smartys
  • Former PunBB Developer
  • Offline
  • Registered: 2004-04-30
  • Posts: 7,844

Topic: Various missing checks

- The link to phpinfo in admin_index.php may be hidden for mods, but it can still be accessed by them if they know the URL
- in admin_index.php, the PHP and DB version and use of some caching software (and if you use MySQL, the stats for the DB as well) are fetched even if you're a mod and thus don't have it displayed.

  • From: 127.0.0.1
  • Registered: 2001-11-02
  • Posts: 9,167

Re: Various missing checks

Smartys wrote:

- The link to phpinfo in admin_index.php may be hidden for mods, but it can still be accessed by them if they know the URL

I'll fix it.

Smartys wrote:

- in admin_index.php, the PHP and DB version and use of some caching software (and if you use MySQL, the stats for the DB as well) are fetched even if you're a mod and thus don't have it displayed.

It's not like it's a performance killer. I think adding checks will only make the code uglier.

"Programming is like sex: one mistake and you have to support it for the rest of your life."

Rickard's Website

3 Reply by Smartys (edited by Smartys 2005-03-12 23:51)

  • Smartys
  • Former PunBB Developer
  • Offline
  • Registered: 2004-04-30
  • Posts: 7,844

Re: Various missing checks

Rickard wrote:
Smartys wrote:

- in admin_index.php, the PHP and DB version and use of some caching software (and if you use MySQL, the stats for the DB as well) are fetched even if you're a mod and thus don't have it displayed.

It's not like it's a performance killer. I think adding checks will only make the code uglier.

I'll test it on my forum and compare smile

Edit: All I had to do was add an if statement around that block to see if I were a mod. Doesn't look any uglier to me.