Attachment Mod 2.0.1 by Frank H (Page 2 of 21)

Frank, previously i've get you wrong.. i thought you was saying about RESUME UPLOADS, not a downloads
for downloads it's all pretty clear
here's good descritpion with examples: http://www.vbip.com/winsock/winsock_http_08_01.asp

and by the way - the reason of delay of loading is in "keepalive" i think.. because i've make this parameter on server larger, and delay become very big...
i think there must be

        header('Connection: close');

near

        header('Pragma: no-cache'); //hmm, I suppose this might be possible to skip, to save some bw, but I'm far from sure, so I let the 'no cache stuff' be...
        header('Expires: 0');

file - attachment.php... near the end.
after adding this line picture previews became very rapid:)

take a peak in my modified files, to see if you can spot any differences between yours and mine ... not sure if IIS would interfer with the copying of files... or, if the generated subfolder has the index and .htaccess files, I suppose the script can move/copy files ...

yes, feel free to incorporate it in rickards query if you think you'll be able to ... I decided not to mess too much with PunBB's code, as few replaces as possible to make the mod less dependent on the rest of PunBB's code, and thus hopefully not as much dependent on minor updates on PunBB's code.
(and it's done in the same way as the old mod, noone complained about it then as far as I remember )
The topic query seems to be a hard enough query either way (as changeset 172 made a update after 1.2.5 on the query that fetches all info for the posts ) ... step 43/44 is the readme handles PunBB's query for the posts ... to be able to make querys where I make them, I had to toggle the true to false in the buffered query ... that is perhaps the reason why you notice it ... as I doubt it's the 0.01084s longer time for the 13 extra queries...

But, there's no way adding a mod won't affect performance, and this mod is quite large, as you might have noticed when installing it ... but I'm not forcing you to use it ... I've done it for myself, and shared it to you all if more people want to attach files

First going to figure out what it does (pretty tired of w3c, stuff working ok on some places fail on other...) ... from the HTTP/1.1 spec

14.10 Connection

   The Connection general-header field allows the sender to specify
   options that are desired for that particular connection and MUST NOT
   be communicated by proxies over further connections.

   The Connection header has the following grammar:

       Connection = "Connection" ":" 1#(connection-token)
       connection-token  = token

   HTTP/1.1 proxies MUST parse the Connection header field before a
   message is forwarded and, for each connection-token in this field,
   remove any header field(s) from the message with the same name as the
   connection-token. Connection options are signaled by the presence of
   a connection-token in the Connection header field, not by any
   corresponding additional header field(s), since the additional header
   field may not be sent if there are no parameters associated with that
   connection option.

   Message headers listed in the Connection header MUST NOT include
   end-to-end headers, such as Cache-Control.

   HTTP/1.1 defines the "close" connection option for the sender to
   signal that the connection will be closed after completion of the
   response. For example,

       Connection: close

   in either the request or the response header fields indicates that
   the connection SHOULD NOT be considered `persistent' (section 8.1)
   after the current request/response is complete.

   HTTP/1.1 applications that do not support persistent connections MUST
   include the "close" connection option in every message.

   A system receiving an HTTP/1.0 (or lower-version) message that
   includes a Connection header MUST, for each connection-token in this
   field, remove and ignore any header field(s) from the message with
   the same name as the connection-token. This protects against mistaken
   forwarding of such header fields by pre-HTTP/1.1 proxies. See section
   19.6.2.

Hmm, are you behind a proxy perhaps, or I saw something about IE having trouble in the PHP page aswell (but for a 'moved permanently' header) ... need to look at it..
do you feel like telling what browser(& version) you're running, and if you're behind a proxy/firewall?

05:30am  now ... gotta get some sleep

Frank, nope.. not a firewall. I have connected to localhost even
Browsers.. well, explorer 6 and firefox 1.1 .. no matter which..
oh, there is one point - apache server (2.0.53) is configured like that:

#
# KeepAlive: Whether or not to allow persistent connections (more than
# one request per connection). Set to "Off" to deactivate.
#
KeepAlive On

#
# MaxKeepAliveRequests: The maximum number of requests to allow
# during a persistent connection. Set to 0 to allow an unlimited amount.
# We recommend you leave this number high, for maximum performance.
#
MaxKeepAliveRequests 100

#
# KeepAliveTimeout: Number of seconds to wait for the next request from the
# same client on the same connection.
#
KeepAliveTimeout 15

well, it's default apache settings.

Frank, there is HUGE algorithmic nonoptimality in topicview.php
this code with "select from rules" executes EVERY message of topic... the point of this select - to determine, are attachments available for this user/group... but it's unnecessary to execute it every message.. one for topicview will be fine!

        if($pun_user['g_id']==PUN_ADMIN)$attach_allow_download=true;
        else{         //fetch the rules of the forum, and check so that the user is allowed to download.
            $result_attach_two = $db->query('SELECT ar.rules FROM '.$db->prefix.'attach_2_rules AS ar WHERE ar.group_id=\''.$pun_user['group_id'].'\' AND ar.forum_id='.$cur_topic['forum_id'].' LIMIT 1')or error('Unable to fetch rules for the attachments', __FILE__, __LINE__, $db->error());
            if($db->num_rows($result_attach_two)==1){
                list($attach_rules)=$db->fetch_row($result_attach_two);
                $attach_allow_download = attach_rules($attach_rules,ATTACH_DOWNLOAD);
            }
        }

After updating got this when tried to open topics
" Unable to fetch if there were any attachments to the post. "

Checked veiwtopic and attachment folder - no result

I install the mod.   All appear to work fine, but the files are not writed in the HD, there are not any error.

Can you help me to resolve this.

PHP can upload files in php.ini

Sounds like you might have got an error during mod_install.php, what tables do you have in the database (make sure the attach_2_files and attach_2_rules tables are there)

good to hear it works now though

Do you have a folder with a bunch of random letters and numbers in your attachment folder, if so, do that folder contain two files, an index.html and an .htaccess?
Also, make sure the php settings are correct, so it allows fileuploads. (and you probably need to restart Apache (or whatever your websoftware is) to get PHP to alter it's settings, as Smartmonkey noticed )

No, not yet, only English as of now. But if you translate it, I'd love to have it as my german isn't so good

I'm trying...

In the documentation (chapter 2.1.1), there's info on what columns the attach_2_files database should have, do your table have all those columns?

Well, even if there is a problem with the attach dir, that doesn't explain that error, that error only comes from the database query that looks into the attach_2_files table ... can you enable debug and show queries (in common.php), and tell the output for that query? (you can also mail to frank [dot} hagstrom [at} gmail [dot} com if you don't want to show stuff in open )

thanks flx

about plox issue, the $cur_post['id'] has gone missing, we're trying to figure out why ... so if it's a bug I'll defenetly post about it in the first post
Edit: with my viewtopic.php from the 'debug-zip' it seemed to work