Attachment Mod 2.0.1 by Frank H (Page 6 of 21)

thnx

I think it's the browser that controls that text, unfortunately ... so it will depend on the language used on the client computer ...

I'm afraid it might not be that easy to do, due to the way the rules etc. are set up ... And, as it's a 'special case' scenario, I'm not so keen on messing up the code for a specific usergroup ... as it will only apply to those that allows guests read, but not dowload, and that download for guests is quite logical if they are allowed to read the posts... or at least write in the description of the forum that guests isn't allowed to see the attachments ... but need to register to be allowed to do so...

Might be better to have some other notice to guests that there "might be" attachments, and that by registering you're allowed to download al files ... but ... it's all about what rules you've decided to use ... and is therefore different between all forums ...

But I'll probably make the code a bit more effective in viewtopic.php sometime during the summer if I get some free time, so I'll look if there is an easy way to do it without messing up the code ...

Ok, a simple solution will be this one (FIRST OF ALL, MAKE A BACKUPS OF THE ORIGINAL viewtopic.php AND  lang/english/attach.php):

1. Open viewtopic.php
2. Replace:

    // Attachment Mod Block Start
    $attach_allow_download = false;
    $attach_output = '';
    $attach_num = 0;
    // Check if this post has any attachments
    $result_attach = $db->query('SELECT af.id, af.filename, af.size, af.downloads FROM '.$db->prefix.'attach_2_files AS af WHERE af.post_id='.$cur_post['id']) or error('Unable to fetch if there were any attachments to the post', __FILE__, __LINE__, $db->error());
    $attach_num = $db->num_rows($result_attach);
    if($attach_num > 0){
        if($pun_user['g_id']==PUN_ADMIN)$attach_allow_download=true;
        else{         //fetch the rules of the forum, and check so that the user is allowed to download.
            $result_attach_two = $db->query('SELECT ar.rules FROM '.$db->prefix.'attach_2_rules AS ar WHERE ar.group_id=\''.$pun_user['group_id'].'\' AND ar.forum_id='.$cur_topic['forum_id'].' LIMIT 1')or error('Unable to fetch rules for the attachments', __FILE__, __LINE__, $db->error());
            if($db->num_rows($result_attach_two)==1){
                list($attach_rules)=$db->fetch_row($result_attach_two);
                $attach_allow_download = attach_rules($attach_rules,ATTACH_DOWNLOAD);
            }
        }
        if($attach_allow_download){//check if the user is allowed to download it.
            $attach_output .= $lang_attach['Attachments:'].' ';
            while(list($attachment_id, $attachment_filename, $attachment_size, $attachment_downloads)=$db->fetch_row($result_attach)){
                $attachment_extension=attach_get_extension($attachment_filename);
                $attach_output .= '<br />'."\n\t\t\t\t\t\t".attach_icon($attachment_extension).' <a href="./attachment.php?item='.$attachment_id.'">'.$attachment_filename.'</a>, '.$lang_attach['Size:'].' '.number_format($attachment_size).' '.$lang_attach['bytes'].', '.$lang_attach['Downloads:'].' '.number_format($attachment_downloads);
            }
        }
    }
    // Attachment Mod Block End

with:

    // Attachment Mod Block Start
    $attach_allow_download = false;
    $attach_output = '';
    $attach_num = 0;
    // Check if this post has any attachments
    $result_attach = $db->query('SELECT af.id, af.filename, af.size, af.downloads FROM '.$db->prefix.'attach_2_files AS af WHERE af.post_id='.$cur_post['id']) or error('Unable to fetch if there were any attachments to the post', __FILE__, __LINE__, $db->error());
    $attach_num = $db->num_rows($result_attach);
    if($attach_num > 0){
        if($pun_user['g_id']==PUN_ADMIN)$attach_allow_download=true;
        else{         //fetch the rules of the forum, and check so that the user is allowed to download.
            $result_attach_two = $db->query('SELECT ar.rules FROM '.$db->prefix.'attach_2_rules AS ar WHERE ar.group_id=\''.$pun_user['group_id'].'\' AND ar.forum_id='.$cur_topic['forum_id'].' LIMIT 1')or error('Unable to fetch rules for the attachments', __FILE__, __LINE__, $db->error());
            if($db->num_rows($result_attach_two)==1){
                list($attach_rules)=$db->fetch_row($result_attach_two);
                $attach_allow_download = attach_rules($attach_rules,ATTACH_DOWNLOAD);
            }
        }
        if($attach_allow_download){//check if the user is allowed to download it.
            $attach_output .= $lang_attach['Attachments:'].' ';
            while(list($attachment_id, $attachment_filename, $attachment_size, $attachment_downloads)=$db->fetch_row($result_attach)){
                $attachment_extension=attach_get_extension($attachment_filename);
                $attach_output .= '<br />'."\n\t\t\t\t\t\t".attach_icon($attachment_extension).' <a href="./attachment.php?item='.$attachment_id.'">'.$attachment_filename.'</a>, '.$lang_attach['Size:'].' '.number_format($attachment_size).' '.$lang_attach['bytes'].', '.$lang_attach['Downloads:'].' '.number_format($attachment_downloads);
            }
        }
        //////->Added
        else {
            $attach_output .= $lang_attach['Attachments:'].' ';
            while(list($attachment_id, $attachment_filename, $attachment_size, $attachment_downloads)=$db->fetch_row($result_attach)){
                $attachment_extension=attach_get_extension($attachment_filename);
                $attach_output .= '<br />'."\n\t\t\t\t\t\t".attach_icon($attachment_extension).$attachment_filename.', '.$lang_attach['Size:'].' '.number_format($attachment_size).' '.$lang_attach['bytes'].', '.$lang_attach['Downloads:'].' '.number_format($attachment_downloads);
            }
            $attach_output .= '<br /><b>'.$lang_attach['notallowed'].'</b>';
        }
        /////
    }
    // Attachment Mod Block End

3. Replace:

<?php if ($attach_allow_download) echo "\t\t\t\t\t".'<div class="postsignature"><hr />'.$attach_output.'</div>'."\n"; ## Attachment Mod row ?>

with:

<?php /*if ($attach_allow_download)*/ echo "\t\t\t\t\t".'<div class="postsignature"><hr />'.$attach_output.'</div>'."\n"; ## Attachment Mod row ?>

4. Save and upload
5. Open  lang/english/attach.php
6. After line 10, add (don't forget to change the text between ' ' with something else) :

'notallowed'            =>    'some text to inform guests that they can download files only if they have an account',

7. Save and upload

I hope this will make more users to register on your forum.
Sorry again for my poor english!

Stefan

Indeed, the only difference is the else statement.

P.S.: The code was very easy to understand 'cose is written very clean. Thank you for that!

aah ... hehe, simple to do such small things

Not really high on my list ... more code is needed, and I don't want to mess with any java features (not working everywhere) or temporary storage (risk for big mess, and lots of code and extra functions needed, to clean up after people only uploaded files, but never posted the message) ... this is the 'simplest'/lightest way to allow more than one file ... and that's exactly why I haven't borthered with adding lots of code to the uploads
(and you have the issue of php variables that can mess up even more ... what should the limit be set to? as if you upload 4 files at once, the post data becomes the total size of all files, and if the max allowed filesize needs to be a 4th of that, why cannot you upload one file with 3 times the size of the small ones? ... to solve that one would need to upload each file to a temporary storage, one by one, and use javascript/dhtml stuff to update the post or similar ... and to me that's just way too bloated ... I know vBulletin etc. solve it that way ... but not PunBB:ish over that IMHO )

(also, what happens with a limit of 100 attachments, or unlimited? shoud it have a limit on 4-5 then, but then people want to have 10, and so on ... and then one need to add it to be per forum basis... and then people want to have it per usergroup basis ... and so on ...)

So, I doubt I'll include it in later versions ... I feel it's too much bloat over it ... I added this mostly so people won't need to post 20 posts for 20 files, like it was in the first mod ... now there is a possibility to attach more files, for those that needs it ... and it doesn't mess upp the code too much...

(I think it has been discussed in this thread somewhere ... but it's 6 pages, so worth repeating )

(most likely) your modifications in viewtopic.php wasn't done correctly ...

recheck that step 43 & 44 is done ... (and if you have added the changesets Rickard told about, then this query looks a little different, but you need to alter the true to false in that row ... )

(hmm ... could be some other stuff aswell ... so mail me if it doesn't work, easier to bughunt through email)

Thanks, I uploaded it to punres, I hope it's ok, othervise just contact me and I'll remove it

have you set the max allowed size described in chapter 1.6 in the documentation?

yep, it's like that to force people to set the size according to their server (as it will be different on many servers, and if I set a higher default value, then it's a possibility people not checking this, will get 'odd errors' where some files upload, but not all (i.e. those beeing bigger than the server accepts, gets lost)

so ... that's why it's only 2000 bytes

hmm ... I suppose your useraccount is not in the same group as the webserver is running ... so you should perhaps need 777 or something (same as the img/avatars if that one works) to be able to fiddle with everything ... to do that, open up include/attach/attach_func.php and replace 750 (search for it) with 777 (or what you want instead) ... if you create a new subfolder, then that new one should have 777 instead (and all new attachments will be stored there)

Good to hear you managed to sort it out ... you could probably ask your host to set the chmod and owners on the subfolders to what you figured out worked.

I guess it's a PHP ini setting that's limiting the phpscript from setting a 777 directory ... but at least with 755 it's still possible to download fiels for backup ...

I knew when I 'left database storage' that these kind of things would come ... and so far, two (If I recall correctly) people has needed to alter the attach_func.php file (and also install_mod.php and upgrade has a 750 setting in there) ... luckily not that many more

oh, and you should probably edit out the images, as you have the foldernames visible (makes it a tad easier to bruteforce if you show the foldernames, only need to bruteforce the filenames)