Invitation 1.0.1 (Page 1 of 2)

Installing it and making it the way I wanted was kind of frustrating, but anyway, thanks for the mod. Hopefully I can get more users to my forums with this.

Thanks again!
Brian

I have two recommendations for if you ever make a new version:
- Have an option for all users to have unlimited invites
- Improve the invitation "card" that is sent

There are a few issues:

- IMHO, the card is hard to edit. When I tried editing it myself, I went through a billion errors before I could get it right.
- The link tag is messed up - I see the HTML when I receive the invitation. Do you have to configure the MIME type as text/html or something? (I really don't know)
- The card should include some info on the board - title, admins, moderators, etc
- The admin plugin should have a field for a default header, footer, etc to send with each invite
- If you can get HTML working right, BBCode might be nice, though it wouldn't be that important

I guess that's kind of a hefty list, but it's just my opinion. Overall, the mod is great. I'd just hate to see it spoiled by a few minor issues. I made a few minor chages to your code; if you want, I can email them to you, though I don't think they'd be much use, they're just aesthetic (did I spell that right?) changes.

Also, when someone doesn't have any invitations left, a message should be displayed in the profile view, rather than just a blank pane. I'm not sure - do new members automatically receive invites based on the amount given to each group in the plugin? If not, they should.

OK, I'm done wining now . If you need some help testing, or with something that doesn't require much PHP skill, just ask.

Yes, you have to do that in the source.
I'll see if I can change that.

No, you don't have to change the mime type. I thought some mail clients wouldn't interprete the link as a clickable one without the html tag but that was maybe wrong...
I'll fix that.

Hm. I think I'll add some description of the board so people know *what* they are invited to. You have a point there.
But I think the admin names are not so important

Sorry, I am very conservative in this and IMO emails have nothing, absolutely noting to do with HTML and they shouldn't. They are messages, information, whatever, and seeing the amount of mail traffic nowadays any tag that you do not send helps
So - no HTML mails for me, thanks.

Yes, go ahead, I am absolutely sure it is not perfect. This thing is terribly bad to test (no esxcuse, just an explanation )

You are right there, however, this is difficult to implement.
I'll see for that when I find the time.

That's fine - your the one doing the work anyway. Like I said, the BBCode isn't that important to me.

Anyway, I'll see if I can install the new version and test it out for you. I'll post back with my results.

Also, I mentioned being able to preview a card before sending - I have a vague idea of how I might be able to hack that together on my own, though it'll probably be a week or two until I'm finsished 'cause I've got other stuff to attend to.

Thanks for your quick response! I'm glad to see your taking care of your mod.

i get this error

aftr going to invitation link to register form and typing the all the fileds and aftr submitting this error come

An error was encountered
Error: Unable to verify invitationNo data.

what to do now?

So you clicked on the link in the invitation email you got and this error came up?
How did the link look?
The message means more or less that it was an invalid invitation id.

OK I saw it.

This happens when the user who registers gives an email address that is different from the one the email was sent to.
Say, you send an invitation to masti@land.com .
Now the recipient clicks the link, goes to the registration page and in his email address field he enters
somebody@else.org

Then you get this failure.

Stupid of me to have this undocumented, but I think for security reasons it makes sense

If you hate this feature I'll tell you how to stop the email double check

To take the email check out do the following:
In your include directory, open invitation_db.php and go to line 64

  $result = $db->query("SELECT userid from ".$db->prefix."invitations 
        WHERE recipient='" . $email . "' and code='" . $code . "' and used='00000000000000'") or error('Unable to fetch Invitation code', __FILE__, __LINE__, $db->error());

and replace it with

  $result = $db->query("SELECT userid from ".$db->prefix."invitations 
        WHERE code='" . $code . "' and used='00000000000000'") or error('Unable to fetch Invitation code', __FILE__, __LINE__, $db->error());

That's all.
As for the automatic filling, that's a lot more work.
try this first & see if it fixes your problem

Ohhhhh... sorry. Sorry. Sorry.
I overlooked something.
Easiest thing is you go to include/invitation_db.php and replace the complete function checkInvitation with:

function checkInvitation($email,$code)  {
  global $db;
  //Check if the given Emailis the same as the one used in the invitation
  $result = $db->query("SELECT userid from ".$db->prefix."invitations 
        WHERE code='" . $code . "' and used='00000000000000'") or error('Unable to fetch Invitation code', __FILE__, __LINE__, $db->error());
    if (!$db->num_rows($result) or $db->num_rows($result) == 0)  {
       return "No data";
       }
    else  {
      list($userid) = $db->fetch_row($result);
      $result = $db->query("update  ".$db->prefix."invitations set used=NOW()
        where code='" . $code . "'") or error('Unable to update Invitation table', __FILE__, __LINE__, $db->error());
      return $userid;
      }
  
  }

I tested this and it does work.

You do that in include/mod_invitation.php
in line 29:

     $mtext = $form['invitation_text'] . "\n".$lang_invitation['Forum Link'].$act_link;

You can add, tweak, remove text here.
Have fun!