bbc code and urls

It's not as easy as it sounds to fix, but I'll put it on the list.

Ok, heres an attempt

//
// Make hyperlinks clickable
//
function do_clickable($text)
{
    global $pun_user;

    $text = "[a] ".$text;

    $text = preg_replace('#(\[(?!url)[^\]]*?\][^\]]*?[\s\(\)])(https?|ftp|news){1}://([\w\-]+\.([\w\-]+\.)*[\w]+(:[0-9]+)?(/[^"\s\(\)<\[]*)?)#ie', '\'$1\'.handle_url_tag(\'$2://$3\')', $text);
    $text = preg_replace('#(\[(?!url)[^\]]*?\][^\]]*?[\s\(\)])(www|ftp)\.(([\w\-]+\.)*[\w]+(:[0-9]+)?(/[^"\s\(\)<\[]*)?)#ie', '\'$1\'.handle_url_tag(\'$2.$3\', \'$2.$3\')', $text);

    return substr($text, 4);
}

How it works is it forces the last bit of bbcode before the clickable link to not be [url.....], the catch is we have to prepend a dummy bbcode to the text then remove it at the end or any links added before bbcode won't get parsed.

If anyone is interested
(\[(?!url)[^\]]*?\][^\]]*?[\s\(\)])
is the important bit is
and its in ( ) as it needs to be added back, and it means
[ not followed by url, then followed by any number of characters except ], then a ], then any characters except ] (this is so it doesn't find another bbcode before the [url]and match that), then the space/(/) that is allowed before the url.

Also out of interest why "global $pun_user;"? Its on a couple of others that don't use it too i think.