1 (edited by elbekko 2006-02-02 20:54)

Topic: Easy Custom Smilies v0.5

This tool adds the possibility to easily add smilies without having to edit your parser.php every time.

##
##
##        Mod title:  Easy Custom Smilies
##
##      Mod version:  0.5
##   Works on PunBB:  Should work on every version
##     Release date:  2006-02-01
##           Author:  El Bekko
##
##      Description:  This tool adds the possibility to 
##                      easily add smileys without having 
##                      to edit your parser.php every time.
##
##   Affected files:  parser.php
##                    
##       Affects DB:  Yes
##
##            Notes:  Should work fine now.
##                      Requires FTP CHMOD access to img/smilies folder.
##
##       DISCLAIMER:  Please note that "mods" are not officially supported by
##                    PunBB. Installation of this modification is done at your
##                    own risk. Backup your forum database and any and all
##                    applicable files before proceeding.
##
##

Have fun with it, installation guide is included in the readme. Should work with any version of punBB.

PunRes link: http://punres.org/desc.php?pid=172

Updated to version 0.4 on 2006-02-1
Included install_mod.php in v0.4

Updated to v0.5 on 2006-02-2
Fixed install_mod.php
Fixed security issues
Support for DB's other than MySQL
Note: The piece of code in parser.php needs to be replaced by a new one. Please don't forget that

Re: Easy Custom Smilies v0.5

Your link was broken, so I took the liberty to fix it for you.

Anyway, I'm sure everyone here appreciates your effort, but I've got a few issues to bring up:
- As this relies upon not only an admin plugin but also a code and DB change, it's better classified as a mod. I've moved the topic to reflect that.
- What differentiates this from:
  http://punres.org/viewtopic.php?id=207
  http://punres.org/desc.php?pid=159  (?)
- I'd suggest you take a look at the MDK and [HOWTO] - Post mod release announcement

Sorry I have to be annoying like that. sad

Looking for a certain modification for your forum? Please take a look here before posting.

Re: Easy Custom Smilies v0.5

Not to mention your plugin is missing the GPL bit from it, and it isn't even the plugin for your mod tongue

Re: Easy Custom Smilies v0.5

lol, prolly something that went wrong when zipping it tongue

And pogenwurst, I'll look into it smile It's just the first time I publish one of my mods, so yah...
I don't mind whining (except from Smartys X()

And I'll release v0.4 while I'm fixing this tongue

Re: Easy Custom Smilies v0.5

Mod updated. Should now have everything in it to make it work tongue

6 (edited by Jasoco 2006-02-01 23:34)

Re: Easy Custom Smilies v0.5

I'm sorry, but this is all screwed up. The Installer is broken. sad

The first error I get is on line 12:
Parse error: parse error, unexpected ',', expecting ')' in /home/jasoco/public_html/geekpub/plugins/install_mod.php on line 12

After I fix that error, another pops up further down.
Parse error: parse error, unexpected ';' in /home/jasoco/public_html/geekpub/plugins/install_mod.php on line 33

Then after I fix THAT one ANOTHER one pops up. I hope you fix it soon.

Edit: Wait. I think I fixed it. There is an extra comma on line 12 and two extra semicolons on line 33 and 44. Remove all three and it seems to load right.

Re: Easy Custom Smilies v0.5

Jasoco: There are also quite a few issues with this mod in general (I know Bekko on another site and I just sent him 5 or 6 memos via the IRC server). Hopefully he'll fix them tomorrow. In the meantime, at the least you shouldn't put this code on a production site (at the very least, make the plugin AP instead of AMP).

Re: Easy Custom Smilies v0.5

Well then how should I add smileys? What's AP and what's AMP mean? I just need to put my smilies back in. My members deserve it. I came from phpBB where adding more was easy as pie.

Also, is it Smileys or Smilies?

Re: Easy Custom Smilies v0.5

Jasoco,

pogenwurst wrote:

What differentiates this from:
http://punres.org/viewtopic.php?id=207
http://punres.org/desc.php?pid=159  (?)

Those mods I mentioned should work. Also, Rickard has written an excellent howto on adding smilies manually.

Looking for a certain modification for your forum? Please take a look here before posting.

10

Re: Easy Custom Smilies v0.5

I'll use the How-to. That seems easier to me. Thanks. Well, off to smiley-ize my forum. wink

11

Re: Easy Custom Smilies v0.5

AMP means that mods too can ad smilies (use the plugin)
AP -plugins can be used only by the admin

Re: Easy Custom Smilies v0.5

I saw your memos Smartys... I know it doesn't hae support for anything else than MySQL, and I clearly stated that. I'm trying to make it compatible with all, as you obviously saw on punres.org.

And it would also help if you state EXACTLY where those errors are, as I'm not suhc a 1337 coder as you that has written numerous mods tongue I'm looking into fixing it now (installer were some copy errors sad).

But I don't like modifying code without adding an extra feature ontop tongue So tell me what should be improved/added smile

Re: Easy Custom Smilies v0.5

Bah, I figured it wouldn't be hard for most of the stuff (and I can't put too much stuff in a memo, there just isn't space tongue)
I'll try and find you on IRC wink

Re: Easy Custom Smilies v0.5

It's not so hard for the most stuff, indeed tongue Now come find me on IRC X(

Re: Easy Custom Smilies v0.5

Updated to version 0.5, fixes are described in top post.

Re: Easy Custom Smilies v0.5

*huggles Bekko tongue*

Re: Easy Custom Smilies v0.5

big_smile

Do note, there seems to be a minor bug in the readme that I'll update today or tomorrow (probably today). I forgot to change the part to paste in parser.php after I updated a db function there sad
So expect another update with some more fixes soon smile

Re: Easy Custom Smilies v0.5

0.5.1 uploaded.

Re: Easy Custom Smilies v0.5

Do you have a screenshot of it in action?