26

Re: Move Post 1.3 + Merge Topics

fpouget,

In your demo, moving a topic to another forum also doesn't work.
I tried to move a topic from forum 5 to forum 4, but nothing happened.

Re: Move Post 1.3 + Merge Topics

Yes I have the same ... I should be able to find why later this afternoon.

28

Re: Move Post 1.3 + Merge Topics

fpouget wrote:

I got the error out. (see the last post; I edited it)

Means  ok  ????

To me it is, but let's wait for elbekko, maybe he's found something that I missed...

29

Re: Move Post 1.3 + Merge Topics

I think the problem is in the place while checking radio button, because no action is taken.

30 (edited by elbekko 2006-03-04 16:29)

Re: Move Post 1.3 + Merge Topics

Let's see if I can get some more errors out :P

// Language definitions used in the mod "Move Post" 1.1



$lang_movepost = array(



'Mod move post'            =>    '[Move Post 1.1] - Verplaats een bericht',

'Intro'                    =>    'Met deze mod kunt u een of meer berichten verplaatsen naar een ander forum. U kunt ook een nieuw onderwerp starten en daar de berichten naar toe verplaatsen.',



'Introduction'                =>    'Uitleg',

'Create topic'                =>    'Maak een nieuw onderwerp aan',

'Move post'                =>    'Kies het doelonderwerp',

'Original topic'            =>    'Origineel onderwerp:',

'Original forum'            =>    'Origineel forum:',

'Move all posts'            =>    'Verplaats alle berichten uit dit onderwerp',



'Explain move all posts'        =>    'Het originele onderwerp wordt weggehaald.',

'Explain create topic'        =>    'Om een nieuw onderwerp te maken, selecteert u de knop en geeft u een onderwerp op.',

'Explain move post'            =>    'Kies nu een ander forum en selecteer het doel-onderwerp.',



'Select'                    =>    'Kies',

'Last'                    =>    'Laatste',

'Poster'                    =>    'Geplaatst door',



'Bad topic'                =>    'Verkeerd onderwerp',

'Bad new topic'            =>    'De onderwerpregel mag niet leeg zijn',



'Mark move redirect'        =>    'Het bericht is verplaatst naar het gekozen onderwerp. Redirecting …'



);

Should do it. I commented out a line and replaced it, because it wasn't too correct...

31

Re: Move Post 1.3 + Merge Topics

Right so only that line.
I do agree with you on that it might be a "more logical" sentence, but it's not correct.
The "original" English text was:

'Move post'                =>    'Choose the reception topic',

So I still think my translation is more correct, as it doesn't mean "move the message", but "select the topic to move the selected topic/message to".

Re: Move Post 1.3 + Merge Topics

Hrmm, i see. Ok, I'll replace it again smile

33 (edited by fpouget 2006-03-04 16:49)

Re: Move Post 1.3 + Merge Topics

Hi again,

I solve few issues and hopefully all !
The big point is now the mod is working with IE.

Before updated a release can you check if it's working well on the demo : http://georezo.net/demo/

Second please dont' hate me,  I did some changes on the language file bellow.
If you have any other feed back, please feel free !

<?php

// Language definitions used in the mod "Move Post" 1.1.1

$lang_movepost = array(

+'Mod move post'            =>    '[Move Post 1.1.1 beta] - Move a post',
'Intro'                    =>    'This mod allow to move to an other topic in any forum, the selected post, or all the posts belong to the original topic. It allow too to create a new topic where the post(s) will be moved.',

'Introduction'                =>    'Explanation',
'Create topic'                =>    'Create a new topic',
'Move post'                =>    'Choose the reception topic',

'Original topic'            =>    'Original topic:',
'Original forum'            =>    'Original forum:',
+'Select forum'                =>    'Choose eventually a new forum',
'Move all posts'            =>    'Move all posts belong to this topic',

'Explain move all posts'        =>    'The original topic will be deleted.',
+'Explain create topic'        =>    'To create a new topic type, bellow, a new subject.',
+'Explain move post'            =>    'Click on the destination topic.',

'Last'                    =>    'Last',
'Poster'                    =>    'Post by',

'Bad topic'                =>    'Bad choice',
'Bad new topic'            =>    'The subject can not be empty',

'Mark move redirect'        =>    'The post has been moved in the selected topic. Redirecting …'

);

I added '+' to the changing line

34

Re: Move Post 1.3 + Merge Topics

Now it works FINE smile

Re: Move Post 1.3 + Merge Topics

Is the files updated for download?

Re: Move Post 1.3 + Merge Topics

Not yet ! I 'm waiting for more feed back and the final Dutch language file. Probably tomorrow

Re: Move Post 1.3 + Merge Topics

Minis smile

Re: Move Post 1.3 + Merge Topics

The Dutch language file is up there tongue

39 (edited by fpouget 2006-03-04 17:57)

Re: Move Post 1.3 + Merge Topics

elbekko

I did some changes in the language : http://punbb.org/forums/viewtopic.php?pid=64065#p64065 i'm waiting for these ones ..

40

Re: Move Post 1.3 + Merge Topics

Ok,

I'll look at the extra's. Like your translation changes. Let's keep it this way.

elbekko wrote:

Let's see if I can get some more errors out tongue

// Language definitions used in the mod "Move Post" 1.1



$lang_movepost = array(



'Mod move post'            =>    '[Move Post 1.1] - Verplaats een bericht',

'Intro'                    =>    'Met deze mod kunt u een of meer berichten verplaatsen naar een ander forum. U kunt ook een nieuw onderwerp starten en daar de berichten naar toe verplaatsen.',



'Introduction'                =>    'Uitleg',

'Create topic'                =>    'Maak een nieuw onderwerp aan',

'Move post'                =>    'Kies het doelonderwerp',

'Original topic'            =>    'Origineel onderwerp:',

'Original forum'            =>    'Origineel forum:',

'Select forum'                =>    'Kies het uiteindelijke nieuwe forum',

'Move all posts'            =>    'Verplaats alle berichten uit dit onderwerp',



'Explain move all posts'        =>    'Het originele onderwerp wordt weggehaald.',

'Explain create topic'        =>    'Om een nieuw onderwerp te maken, geef hier een nieuw onderwerp op.',

'Explain move post'            =>    'Selecteer het doel-onderwerp.',



'Select'                    =>    'Kies',

'Last'                    =>    'Laatste',

'Poster'                    =>    'Geplaatst door',



'Bad topic'                =>    'Verkeerd onderwerp',

'Bad new topic'            =>    'De onderwerpregel mag niet leeg zijn',



'Mark move redirect'        =>    'Het bericht is verplaatst naar het gekozen onderwerp. Redirecting …'



);

Should do it. I commented out a line and replaced it, because it wasn't too correct...

That's it, including the last changes.

Re: Move Post 1.3 + Merge Topics

The new release 1.1.1 is available. All the knowned issues have been removed.

For demo and download follow the link.

42

Re: Move Post 1.3 + Merge Topics

fpouget,

It seems to work fine now, however...
I see an error message flashing by after pressing "submit" about an "undefined variable" in movepost.php
Do you have any idea what this is?

Re: Move Post 1.3 + Merge Topics

HJH,

On which action:
- change forum ?
- create topic ?
- move post ?


Fred

44

Re: Move Post 1.3 + Merge Topics

I made a new topic, in another then the old forum.
Then I opened a topic, and selected "move" on a post.
I moved this post to the fresh topic, pressed submit, and then I got the message. After that, redirecting worked, and all resumed as normal. So I guess this is just a small glitch, but maybe something you want to look at.
I didn't see this happening on your forum. Maybe you have some more changes in there that aren't in the mod?

Re: Move Post 1.3 + Merge Topics

hummm .... !!!

Don't know. the demo site is using the standard 1.1.1 and i didn't notice similar your description on my own site too ... Any clue ...

46

Re: Move Post 1.3 + Merge Topics

Fred,

the message is passing in less than a second...
So it's difficult to catch. Here's one line I got:
Notice: Undefined variable: new_forum in /inet/coupe-fiat.nl/forum/movepost.php on line 136

I also got some stuff from the logs, but I guess that doesn't really help:

[Sun Mar 05 19:53:14 2006] [error] [client 145.98.209.235] File does not exist: /inet/coupe-f
iat.nl/forum/img/movepost, referer: http://forum.coupe-fiat.nl/movepost.php?id=1661
[Sun Mar 05 19:53:15 2006] [error] [client 145.98.209.235] File does not exist: /inet/coupe-f
iat.nl/forum/img/movepost, referer: http://forum.coupe-fiat.nl/movepost.php?id=1661
[Sun Mar 05 19:53:19 2006] [error] [client 145.98.209.235] File does not exist: /inet/coupe-f
iat.nl/forum/img/movepost, referer: http://forum.coupe-fiat.nl/movepost.php?id=1661&new_fid=1
6
[Sun Mar 05 19:53:19 2006] [error] [client 145.98.209.235] File does not exist: /inet/coupe-f
iat.nl/forum/img/movepost, referer: http://forum.coupe-fiat.nl/movepost.php?id=1661&new_fid=1
6

Re: Move Post 1.3 + Merge Topics

Try uploading the images...

Re: Move Post 1.3 + Merge Topics

HJH,

1 - you need to upload the images in img/movepost/*.*

2 - Which version of punBB are you working on ?
It seems your version is quite old still using :

// Enable full error, warning and notice reporting
error_reporting(E_ALL);

In order to solve your issue you should :

add in movepost.php

after

line39 : $post_id = intval($_GET['id']);
$new_forum = FALSE;

49

Re: Move Post 1.3 + Merge Topics

Hello Fred,

The images are in the img folder. I copied the movepost image folder there. I do see the arrows in the movepost screen. So the images are there, and punbb can find them.

I am using punbb 1.2.11 (I think we started at 1.2.8, not quite sure).
Where can I find that error_reporting bit?

I added the line to movepost.php

now I get:

Notice: Undefined variable: all_id in /inet/coupe-fiat.nl/forum/movepost.php on line 122

Notice: Undefined variable: del_old_topic in /inet/coupe-fiat.nl/forum/movepost.php on line 132

Notice: Undefined variable: all_id in /inet/coupe-fiat.nl/forum/movepost.php on line 132

Is this only an (unimportant) warning?

Hendrik-Jan

Re: Move Post 1.3 + Merge Topics

No is not important warning, if you want to remove them you should add:
$all_id = '';
$del_old_topic = '';
after the line 39 in movepost.php

Strange  in 1.2.11 you shouldn't have this warning. Compare the include/common.php between the official one in punBB and yours !

Fred