• Registered: 2006-04-18
  • Posts: 14

Topic: misc.php Rules include should not be enclosed in <p></p>

The admin options state for rules:

This text will not be parsed like regular posts and thus may contain HTML.

So to allow valid html, line 52 of misc.php should be changed from

            <p><?php echo $pun_config['o_rules_message'] ?></p>


to             <?php echo $pun_config['o_rules_message'] ?>


The <p> block level element doesn't permit <ol>, for example.

2 Reply by hashar (edited by hashar 2006-05-24 21:24)

  • hashar
  • Junior Member
  • Offline
  • Registered: 2004-03-12
  • Posts: 2

Re: misc.php Rules include should not be enclosed in <p></p>

Patch against 1.2.12 :

--- punbb-1.2.12-orig/misc.php    2006-05-20 19:52:02.000000000 +0200
+++ punbb-1.2.12/misc.php    2006-05-24 23:22:50.000000000 +0200
@@ -49,7 +49,7 @@
     <h2><span><?php echo $lang_register['Forum rules'] ?></span></h2>
     <div class="box">
         <div class="inbox">
-            <p><?php echo $pun_config['o_rules_message'] ?></p>
+            <?php echo $pun_config['o_rules_message'] ?>
         </div>
     </div>
 </div>
  • From: 127.0.0.1
  • Registered: 2001-11-02
  • Posts: 9,167

Re: misc.php Rules include should not be enclosed in <p></p>

Well, one could just close the p tag in the rules text, but I agree, it probably shouldn't be there.

Paul? Can you remove it from 1.3?

"Programming is like sex: one mistake and you have to support it for the rest of your life."

Rickard's Website

4 Reply by Paul

  • Paul
  • Senior Member
  • Offline
  • From: Wales, UK.
  • Registered: 2003-08-13
  • Posts: 3,089

Re: misc.php Rules include should not be enclosed in <p></p>

Done. Actually in 1.3 I had already removed it from misc.php but for some unknown reason it was there in register.php.