• Registered: 2006-10-18
  • Posts: 17

Topic: Changing the tile content

IMO the HTML title content is displayed in the wrong order in PunBB 1.2, it should list the most important content first (the reverse of how you'd list it in a breadcrumb bar). This also ensures that the most relevant bit will be visible on a (typicaly fairly narrow) browser tab.

In the process of changing this around in the source I also noticed what IMO is an omission, the title output of viewtopic.php is "Message title / Board title", IMO it should be "Message Title / Forum title / Board title".

To get viewtopic.php to include this, and undaunted by the fact that I am not PHP literate I copied and pasted this section from viewforum.php into viewtopic.php:

// Fetch some info about the forum
$result = $db->query('SELECT f.forum_name, f.redirect_url, f.moderators, f.num_topics, f.sort_by, fp.post_topics FROM '.$db->prefix.'forums AS f LEFT JOIN '.$db->prefix.'forum_perms AS fp ON (fp.forum_id=f.id AND fp.group_id='.$pun_user['g_id'].') WHERE (fp.read_forum IS NULL OR fp.read_forum=1) AND f.id='.$id) or error('Unable to fetch forum info', __FILE__, __LINE__, $db->error());
if (!$db->num_rows($result))
    message($lang_common['Bad request']);

$cur_forum = $db->fetch_assoc($result);

and then I changed the $page_title line into:

$page_title = $cur_topic['subject'].' - '.$cur_forum['forum_name'].' - '.pun_htmlspecialchars($pun_config['o_board_title']);

This displays a forum name, but it is the wrong one. Any tips on how to do this proper?

  • CodeXP
  • Senior Member
  • Offline
  • From: /dev/null
  • Registered: 2004-07-07
  • Posts: 503

Re: Changing the tile content

Get rid of that query of yours, as that isn't needed. After that, just replace your $page_title line with the following:

$page_title = pun_htmlspecialchars($cur_topic['subject'].' / '.$cur_topic['forum_name'].' / '.$pun_config['o_board_title']);

CodeXP's Website

  • Smartys
  • Former PunBB Developer
  • Offline
  • Registered: 2004-04-30
  • Posts: 7,844

Re: Changing the tile content

IMO the HTML title content is displayed in the wrong order in PunBB 1.2, it should list the most important content first (the reverse of how you'd list it in a breadcrumb bar). This also ensures that the most relevant bit will be visible on a (typicaly fairly narrow) browser tab.

..which is how 1.3 currently behaves wink