Banning TLD's, like .ru? (Page 1 of 2)

You can't ban a whole TLD by default. To do so, you would need to edit the is_banned_email function in include/email.php at least (and admin_bans.php if you don't want to insert/edit bans involving entire TLDs via the command line)

thegleek: Why do you always seem to be so combative?
Nobody is stopping anyone from creating a mod, nobody has said that it isn't a possibility for 1.3, and PunBB is not phpBB (and it wasn't a feature in phpBB for a while as well)

I said it couldn't be done by default and then pointed out what needed to be edited to have it done

Hi

Were do i put this *@*.ru ?

Regards

John

I've got no problem issuing CLI commands, nor do I have any problem with editing include/email.php, but... *what* commands can I use to ban all of .ru? Or... *where* in the ban function would I add the tld? Here's the function:

//
// Check if $email is banned
//
function is_banned_email($email)
{
    global $db, $pun_bans;

    foreach ($pun_bans as $cur_ban)
    {
        if ($cur_ban['email'] != '' &&
            ($email == $cur_ban['email'] ||
            (strpos($cur_ban['email'], '@') === false && stristr($email, '@'.$cur_ban['email']))))
            return true;
    }

    return false;
}

I don't see any obvious place in there where I could a .tld. In another thread, it's suggested to use the Ban admin section and enter a partial, but it accepts neither *.ru nor .ru .

So... can anyone clarify the process a bit? Thanks.

Yemgi, umm... I know. I was asking for a code sample so I wouldn't blow the parentheses or something. But it turned out to be pretty easy:

    foreach ($pun_bans as $cur_ban)
    {
        if ($cur_ban['email'] != '' &&
            ($email == $cur_ban['email'] ||
            strstr('.ru',$email) ||
            (strpos($cur_ban['email'], '@') === false && stristr($email, '@'.$cur_ban['email']))))
            return true;
    }

I'll give it 24 hours to see if it works, that looks pretty solid.

That's because you have the parameter order for strstr mixed up
But here's a better way:
replace

strstr('.ru',$email)

with

substr($email, -3) === '.ru'

Because after reading the code, I can see that's not where you want to put it

FIND

//
// Check if $email is banned
//
function is_banned_email($email)
{
    global $db, $pun_bans;

    foreach ($pun_bans as $cur_ban)
    {
        if ($cur_ban['email'] != '' &&
            ($email == $cur_ban['email'] ||
            (strpos($cur_ban['email'], '@') === false && stristr($email, '@'.$cur_ban['email']))))
            return true;
    }

    return false;
}

REPLACE WITH

//
// Check if $email is banned
//
function is_banned_email($email)
{
    global $db, $pun_bans;

    if (substr($email, -3) === '.ru')
        return true;

    foreach ($pun_bans as $cur_ban)
    {
        if ($cur_ban['email'] != '' &&
            ($email == $cur_ban['email'] ||
            (strpos($cur_ban['email'], '@') === false && stristr($email, '@'.$cur_ban['email']))))
            return true;
    }

    return false;
}

A plugin would be impossible
There's potential for an extension for 1.3 though

No.  I get a fair amount of bogus signups on my site.  Some are .ru and some are mail.ru and other various things.

I would really like to know of a way to simply block certain domains from registering at all.  Anyone know of a good way to completely block registrations from all of the obvious spammer registrations?  It's very easy to tell when a spammer registers just by the email...

I personally would never ban a whole TLD
hotmail.com, yahoo.com, etc are all used by spammers as well

I edited the include/email.php

this works for me:

// Validate an e-mail address
//
function is_valid_email($email)
{
    if (strlen($email) > 50)
        return false;

// Allow primarily American TLDs only
$TLD3 = substr($email, -3);
if( $TLD3 != 'com' && $TLD3 != 'net' && $TLD3 != 'org' && $TLD3 != 'edu' && $TLD3 != 'gov'
                           && $TLD3 != '.ca' )
    return false;
// this also blocks lower tier USA TLDs .info .biz .us .name  

    return preg_match('/^(([^<>()[\]\\.,;:\s@"\']+(\.[^<>()[\]\\.,;:\s@"\']+)*)|("[^"\']+"))@((\[\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}\])|(([a-zA-Z\d\-]+\.)+[a-zA-Z]{2,}))$/', $email);
}

.:.