go to line 243-245 (i don't know exactly, my file is modded):

$result = $db->query('SELECT g_id FROM '.$db->prefix.'groups WHERE g_title= \''.$db->escape($title).'\' && g_id != \''.$_POST['group_id'].'\'') or error('Unable to check group title collision', __FILE__, __LINE__, $db->error());

should be

$result = $db->query('SELECT g_id FROM '.$db->prefix.'groups WHERE g_title= \''.$db->escape($title).'\' AND g_id != \''.$_POST['group_id'].'\'') or error('Unable to check group title collision', __FILE__, __LINE__, $db->error());

ok, i'll share it when i extract it from my site smile
BTW its just a small rewrite of punonline mod for punbb 1.1.5

like this http://dev.hostel.nstu.ru/resources/online.php ? smile

this funcction should be like
function is_valid_email($email)
{
    return preg_match('#[\w-\+]+@[\w-\+]+\.\w+$#', $email);
}

http://www.securitylab.ru/53358.html
XSS in punbb
lack of filtering in jabber and email forms in register and profile
example - use this email
benji@"/><script>alert()</script>.com

not really good.. it still very incomplete
i've completed it for my site, but its too modded to make extract of this mod

BTW, SQL injection is possible in your mod.. try
http://your.host.com/path/calendar.php?month=3'

well... this mod doesnt' work with postgresql...
to make it work:
in every query replace " to \', then, in your database :

 CREATE FUNCTION month(TIMESTAMP)
RETURNS INTEGER
LANGUAGE SQL
AS 'SELECT EXTRACT(MONTH FROM $1 )::integer;'
RETURNS NULL ON NULL INPUT; 
 CREATE FUNCTION year(TIMESTAMP)
RETURNS INTEGER
LANGUAGE SQL
AS 'SELECT EXTRACT(YEARFROM $1 )::integer;'
RETURNS NULL ON NULL INPUT; 
 CREATE FUNCTION dayofmonth(TIMESTAMP)
RETURNS INTEGER
LANGUAGE SQL
AS 'SELECT EXTRACT(DAYFROM $1 )::integer;'
RETURNS NULL ON NULL INPUT;

and replace in queries things like year(date) to year(date::timestamp)

PS there may be more problems, but these are first ones

punbb_geshi.php

if (!defined('PUN_ROOT'))
    exit('The constant PUN_ROOT must be defined and point to a valid PunBB installation root directory.');

  //upload geshi to domain.com/forums/geshi
  include_once(PUN_ROOT.'syn/geshi/geshi.php');
  $geshi = new GeSHi($code, $codename, PUN_ROOT.'syn/geshi/geshi');
//  $geshi->set_header_type(GESHI_HEADER_PRE);
// $geshi->enable_classes(true);
//  $geshi->enable_line_numbers(GESHI_NORMAL_LINE_NUMBERS);
  $code=$geshi->parse_code();

this works fine

by the way, i have very strong slowdowns on firefox when viewing some themes at this and my forum
for instanse, when scrolling this topic http://dev.hostel.nstu.ru/viewtopic.php?id=1
I have Duron 700 , 256M Ram , so this is very annoying

subj

you can see it here: http://dev.hostel.nstu.ru/
So, i have a table class=holder, which holds all other content, it looks like this

+---------------------------------+
|______header____________________|
|                  |            |
|punbb/main content| modules    |
+_______________________________+
|___________footer_______________|

the problem is - when i view topic, a horisontal scroll bar appears, and only main content is visible, a have to scroll horisontally to see my modules. i just cant find punbb's styles, which make so sad

thx!

     PunBB 1.2 - Check for upgrade
    © Copyright 2002, 2003, 2004, 2005 Rickard Andersson 
Server load
    0.19 0.34 0.34 (1 users online) 
Environment
    Operating system: Linux
    PHP: 4.3.9 - Show info
    Accelerator: N/A 
Database
    PostgreSQL 8.0.0 on i686-redhat-linux-gnu, compiled by GCC gcc (GCC) 3.2.3 20030502 (Red Hat Linux 3.2.3-42)

So , go to admin -forums - edit some forum to, for example remove "post replies" perms for some group, save, now try to remove "post topics" perms for this group too - you should get

File: /mnt/dev/www/dev/admin_forums.php
Line: 204

PunBB reported: Unable to insert group forum permissions

Database reported: ERROR: ????????? ???? ???????? ?????????? UNIQUE "pun_forum_perms_pkey"

It seems to me, $db->affected_rows show empty result for some reason

bug:
add user to members and some your group
edit some forum permissions so members could not post topics and your new group could
now enter this forum by this user and you will not see any post new topic link
PS maybe you will not be able to post even through direct url - i have not checked this

well, probably it would be better to make so, to maintain original structure, or punmod does not support this kind of expressions ?
multigroup.pun...

##SQL PGSQL
        ALTER TABLE <prefix>users ADD membergroupids VARCHAR(64)
##SQL MYSQL
ALTER TABLE `<prefix>users` ADD `membergroupids` VARCHAR(64) AFTER `group_id`

there is a bug. your mod will not work on PostgreSQL
you should change

ALTER TABLE `<prefix>users` ADD `membergroupids` VARCHAR(64) AFTER `group_id`

to

ALTER TABLE <prefix>users ADD membergroupids VARCHAR(64)

to let it work with postgres
PS Great MOD!

68

(8 replies, posted in PunBB 1.2 bug reports)

there is a function - pun_trim, it stripes out   from your posts, it stripes out non-printable characters also

hmm. ok...
BTW i've made smth same but at server-side and not using any timeout schemes http://punbb.org/forums/viewtopic.php?id=5297
its not very pretty, but i'll improve it, when i add it to my forum
i don't like huge javascripts smile especially on slow computers.. yeah..

a small question then, how does this script determine that topic is new? i mean does it mark topic read immediately after entering it ?

so to fix the problem, when redirect delay is set to 0
include/functions.php and look for:

        header('Location: '.$destination_url);

and replace it with

        header('Location: '.str_replace('&', '&', $destination_url));

do you really think, that i'm so stupid to make such mistakes and then post bugs here ???

tried to create new user account and then change its profile - i got the same bug sad(

well... not unable at all, but every time i get "Bad request" message. and the info is updated.
i'm using

PunBB version
    PunBB 1.2 - Check for upgrade
    © Copyright 2002, 2003, 2004, 2005 Rickard Andersson
Server load
    6.40 10.08 7.61 (1 users online)
Environment
    Operating system: Linux
    PHP: 4.3.9 - Show info
    Accelerator: N/A
Database
    PostgreSQL 7.4.6 on i686-redhat-linux-gnu, compiled by GCC gcc (GCC) 3.2.3 20030502 (Red Hat Linux 3.2.3-42)

function pun_trim($str)
{
    $fishy_chars = array(chr(0x81), chr(0x8D), chr(0x8F), chr(0x90), chr(0x9D), chr(0xA0), chr(0xCA), ' ');

    return trim(str_replace($fishy_chars, ' ', $str));
}

chr(0xCA) - That's it smile