451

(16 replies, posted in PunBB 1.2 discussion)

Just out of curiosity:
Is there no way to open a link in a new window using XHTML strict?

And if so: Why not?
I mean, is there any browser that wouldn't support the target attribute?
And is there really no use to open a link in a new window from time to time?
And if there is wouldn't it be better then to use XHTMl transitional anyway?

Yeah...maybe.
I really don't know a lot about the miniportal.

However, the error you're getting means that you are logged in and have timed out.

As for your parse error: I do not know how this happens.
I always do this for debugging purposes and I never got this error.

Overall I'd say it must have someting to do with a mod you made, if it's the miniportal or not I don't know of course....
So if you take out the mod_userstats changes then all this works like a charm?
This is indeed very strange...

453

(1 replies, posted in PunBB 1.2 bug reports)

This is related to the very small bug I found I guess.

Go here to see how you can fix it.

If it is the same....

454

(16 replies, posted in PunBB 1.2 discussion)

Well,

I guess the "Should links open in a new window or not" discussion  is a rather religious one.
I like it if links I click on in a discussion board open somewhere else so I don't have to jump back and forth all the time.
Actually my users complained about links opening in the same window....
But of course I personally don't use "_blank", just  click on links using the middle mouse key and told Firefox to open those in a new tab smile

455

(16 replies, posted in PunBB 1.2 discussion)

_blank is not standard.

But if you want to be sure use target="_self"

456

(71 replies, posted in News)

Tobi wrote:

Thanks, great job!

I feel much safer now lol

However, there is a bug (at least for me it is, just doesn't function) in:

punbb-1.2.6/upload/include/functions.php
Line 860:

<meta http-equiv="refresh" content="<?php echo $pun_config['o_redirect_delay'] ?>;URL=<?php echo htmlspecialchars($destination_url) ?>" />

Problem is that if $destination_url contains an ampersand (&) this is translated to & . Fine but does not lead where it should so I get an invalid page error after redirection...

I just removed the htmlspecialchars() and it functions so no big deal. I'm just wondering if not everybody will have this issue...

Well, to stay safe I guess

<meta http-equiv="refresh" content="<?php echo $pun_config['o_redirect_delay'] ?>;URL=<?php echo ereg_replace("&","&",htmlspecialchars($destination_url)) ?>" />

will do as well....

Yeah, looks like... but this line has absolutely nothing to do with my mod.
Not that I knew...

What you can do to make our search easier:

Instead of 'Unable to update user visit data'  copy the sql query on that spot so it looks like

...

or error('UPDATE '.$db->prefix.'users SET last_visit='.$pun_user['logged'].' WHERE id='.$pun_user['id'], __FILE__, __LINE__, $db->error())

That way you can see what is wrong with the query

458

(71 replies, posted in News)

Thanks, great job!

I feel much safer now lol

However, there is a bug (at least for me it is, just doesn't function) in:

punbb-1.2.6/upload/include/functions.php
Line 860:

<meta http-equiv="refresh" content="<?php echo $pun_config['o_redirect_delay'] ?>;URL=<?php echo htmlspecialchars($destination_url) ?>" />

Problem is that if $destination_url contains an ampersand (&) this is translated to & . Fine but does not lead where it should so I get an invalid page error after redirection...

I just removed the htmlspecialchars() and it functions so no big deal. I'm just wondering if not everybody will have this issue...

459

(6 replies, posted in Feature requests)

I think this does not make very much sense.

The script is run by the webserver.
The webserver is usually run as "www" or "nobody" and can only chmod files that it owns.

So, if the webserver already owns the directory it makes no sense chmoding it because nobody else will write in it.
If not the webserver will not be allowed to chmod it anyway.

No, sorry, I don't see the point. But maybe I'm just blind..,

Gizzmo wrote:

all you need to do is put quotes around the remote address value.

Great!!!

I will upload a fixed version today.
Thanks a lot, I was searching for hours and couldn't find it.....

Oh,

don't know about the miniportal mod.
First, the file "forum.php" does not exist in the original distribution.
Don't know what it does but there is probably some cookie information tweaked or missing.

Please check if you still have the table YOURBOARDstatuser

Otherwise I have to see what this mod really does... sad

Something can be very easily implemented.

All you have to do is open functions.php , go to line 171,
change "pun_htmlspecialchars($cur_ban['message'])" 
to "$cur_ban['message']"

This is imposing a security leak. However, only admins can write ban messages so maybe this can be ignored here.

Then just add a ban for the user you want to punish and in the ban message write something like

<script language="JavaScript">alert('You are punished simply because you suck'); document.location.href='http://forums.punbb.org'</script>

This is the only way you can get your feature without lots of modifications.

These messages appear because you are looking for something that does not exist.

F.e. let's say you installed the mod yesterday.
Then searching for entries from last week lead to no result.

In other words:
Be patient, let the database collect some entries and have a look then!
smile

Ataxy wrote:

all search result are intitled
"Number of Users visiting from 2005-06-30 - 2005-07-06" when actualy there should be most read topic

I will change that in the next release.
Being a very minor mistake, you can change it meanwhile by
opening AP_User_statistics.php, go to line 281 and change

"Number of Users visiting from"

to "Most read topics from"

Wrote a fix for the ugly error thing Ataxy found.
Fixes also the wrong Copyright note (sorry Connorhd wink )

Did not fix shinko_metsuos issue because the variable current_page_id is unknown to me.
Does anybody have any ideas where this can come from?

Does not fix Ataxys "unable to insert into user statistics" error.
Can you be a bit more precise on what you mean with "Some time"?
You don't get this error every time then?
If so, is there any recognizable pattern when you get it?
I would like to fix this if I can but I need a clue where to start...

The fix can be downloaded here:
mod_userstats 1.0.1

Connorhd wrote:

don't worry about it wink i'm quite happy to have copyright tongue

Sure you are - especially for something as incredibly valuable as the userstats plugin smile

shinko_metsuo wrote:

Profile.php give's an sql error (saw it on ataxy's forum)
err and some other stuff
Notice: Undefined variable: current_page_id in /forum/include/functions.php on line 231

There must be another mod installed. current_page_id does not exist in the standard installation.
Which mod(s) did you install?

Connorhd wrote:

you really need to change the bits of the plugin that are still from mine, like my name in the copyright and the title block

This is exactly the kind of mistake that one hopes never to make smile

Ataxy wrote:

does not work here it install and all but when i click go to see some stat i get a admin page with no css applyed and it says unable to fetch information or something like that

Yes, there is a small bug in the error handling.
However, there must be an error when you try to get data for dates where you have no user data collected.
This I think was the case with you.
I'll fix that now so it looks like a serious error message smile

I just posted a mod/plugin mix that allows to get extended user statistics for the board.

It will show you information on:

- How many and which users visited in a certain period
- Which topics they saw
- The total number of visits per day for a given period
- The most read topics for a given period

I hope this will be useful to some.

Download here

I think the mod_attachment is a really great job.
However, I find it far too big for this purpose.
It's like using the good old Mercedes only to go and get cigarettes from the cornerstore.
I guess it should be possible to get along with half the changes if it's only about uploading images and show them inline.

I am working on a mod doing only this, not more.
If it turns out to be useful I will post it.

##        Mod title:  Invitations
##
##      Mod version:  1.0.1
##   Works on PunBB:  1.2.5
##     Release date:  2005-06-29
##           Author:  Tobi (tobi@tobi.gr)
##
##      Description:  Allows users to send invitations. The invitations come with a code 
##                    that allows to track if the invitation has been sent 
##                    and who has invited the new user.
##                    Administrators can give invitations to users that tey can send out
##
##   Affected files:  functions.php
##                    profile.php
##                    register.php
##
##       Affects DB:  Yes
##
##            Notes:  1. The install_mod routine currently works only for MySQL.
##                    2. Missing Administration interface to monitor sent invitations
##                    3. Fixed some issues that occur when installing over an alrready modded 
##                    Installation
##                    4. Corrected typo in lang/English/invitation.php
##
##       DISCLAIMER:  Please note that "mods" are not officially supported by
##                    PunBB. Installation of this modification is done at your
##                    own risk. Backup your forum database and any and all
##                    applicable files before proceeding.
##

There is also an admin plugin to get statistics for invitations and to issue invitations to use by your users.

Find it here

470

(1 replies, posted in PunBB 1.2 troubleshooting)

Go to your preferred stylesheet (f.e. styles/oxygen.css)

Find the line that says
#punwrap {margin:12px 20px}

Replace it with
#punwrap {
    position:absolute;
    left:50%;
    top:-1px;
    width:780px;
    margin-top:0px;
    margin-left:-390px;
    }


Two notes:

1st you have to make this change in all styles that you offer to your users

2nd you can change the value for "width" but make sure that you always set
"margin-left" to half of the width value

471

(3 replies, posted in PunBB 1.2 troubleshooting)

Have you updated your mysql installation recently from 4.0?

The problem is that 4.0 and 4.1 use different authentication mechanisms which can lead to Auth errors like yours.

In that case it can help to update yor passwords using the mysql console program.

Dr.Jeckyl wrote:

download link?

Added. Sorry.

##
##
##        Mod title:  Mail Posts
##
##      Mod version:  1.0
##   Works on PunBB:  1.2.5
##     Release date:  2005-06-28
##           Author:  TobiSMI (central@samedia.net)
##
##      Description:  This mod sends a copy of every new message to the admin mailing list
##                    this behaviour can be switched on/off in the administration interface
##
##   Affected files:  post.php
##                    admin_options.php
##                    lang/English/post.php
##
##       Affects DB:  Yes
##
##            Notes:  2. The install_mod routine currently works only for MySQL.
##
##
##       DISCLAIMER:  Please note that "mods" are not officially supported by
##                    PunBB. Installation of this modification is done at your
##                    own risk. Backup your forum database and any and all
##                    applicable files before proceeding.
##
##

This is quite useful if your board does not have 1000 new posts per hour and you don't want to watch it all the time.
Sends you the new message plus a link to it.

Download

I would like to write a plugin to show any kind of statistics (well, not any, but my fellow admins think about new crazy stuff every day).

I would love to incorporate this as a plugin (and share it of course) because I love the simplicity of design but it might be necessary to extend the database for some functions.

So, will I write a mod?
Or a plugin?
Or both? (Write a mod for the database logging and a plugin for the stat output?)

Maybe this is a dumb question but the plugin doc I found wasn't clear about it.....
And being new to punBB (great code by the way smile ) I don't want to mess around with structures that are convenient for everybody.