Search options

Hi all,

I'm very new to PHP coding (more used to JSP) and I wanted to check something with you all before I go and break something!!

I've noticed that this extension doesn't display the panels on the right-hand side for all the main Forum pages, even if the "Display on all pages" option is selected.  After checking through the code I believe I have found the reason:

In the "extensions\portal_by_daris\panels.php" file on Line 31 there is an "if / continue" loop.

if ($left_width == 0 && $location == 0 || $right_width == 0 && $location == 3 || FORUM_PAGE == 'pages' && $location == 3 || $forum_config['o_portal_panels_all_pages'] == 1 && $location == 3 && !in_array(FORUM_PAGE, array('news', 'pages')))
                continue;

It appears to be breaking out of the loop when the location = 3 (i.e. the right hand side) when in the main forum.

Can anyone confirm that if I remove the following bits then it won't cause loads of problems, security issues, etc?

|| FORUM_PAGE == 'pages' && $location == 3 || $forum_config['o_portal_panels_all_pages'] == 1 && $location == 3 && !in_array(FORUM_PAGE, array('news', 'pages'))

So basically Line 31 would now read:

if ($left_width == 0 && $location == 0 || $right_width == 0 && $location == 3)
                continue;

Thanks!!