Good point.
Thanks for the great work!
1 2012-01-11 20:33
Re: [Extension] Image Assistant (quadric_image_assistant) (64 replies, posted in PunBB 1.4 additions)
2 2012-01-11 16:25
Re: [Extension] Image Assistant (quadric_image_assistant) (64 replies, posted in PunBB 1.4 additions)
Great!
Because the * is greedy, only the last /t/ will be detected and /(.*)\/t(.*)/ worked. The first (.*) is "hungry"
3 2012-01-10 12:48
Re: [Extension] Image Assistant (quadric_image_assistant) (64 replies, posted in PunBB 1.4 additions)
I had some "issues" with this extension on ".net"-domains.
For some weired reasons, there are some replacements for "t/" on the URL (i know to change between the thumbnails an the original). This is fatal if _all_occurences of "t/" will be removed, especially if the URL looks like this:
https://host.net/test/img/t/hash.jpg
To fix this, you have to edit two files. Here is the diff:
diff -r quadric_image_assistant.orig/assets/uploader.js quadric_image_assistant/assets/uploader.js
12,13c12,13
< var path = $(this).parent().find('img').attr("src").replace('t/', '');
< PUNBB.pun_bbcode.insert_text('[url=' + path + ']' + title, '[/url]');
---
> var path = $(this).parent().find('img').attr("src").match(/(.*)\/t(.*)/);
> PUNBB.pun_bbcode.insert_text('[url=' + path[1]+path[2] + ']' + title, '[/url]');
122c122
< });
\ No newline at end of file
---
> });
diff -r quadric_image_assistant.orig/manifest.xml quadric_image_assistant/manifest.xml
240a241
> $url = preg_replace("/(.*)\/t(.*)/", "$1$2", $url);
247c248
< '<span class="postimg"><a href="'.str_replace('t/','',$url).'" class="thumb"'.$rel.'>',
---
> '<span class="postimg"><a href="'.$url.'" class="thumb"'.$rel.'>',
299c300