1 Topic by StevenBullen (edited by StevenBullen 2008-02-08 12:23)

  • From: Herts - UK
  • Registered: 2005-09-11
  • Posts: 842

Topic: Switch on query build true/false

Might be a silly request.

If you have this code...

    ($hook = get_hook('in_qr_get_new_topics')) ? eval($hook) : null; 
    $result = $db->query_build($query, true) or error(__FILE__, __LINE__);

How do I change true to false with the previous hook?
any chance of making this into a switch for the query builder?

EDIT: or better still.. should I NOT be changing this to false? tongue

Me: Blog | Twitter | TwitPic Exporter

StevenBullen's Website

  • Smartys
  • Former PunBB Developer
  • Offline
  • Registered: 2004-04-30
  • Posts: 7,844

Re: Switch on query build true/false

Could you give me an example of why you would change an unbuffered query to a buffered query?

  • From: Herts - UK
  • Registered: 2005-09-11
  • Posts: 842

Re: Switch on query build true/false

Ok let me try something and I will come back to you on that one.

Me: Blog | Twitter | TwitPic Exporter

StevenBullen's Website

  • From: 127.0.0.1
  • Registered: 2001-11-02
  • Posts: 9,167

Re: Switch on query build true/false

I added support for unbuffered queries, but to be completely honest, I'm uncertain how much of an optimization it is. In theory, it should decrease memory consumption by not buffering the complete query result before returning, but I'm really not sure how much it helps. The only really big result set we handle is for the main topic query. Moving it into the query builder makes sense.

"Programming is like sex: one mistake and you have to support it for the rest of your life."

Rickard's Website