Nice mod. I intalled it on my forums. However, I found a couple of bugs.
Around here (I'd give a line number but mine are out of sync because I had to make it play nice with the invitations mod):
// find the users who have been tagged with it
You need to insert the DB prefix in the query like so:
FROM ". EXPERTISE_LINKS_TABLE ." l, ".$db->prefix."users u
As you do around here:
// get current tagging users data for this user, if any
Replace query with:
$sql = "SELECT DISTINCT u.id, u.username FROM ".$db->prefix."users u, ". EXPERTISE_LINKS_TABLE ." l
Otherwise, this pretty much doesn't work if you use a DB prefix for your forum.
I'm not sure why, but in the transfer screen after adding a tag there is the following error:
Warning: Invalid argument supplied for foreach() in..... .......on line 675
Also for anyone with Tobi's invitations mod, edit expertise.php:
Find:
define('PUN_ROOT', './');
require PUN_ROOT.'include/common.php';
require PUN_ROOT.'expertise_include.php';
require PUN_ROOT.'lang/'.$pun_user['language'].'/expertise_lang.php';
require PUN_ROOT.'lang/'.$pun_user['language'].'/profile.php';
After, add:
require PUN_ROOT.'lang/'.$pun_user['language'].'/invitation.php';
Also, some suggestions:
- Make already confirmed tags viewable in the profile, then have a link just to add them
- Let guests view confirmed tags
Like you said in the notes:
- Some kind of notification when you have new tags waiting
- Administrator button to remove unused tags from the database
And some picky OCD things:
- Move expertise_include.php to /include
- Rename expertise_lang.php to just expertise.php
(Those don't really matter but they bug me)
Otherwise, great mod, thanks for making it. It looks like you put a lot of effort into it.
Looking for a certain modification for your forum? Please
take a look here before posting.
