[ Closed ] PunBB 1.2.16 (Page 3 of 3)

Maybe I'm wrong but I ain't got the lines shown in previous posts which need to be modify for security,
When I compare the updated file include /functions.php with the one I got from 1.2.15 there's this differences

old :

// Update posts, topics, last_post, last_post_id and last_poster for a forum (redirect topics are not included)

new :

// Update posts, topics, last_post, last_post_id and last_poster for a forum

old :

    $result = $db->query('SELECT COUNT(id), SUM(num_replies) FROM '.$db->prefix.'topics WHERE moved_to IS NULL AND forum_id='.$forum_id) or error('Unable to fetch forum topic count', __FILE__, __LINE__, $db->error());

new :

    $result = $db->query('SELECT COUNT(id), SUM(num_replies) FROM '.$db->prefix.'topics WHERE forum_id='.$forum_id) or error('Unable to fetch forum topic count', __FILE__, __LINE__, $db->error());

old :

        $db->query('UPDATE '.$db->prefix.'forums SET num_topics=0, num_posts=0, last_post=NULL, last_post_id=NULL, last_poster=NULL WHERE id='.$forum_id) or error('Unable to update last_post/last_post_id/last_poster', __FILE__, __LINE__, $db->error());

new :

        $db->query('UPDATE '.$db->prefix.'forums SET num_topics='.$num_topics.', num_posts='.$num_posts.', last_post=NULL, last_post_id=NULL, last_poster=NULL WHERE id='.$forum_id) or error('Unable to update last_post/last_post_id/last_poster', __FILE__, __LINE__, $db->error());

old :

    if ($destination_url == '')
        $destination_url = 'index.php';

new :

    // Prefix with o_base_url (unless it's there already)
    if (strpos($destination_url, $pun_config['o_base_url']) !== 0)
        $destination_url = $pun_config['o_base_url'].'/'.$destination_url;

    // Do a little spring cleaning
    $destination_url = preg_replace('/([\r\n])|(%0[ad])|(;[\s]*data[\s]*:)/i', '', $destination_url);

old :

    if ($register_globals === "" || $register_globals === "0" || strtolower($register_globals === "off"))

new :

    if ($register_globals === "" || $register_globals === "0" || strtolower($register_globals) === "off")

Do I need to do the changes ? if yes , is it enough or I need to do something else like it's indicated in "Instructions on upgrading PunBB using patch files"

Dax701: I didn't go through all the changes in your post, but those look like exactly the lines you're supposed to modify
gil: Yes. But the version number being slightly off doesn't matter all that much.

Run the update script in the extras folder.

Hi Smartys,

I have only replaced the two files manually. Should I run the update script to update the version number in the admin area?

Regards
Tom

Should I upgrade each and every time there's a new version? Or can I just upgrade from 1.2.13 to 1.2.16?

Stupid question but I can't find the answer..

Also Smarty, I sent you a form email 2 weeks ago, you might not have received it as I read you had issues receiving form emails..

Why is that?

mmhh.. Whenever I submit a post using 1.2.16 I'm being redirected to the Index, while in 1.2.15 I was being redirected to viewtopic.php?pid=XXXX (the post I just made) (*edit: strange that this doesn't happen here though)

viewtopic.php?pid=XXXX is a better option in my opinion because when redirected to the Index the Mark topics as read 1.1.3 mod will unfortunately display a New Message Icon in the section I just wrote in..

Since I can't tell if the New Message Icon is there because of my own post I just wrote or another one made by another user while I was wrtiting my post, I think this might become annoying..

What line should I change in order to go back to viewtopic.php?pid=XXXX whenever I post a message?

Dr.Jeckyl: sendmail is being silly
Vanslyde: You should be redirected to viewtopic.php, that's how the code works. Post your code in Troubleshooting
Vida: 9 < 16

That index.php line shouldn't be there.

How do you create a new post?