1 Topic by andrenth (edited by andrenth 2005-04-02 22:09)

  • Registered: 2005-04-02
  • Posts: 2

Topic: bbcode handling bug

Hello. There's a bug related to unclosed bbcode tags. If I post the following (I added spaces to the tags can be visualized):

[ code ][ code ][ /code ]

I get the error below:

Notice: Undefined offset: 1 in <path>/include/parser.php on line 242
Call Stack
#    Function    Location
1    {main}()    /home/vusers/forums.bsdnexus.com/htdocs/viewtopic.php:0
2    parse_message()    /home/vusers/forums.bsdnexus.com/htdocs/viewtopic.php:298
3    split_text()    /home/vusers/forums.bsdnexus.com/htdocs/include/parser.php:383

This is on 1.2.4.

Regards,
Andre

  • Connorhd
  • Connorhd
  • Former PunBB Developer
  • Offline
  • From: Leeds, UK
  • Registered: 2004-06-13
  • Posts: 4,195

Re: bbcode handling bug

[code]
works fine for me

FluxBB.
Connorhd.co.uk.

Connorhd's Website

3 Reply by Ataxy

  • Ataxy
  • Senior Member
  • Offline
  • From: Montreal,Canada
  • Registered: 2004-06-07
  • Posts: 287

Re: bbcode handling bug

humm tryed it in my forum to and it work ok

Ataxy's Website

4 Reply by andrenth (edited by andrenth 2005-04-02 22:57)

  • Registered: 2005-04-02
  • Posts: 2

Re: bbcode handling bug

[code]
hmm weird... here's a screenshot so that you guys don't thing i'm crazy tongue

http://sneakymustard.com/images/punbb.png

Are you also using 1.2.4?

5 Reply by Paul

  • Paul
  • Senior Member
  • Offline
  • From: Wales, UK.
  • Registered: 2003-08-13
  • Posts: 3,089

Re: bbcode handling bug

I get this in 1.2.4 and 1.3dev
Notice: Undefined offset: 1 in f:\wamp\www\pun12\include\parser.php on line 242

If I try it with quote tags instead then I get an error message about invalid bbcode which is what should happen.

  • Connorhd
  • Connorhd
  • Former PunBB Developer
  • Offline
  • From: Leeds, UK
  • Registered: 2004-06-13
  • Posts: 4,195

Re: bbcode handling bug

yeh even though it appears to work here it shouldn't wink

FluxBB.
Connorhd.co.uk.

Connorhd's Website

  • Registered: 2004-08-16
  • Posts: 577

Re: bbcode handling bug

http://forums.indocron.net/viewtopic.php?id=343

Its happens to me on mine..

Indocron
$theQuestion = (2*b) || !(2*b);
  • From: 127.0.0.1
  • Registered: 2001-11-02
  • Posts: 9,167

Re: bbcode handling bug

I will look into it smile

"Programming is like sex: one mistake and you have to support it for the rest of your life."

Rickard's Website

  • From: 127.0.0.1
  • Registered: 2001-11-02
  • Posts: 9,167

Re: bbcode handling bug

I think this should fix it:

http://dev.punbb.org/changeset/161

With this code change, PunBB won't allow you to post a code block containing a new code tag. It's the easiest solution to the problem. Much of PunBB's BBCode system relies on the fact that whatever is in the database is valid BBCode.

"Programming is like sex: one mistake and you have to support it for the rest of your life."

Rickard's Website

10 Reply by Dexus

  • Dexus
  • Senior Member
  • Offline
  • Registered: 2005-03-30
  • Posts: 154

Re: bbcode handling bug

        if (isset($temp[1])) $outside[] = $temp[1];

instead of 

        $outside[] = $temp[1];

at line 242 of parser.php helped me.

  • From: 127.0.0.1
  • Registered: 2001-11-02
  • Posts: 9,167

Re: bbcode handling bug

That was the first thing I tried yesterday, but I ran into some problems. I'm not sure what the problem was, but I believe that means it will simply strip out the contents of the code box.

"Programming is like sex: one mistake and you have to support it for the rest of your life."

Rickard's Website