26

Re: Poll for PunBB

download on ftp get url & i help u

27 (edited by chacmool 2003-09-28 18:00)

Re: Poll for PunBB

My work here is done! (hopefully wink)

I think it'll work fine now. If it's not, please tell me and I'll fix it asap.

Download: PunPoll.v1.0.zip

Re: Poll for PunBB

chacmool: Nice! Could you upload it to PunRes?

"Programming is like sex: one mistake and you have to support it for the rest of your life."

29

Re: Poll for PunBB

It seems it doesn't work with mozilla firebird / netscape browser but it worked fine with internet explorer. It doesn't update the page after you have marked "new poll". It's a smart feature with the box hope you can fix it because it isn't as nice if you always shows the poll when posting.

S C U B A

Re: Poll for PunBB

Kennel wrote:
chacmool: Nice! Could you upload it to PunRes?

Sure, but the page seems to be down at the moment...

scuba wrote:
It seems it doesn't work with mozilla firebird / netscape browser but it worked fine with internet explorer. It doesn't update the page after you have marked "new poll". It's a smart feature with the box hope you can fix it because it isn't as nice if you always shows the poll when posting.

Ok, I'll look at it.

31

Re: Poll for PunBB

to chacmool

Nice!!!
Thaks

smile smile smile smile

32

Re: Poll for PunBB

chacmool wrote:

Kennel wrote:
chacmool: Nice! Could you upload it to PunRes?

Sure, but the page seems to be down at the moment...

scuba wrote:
It seems it doesn't work with mozilla firebird / netscape browser but it worked fine with internet explorer. It doesn't update the page after you have marked "new poll". It's a smart feature with the box hope you can fix it because it isn't as nice if you always shows the poll when posting.

Ok, I'll look at it.

I think it is a fault by mozilla but check it out anyway going to post on the mozilla forum and see what they say. Maybe they can fix it so the browser works as ie does ...

S C U B A

33

Re: Poll for PunBB

Tried it and it works great (on my IE environment)! Great work - 1000+ thanks!
Just a thought about a feature I might miss or which isn't included:

I would suggest to add an option to "admin_permissions.php" which defines if "Guests" and/or "Users" are allowed to create polls. While I would allow it Users I would prefer if not registered users can't create a poll; so registering is just another benefit.

What do you think?

Cheers ~ Arne

Re: Poll for PunBB

Arne wrote:

Tried it and it works great (on my IE environment)! Great work - 1000+ thanks!
Just a thought about a feature I might miss or which isn't included:

I would suggest to add an option to "admin_permissions.php" which defines if "Guests" and/or "Users" are allowed to create polls. While I would allow it Users I would prefer if not registered users can't create a poll; so registering is just another benefit.

What do you think?

I'll second that.

"Programming is like sex: one mistake and you have to support it for the rest of your life."

Re: Poll for PunBB

True, all true. I'll fix it tomorrow smile

Re: Poll for PunBB

Arne wrote:Tried it and it works great (on my IE environment)! Great work - 1000+ thanks!
Just a thought about a feature I might miss or which isn't included:

I would suggest to add an option to "admin_permissions.php" which defines if "Guests" and/or "Users" are allowed to create polls. While I would allow it Users I would prefer if not registered users can't create a poll; so registering is just another benefit.

What do you think?

Done! Added a "Guests may post poll"-option to the admin-permissions page. Made an update-file for v.1.0 to (which hopfully works fine smile)

37

Re: Poll for PunBB

url please smile

Re: Poll for PunBB

Kox wrote:

url please smile

Look at the first post on the first page smile

39

Re: Poll for PunBB

Hi all

Had some problems with the punpoll mod; apparently the EOF tags in the bit of code added to the 'viewtopic.php' page (lines 240 - 260 with the mod) aren't that well supported, cause they screwed things up for me (tested w/Safari 2.0 on MacOSX and IE 5 on a PC, result is a blank page when trying to view posts), so I replaced the offending lines with a different way of coding the table inside the php bit, and now it works fine (great job on the whole thing, by the way!).

Here's my fix, for anyone who might have the same problem.

                        echo "
   
                    <tr>
                        <td align='right'>" .$answers[$i] . " </td>
                        <td width='50%' align='left' nowrap>
                             <img src='img/poll/end.png' height='9' alt=''><img src='img/poll/" .$image . ".png' height='9' width='" .$proc . "%' alt=''><img src='img/poll/end.png' height='9' alt=''>
                        </td>
                        <td align='right' style='width: 30px' nowrap>" .$votes[$i] . "</td>
                        <td align='right' style='width: 40px' nowrap>" .$sproc . "%</td>
                        <td width='20px'></td>
                    </tr>";
                       
                        }else{
                        echo "
   
                    <tr>
                        <td style='width: 20px;' align='right'>
                            <input type='radio' name='option' value='" .$i . "'>
                        </td>
                        <td>
                            " .$answers[$i] . "
                        </td>
                    </tr>";

Re: Poll for PunBB

Ahh, I should have mentioned that... the "EOF;"-text must be on its own row with no tabs och spaces before.

Or was it another problem?

Re: Poll for PunBB

Have you figured out a fix for the mozilla problem (page not updating?) I downloaded 1.1 and addded it, but it still doesn't work sad
I select post new topic. Fill out title and post. Check post new poll. nothing. hit submit. Get error - must fill in poll. go back. refresh - nothing. uncheck post new poll - hit submit. Then edit post...NOW I can add the poll.

Also, multiple choice doesn't work at all...

Re: Poll for PunBB

notnamed wrote:Have you figured out a fix for the mozilla problem (page not updating?) I downloaded 1.1 and addded it, but it still doesn't work sad

No, I've not looked at it yet...

notnamed wrote:Also, multiple choice doesn't work at all...

Can you explain more what happens? Is this only in mozilla?

43

Re: Poll for PunBB

chacmool wrote:

Ahh, I should have mentioned that... the "EOF;"-text must be on its own row with no tabs och spaces before.

Or was it another problem?

Well, I'd never encountered EOF tags before (i'm a bit of a newbie - insert massive understatement alert here - so it really doesn't mean anything) which is why I was unsure how to deal with them, but I cut/pasted the code directly from the readme, and if I'm not mistaken *paused, checking...* yep, it was as you said; on its own row, no tabs or spaces before it.

When the bugginess occurred I just inactivated the whole section of code by commenting it out, so the page worked again (by that I mean, no blank php-error-induced white screen, but an empty table of course) and reactivated it bit by bit until I'd isolated the problem to the part of the table that used the EOF tags. Like I said, I'm a newbie (and I had impatient users complaining that "the forum didn't work"; not that they'd actually go and describe the problem in any kind of detail, like, what they'd been trying to do at the time, lol) so I didn't really research the problem and just went ahead with the fix (of sorts) I posted.

If you want I could retry it with the original code on a copy and send it to you, maybe it could help you find out what's wrong (in case it's not just me being unable to cut/paste a snippet of code correctly, which is a possibility I haven't ruled out yet, lol).

Otherwise, congrats on a great mod:)

Re: Poll for PunBB

decided to register, after all... want to be sure to stay tuned on any new punBB developments;)

Re: Poll for PunBB

Can you explain more what happens? Is this only in mozilla?

Both IE6 and Mozilla have radio buttons instead of checkboxes for multiple vote and single choice polls.

46 (edited by chacmool 2003-10-08 12:14)

Re: Poll for PunBB

iGollum:
Ok, I've updated v1.1 so it's not using EOF's anymore. Does the multiple-choice works for you?

notnamed:
Do you have the forum up and running? I've not seen this problem myself...

47 (edited by iGollum 2003-10-12 18:29)

Re: Poll for PunBB

chacmool wrote:
Ok, I've updated v1.1 so it's not using EOF's anymore. Does the multiple-choice works for you?

The updated v1.1 works great, thanks! Except for the multiple-choice, which I hadn't tried before; the option to give multiple votes is there when I create the poll, but the user can't actually choose several answers.

Oh, there is another slight issue I thought I might mention: when quote marks are used in the poll question or answers, an error is returned (can't save poll info). Of course using backslashes to escape the quote marks solves the problem, but if the users don't know that they won't understand why it's not working... Wouldn't it be good to have the form automatically perform an addslashes function on the data when it's posted?

Re: Poll for PunBB

I'll look at the multipoll-thing... install the mod myself from scratch or something. I've fixed the quote-mark-issue now, thanx alot for telling me!

49 (edited by chacmool 2003-10-12 20:20)

Re: Poll for PunBB

Hmm, still some problems regarding quote-marks in the answers though. Can't figure out how to solve it when using serialize/un serialize sad ... suggestions?

Re: Poll for PunBB

chacmool: Sorry I disappeared on IRC.

Are you running addslashes() on the serialized string before you insert it into the database?

"Programming is like sex: one mistake and you have to support it for the rest of your life."