1 Topic by foxmask (edited by foxmask 2007-01-19 15:09)

  • Registered: 2005-11-30
  • Posts: 165

Topic: PUN_UNVERIFIED in admin_users.php

it will be nice to be able to have the possibility to only query unverified users from the admin_users.php script.

for example
after

                                        <select name="user_group" tabindex="22">
                                                <option value="all" selected="selected">All groups</option>
<?php

    $result = $db->query('SELECT g_id, g_title FROM '.$db->prefix.'groups WHERE g_id!='.PUN_GUEST.' ORDER BY g_title') or error('Unable to fetch user group list', __FILE__, __LINE__, $db->error());

    while ($cur_group = $db->fetch_assoc($result))
        echo "\t\t\t\t\t\t\t\t\t\t\t".'<option value="'.$cur_group['g_id'].'">'.pun_htmlspecialchars($cur_group['g_title']).'</option>'."\n";

?>

adding

<option value="<?php echo PUN_UNVERIFIED; ?>">Unverified Users</option>
http://www.foxmask.info

foxmask's Website

  • From: 127.0.0.1
  • Registered: 2001-11-02
  • Posts: 9,167

Re: PUN_UNVERIFIED in admin_users.php

Can't see a problem with this. I'll add it in 1.3.

"Programming is like sex: one mistake and you have to support it for the rest of your life."

Rickard's Website

  • Registered: 2005-11-30
  • Posts: 165

Re: PUN_UNVERIFIED in admin_users.php

nice to read it wink

http://www.foxmask.info

foxmask's Website

4 Reply by hcgtv

  • hcgtv
  • hcgtv
  • Senior Member
  • Offline
  • From: Charlotte, NC
  • Registered: 2004-06-25
  • Posts: 1,991

Re: PUN_UNVERIFIED in admin_users.php

Cool, I like this feature.

PHPCrossRef . TXP Make . TXP Themes . TXP Tags . TXP Planet . We Love TXP

hcgtv's Website

  • Registered: 2006-06-05
  • Posts: 410

Re: PUN_UNVERIFIED in admin_users.php

smile http://dev.punbb.org/changeset/783

Speaking of unverified users, could they be listed as that (by title) on userlist.php?

  • From: 127.0.0.1
  • Registered: 2001-11-02
  • Posts: 9,167

Re: PUN_UNVERIFIED in admin_users.php

guardian34 wrote:

Speaking of unverified users, could they be listed as that (by title) on userlist.php?

The reason they are not is that I think that's a little bit too much information to give to users.

"Programming is like sex: one mistake and you have to support it for the rest of your life."

Rickard's Website

  • Registered: 2006-06-05
  • Posts: 410

Re: PUN_UNVERIFIED in admin_users.php

Well, I know where to find the right `if` statement if I want it. smile

  • Registered: 2006-01-24
  • Posts: 55

Re: PUN_UNVERIFIED in admin_users.php

Very nice idea. I made the same thing with userlist.php. smile
Regards

  • Registered: 2006-06-05
  • Posts: 410

Re: PUN_UNVERIFIED in admin_users.php

guardian34 wrote:

Well, I know where to find the right `if` statement if I want it. smile

Just in case someone doesn't know? Look at how admin_users.php currently does it:

$user_title = get_title($user_data);

// This script is a special case in that we want to display "Not verified" for non-verified users
if (($user_data['g_id'] == '' || $user_data['g_id'] == PUN_UNVERIFIED) && $user_title != $lang_common['Banned'])
    $user_title = '<span class="warntext">Not verified</span>';