7,276

(7 replies, posted in PunBB 1.2 bug reports)

You're 1 version behind according to the footer of your page wink
(No, that won't fix your problem, but you should keep upgraded)

Rather large bug with this:
I just tried restoring a backup (full, no gzip). I start getting errors with the forum_perms table. When I checked it out, I realized the problem: Rickard made both forum_id and group_id primary keys, but the backup only had forum_id set as primary_key when it was creating the table (edit: it does the same with structure as well).

Ludo wrote:
Smartys wrote:

http://diskusijos.e-vaizdas.net/
Nice removal of the copyright wink

In fact not very nice. An empty table is not nice at all. It seems like something missing.

Ludo,

It was sarcasm Ludo, not only because it wasn't there but because the table was still there without anything in it tongue

http://diskusijos.e-vaizdas.net/
Nice removal of the copyright wink

Edit: But then, you're also not running 1.2.x there either wink

7,280

(11 replies, posted in PunBB 1.2 troubleshooting)

so the file is uploaded correctly?

7,281

(16 replies, posted in PunBB 1.2 discussion)

Well, you might also think you're using old, outdated stylesheets tongue

The admin section isn't translatable.
The rest of the board is

I haven't checked the source-code, but maybe you can answer this:
does "global moderator" mean they have mod access to any forum (which I wouldn't like since I have an admin only board) or does it mean only to the forums their group is given access to?

7,284

(4 replies, posted in PunBB 1.2 bug reports)

Ah, I see where he's confused

setcookie($cookie_name, serialize(array($user_id, md5($cookie_seed.$password_hash))), $expire, $cookie_path, $cookie_domain, $cookie_secure);

$password_hash if you had SHA1 would be SHA1 and THEN would be md5 hashed with the $cookie_seed
In check_cookies

if (!isset($pun_user['id']) || md5($cookie_seed.$pun_user['password']) !== $cookie['password_hash'])

The cookie password hash is md5($cookie_seed.$password_hash)
The check is md5($cookie_seed.$pun_user['password'])
As long as the password is hashed properly in the database (connor is right in that if you have SHA1 passes and then downgrade you're screwed) the check should work

7,285

(7 replies, posted in PunBB 1.2 troubleshooting)

I checked out his site, it says he doesn't support it (I went directly to the mysqli file)

7,286

(7 replies, posted in PunBB 1.2 troubleshooting)

Talk to the people who host the site?

7,287

(7 replies, posted in PunBB 1.2 troubleshooting)

http://punbb.org/forums/viewtopic.php?id=5668

Connorhd is right wink

lol
I'm only doing this because no one else wanted to, and all mine is is a patch to the old one so it works for the new tongue
So, since yours works for 1.2 and has merging, I think I'll let you come up with the new mod and spend my vacation elsewhere tongue

Meh
I meant to change it to pun_mod
and this just gives access to admin_forums.php to mods

Mmm, isn't this easy?
You just mod admin_forums.php to work for mods: should only be a line of code

Edit: Yup, a simple mod to make it show up on the admin sidebar thing and work for mods

admin_forums.php
Find:

if ($pun_user['g_id'] > PUN_ADMIN)
    message($lang_common['No permission']);

Replace with

if ($pun_user['g_id'] > PUN_ADMIN)
    message($lang_common['No permission']);

include/common_admin.php

Find:

<?php endif; ?><?php if ($is_admin): ?>                    <li<?php if ($page == 'forums') echo ' class="isactive"'; ?>><a href="admin_forums.php">Forums</a></li>

Replace with:

<?php endif; ?>        <li<?php if ($page == 'forums') echo ' class="isactive"'; ?>><a href="admin_forums.php">Forums</a></li>

7,292

(38 replies, posted in News)

Oh, Rickard: you might want to word the announcement box a little differently. It's been the same since 1.2.2 and, frankly, if I didn't have an account and were just checking, I might miss it tongue

7,293

(1 replies, posted in PunBB 1.2 bug reports)

Doesn't work
The cause seems to be the

implode(',', array_keys($topics))

bit of the UPDATE query (array_keys is already done in array_map before, but since I've never used either I dunno if that means anything). Removing array_keys from the query makes it get the correct ids.

7,294

(38 replies, posted in News)

hdiffs are wonderful for that case tongue

7,295

(38 replies, posted in News)

Mmm, that too

7,296

(38 replies, posted in News)

Compare the files in some manner?
(I don't think there were CSS changes for this version)

Lemme check something...

Edit: It appears that if you download the "changed files only" and there's a stylesheet there, there was a change smile

7,297

(38 replies, posted in News)

The one that allowed you to set a user's password to '' or NULL, can't remember which

http://seclists.org/lists/bugtraq/2005/Feb/0499.html

A remote attacker without an account can set the password
of any user on the system to NULL, effectivley shuting
them out of the system.

Very interesting combo that made (with the other one in profile.php he posted there)

7,298

(38 replies, posted in News)

Upgrading time, goodie smile
btw Rickard: I just did some looking up on the bug tracking sites. It seems John Gumbell deserves the credit for the profile.php bug and null activation keys, he found it in 1.2.1 wink

Don't forget to fix the Jabber/(I guess email too) XSS thing wink

7,300

(19 replies, posted in PunBB 1.2 troubleshooting)

lol, you replace the whole $pun_config bit (it shouldn't be there) wink