7,376

(6 replies, posted in PunBB 1.2 bug reports)

I just realized something: if the cache folder isn't chmodded correctly, by looking at the quickjump cache I can find out about the existance of secret forums: not necessarily all that bad, since all I get is the names and ids, but it still shouldn't happen smile
Of course, this is all fixed by chmodding the folder correctly, but for a lot of people that could pose a problem.

I had to take my own, home-made version of this mod and throw it out: I had an admin only forum that I realized mods could read from if they were bored enough to go through all possible ids using edit or delete. tongue

I accidentally had referrer logging disabled when I went to admin_options.php to tweak a few things.
When I submitted the form, I got this
Notice: Undefined index: HTTP_REFERER in [place]/admin_options.php on line 41

Nope, I checked the code and there just isn't a check (other then for guests)

I disabled subscriptions on my forum. Just as a test, I checked what would happen if I subscribed. Surprisingly, it subscribed me. And more surprisingly, when I checked the code in post.php, it appears as if I would actually be subscribed.

Just remove all other styles (or keep them in another folder, in case you change your mind)

Erm, someone enable debug and remove the @ so we get better errors then this?

A split topic mod was made, just not for 1.2.x yet

lol, I don't intend on using it, just on testing it smile

You still didn't change install_mod.php to accept 1.2.2

Oh, and I just downloaded it: it looks like the exact same thing to me

Yup, I got that too: and I couldn't upload (but that's unrelated) smile

Change
<?php echo $lang_uploads['Uploader']; ?>
to
<?php echo 'Uploader'; ?>

Take a look at erissiva's code: the replacements that were done are correct to fix it

*oh yes, go 300th post! big_smile*

7,387

(2 replies, posted in PunBB 1.2 bug reports)

1. Yes, that's how it should work
2. You can prevent it by going to Admin -> User Groups and changing the Members usergroup setting for Delete topics from on to off

7,388

(3 replies, posted in PunBB 1.2 troubleshooting)

Well, that would work fine.
But if you're using a 1.2.x version, there's an admin plugin for that

http://punbb.org/forums/viewtopic.php?id=5936

7,389

(25 replies, posted in PunBB 1.2 troubleshooting)

Jonex: Converters are made because people want to leave a forum, when there's a demand for them tongue

It's possible to make a much more crude mod then this which does what you want.

7,391

(37 replies, posted in News)

No problem Rickard, always a pleasure to help out smile

7,392

(3 replies, posted in Feature requests)

Yes

lol, that's what the mod does tongue

Looks perfectly fine for me...

7,395

(3 replies, posted in Feature requests)

- Moving
- Edit the first post

Well, to make it a "global topic" plugin would require PunBB to be modded: there's no way for there to be a global topic currently tongue
This way, it's only an admin plugin

OK, this is HUGELY abusable with SQL injections. :-/
Until this is fixed, I would suggest anyone who has it installed on a publicly accessable site pull it down temporarily.


SQL injection basically means that it is possible to manipulate one or more variables in a way it wasn't intended, usually for malicious purposes. It is usually possible due to a lack of checking.

Example (lets say we're viewing stats on a user):

select * from user where id = $_GET['id']

I don't check that $_GET['id'] is a number (or do a simple intval()). That means that I could do this

select * from table where id = 0 union select password,password,(etc, however many columns there are) from table where id = [person I want to hack's ID]

If the passwords aren't hashed, I can just login as normal. If they are, the hashes can still be exploited in certain situations. And I could do this for any variable on any table.


However, it's easily fixed in this case. Where-ever you are taking in data from the outside that should be a number, make sure that it is, using something like this:
$var = intval($_GET['var'])
where var is the variable name.

7,398

(17 replies, posted in PunBB 1.2 troubleshooting)

No problem smile

7,399

(17 replies, posted in PunBB 1.2 troubleshooting)

hehe, syntax highlighting is a great tool for debugging smile

7,400

(17 replies, posted in PunBB 1.2 troubleshooting)

Yeah, it looks good.
I just took a look at what you're talking about. The fix is:

Change line 90 to

        $entities_decimal     = array(" ","¡","¢","£","¤","¥","¦","§","¨","©","ª","«","¬","­","®","¯","°","±","²","³","´","µ","¶","·","¸","¹","º","»","¼","½","¾","¿","À","Á","Â","Ã","Ä","Å","Æ","Ç","È","É"," ","Ë","Ì","Í","Î","Ï","Ð","Ñ","Ò","Ó","Ô","Õ","Ö","×","Ø","Ù","Ú","Û","Ü","Ý","Þ","ß","à","á","â","ã","ä","å","æ","ç","è","é","ê","ë","ì","í","î","ï","ð","ñ","ò","ó","ô","õ","ö","÷","ø","ù","ú","û","ü","ý","þ","ÿ","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","\"","&","<",">","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","?","'");

The guy didn't escape a " properly: that line has it fixed