The current character set is a text field. It's something you set. Change it to UTF-8 and then run it (with the define removed).

827

(119 replies, posted in PunBB 1.3 extensions)

I still see short tags, it still doesn't support MySQL, I still see what looks to be some unsanitized output that can be used for XSS, and I see some coding standard stuff that should be changed. I still see some duplicated hooks (very bad!!!)
ie:

while (stuff) {
}

should be

while (stuff)
{
}

But very, very, very good job overall tongue

828

(2 replies, posted in PunBB 1.3 troubleshooting)

Done

You need to remove the define() line entirely, changing the value to 0 isn't enough.
And when you forced the conversion, you said it was converting from UTF-8?

830

(1 replies, posted in PunBB 1.3 troubleshooting)

That's actually intentional: we didn't remove the use of SEF URLs from the admin pages, we made the URLs for admin pages, no matter the scheme, be the actual PHP filenames.
However, there is a bug with those URLs, I'll fix it now smile

831

(7 replies, posted in PunBB 1.3 troubleshooting)

Well, I thought I did a pretty good job of explaining the duplicates above, but I'll try again. wink
Notice where they're used. They're both within a switch statement, in the two different cases, right before the query is run. Normally, we would put the hook outside of the switch statement and then call $db->query_build on the result.
However, in this case, to get around a race condition in our PostgreSQL code that led to duplicate posts, we use $db->query for PostgreSQL and $db->query_build for MySQL(i)/SQLite. So, we can't just put the hook outside and call a function: we don't know what function to call without another switch statement.
In this case, the duplication is almost irrelevant: if we were to put the hook outside and add an extra switch statement, people would have to deal with the code in the exact same way they would now. It would just look uglier from the perspective of the PunBB core code.

As for the subscription idea, I see nothing wrong with it (and it's not difficult, we already store the previous URL), but I want to see what other people think.

832

(7 replies, posted in PunBB 1.3 troubleshooting)

fn_qr_add_online_user/fn_qr_add_online_guest_user are actually meant to be duplicates. For most queries, we would simply use one hook at the end (before executing the query) and be done with it. However, in this case, we use a different function call depending upon the dblayer. So, we can't so easily put one hook just before the execution of the query (we're trying to avoid using another switch statement to determine which function to call).
But thank you, I've corrected the other duplicates. smile

833

(2 replies, posted in PunBB 1.3 troubleshooting)

http://punbb.org/forums/viewtopic.php?id=18442

834

(69 replies, posted in News)

No.
You need to make sure your logout links are changed the way the ones in include/functions.php are.

Aha!
My guess: you weren't using SET NAMES UTF8. So the UTF-8 characters were converted by MySQL from latin1 to UTF-8 to be put in the database. When outputting them, it "unencoded" them. Now, since SET NAMES UTF8 is called, the database isn't unencoding the text.
The simplest (but incorrect) way to fix it is to add the correct constant to disable calling SET NAMES (I don't remember it off the top of my head).
Another way that *might* work is to modify db_update.php so it calls SET NAMES (we currently don't if you're upgrading) and ask the script to convert from UTF-8. I don't know exactly how that will work tongue

We need more details then that. For example:
A. What was the charset used to insert that data into the database/present it in 1.2.
B. What was the collation of the database tables in 1.2.
C. Did you choose to have the data converted to UTF-8? If so, what collation did you give to convert from?

If you're using the mysql dblayer, make sure you're using the latest copy from SVN.

837

(69 replies, posted in News)

Did you also update include/functions.php? And are you logging out using the links generated by the generate_navlinks function? You can tell by looking at the URL it links to: if it has "csrf_token=" and then some letters/numbers in it, that link should work.

838

(6 replies, posted in PunBB 1.3 troubleshooting)

And that's a good reason, so reverted tongue

839

(1 replies, posted in PunBB 1.3 troubleshooting)

They would still be on the userlist. And they're still the newest registered (created) account.
It could be done as an extension though, smile

840

(6 replies, posted in PunBB 1.3 troubleshooting)

Fixed

841

(8 replies, posted in PunBB 1.2 troubleshooting)

Just talk to your host, this should be a common problem for them. wink

So, replace all the logout links with the proper logout links from a fresh copy of include/functions.php

843

(7 replies, posted in PunBB 1.2 troubleshooting)

Set the default style to be the same as the style you use when logged in?

844

(119 replies, posted in PunBB 1.3 extensions)

Exactly smile
And then you would have index.php and index.php?forum (which could be rewritten using the SEF URLs to anything you want).

Yes

If you're using 1.2.17, then you need to make sure you're using the new logout link, which has a CSRF token.

khalido: To answer the question in the topic, none at this point wink
Once 1.3 is out of beta you're likely to get a better answer. I do expect Dokuwiki would be a good option though.

848

(8 replies, posted in PunBB 1.2 troubleshooting)

Oh, right, I got confused there, sorry.
http://dev.mysql.com/doc/refman/5.0/en/old-client.html
The fix for you (since there's no MySQLi extension) is to set the password for your MySQL user using the OLD_PASSWORD function. If that doesn't mean anything to you, talk to your host and give them the error and ask them how you would set the password to use the old scheme. wink

849

(119 replies, posted in PunBB 1.3 extensions)

Bu how in other method set portal page as index page?

Hook into index.php, in_start.

Did this fix problem?

No (at least not optimally). Just use the basename function on $_POST['file'] when storing it as $file (I hope I'm remembering those variable names right, I'm doing this off the top of my head).

I don't know what is difference with MySQL and others

I was specifically talking about database creation code. Take a look at install.php for an idea of the differences.

850

(8 replies, posted in PunBB 1.2 troubleshooting)

beyedj99: Don't use the MySQL Improved option then, just use the regular MySQL option (for the database type).