926

(16 replies, posted in PunBB 1.3 troubleshooting)

Interesting point. We might want to change that array like we did with the calls to add_user, etc.

Mpok: A number of problems come from the fact that the check greatly reduces the number of valid redirects. A redirect with an absolute URL (eg: http://example.com/path/to/punbb/file.php) or with a relative URL (eg: file.php) work. Anything else no longer does. We're actively looking at ways to increase the flexibility of the URLs accepted while keeping forums secure.
Documenting the change wouldn't really have done much good, since some of the URLs previously redirected to are now impossible to redirect to. There are also too many permutations of code to generate a redirect URL for us to predict which a user is using and how to correct it. You're right that we should have drawn more attention to the change though.
And in any case, there is no excuse for making a change that was explicitly warned against earlier in this topic. wink

The way kierownik suggested is the way I would suggest extension authors allow for localization.

Mpok: Then you point out where it's being used hardcoded so we can make sure it uses the language files, you don't unilaterally decide to edit the hardcoded text. Otherwise, your changes only benefit you and not the wider community. They can also potentially cause problems down the line, as you see here. wink
That doesn't change the fact that you shouldn't be translating strings in the database though. And even if we tweaked db_update.php to convert the guest user (which requires changing one line, not adding eight), that wouldn't change the fact that the text shouldn't be converted in the first place.

930

(151 replies, posted in PunBB 1.3 extensions)

qubertman wrote:

footer.php (line 103)
- Hook to retrieve to modify the query.

Added

931

(10 replies, posted in PunBB 1.3 troubleshooting)

Yes, we're not planning on releasing a buggy final product tongue

932

(10 replies, posted in PunBB 1.3 troubleshooting)

SuperMAG wrote:

its been few days since the last build ... i wonder if they finished the bugs ... if they did then there are still 2 bugs i know which are not fixed ...

You just answered your own question then, didn't you wink

I will say this again: making those changes exposes your site to security risks. Do not do that.

You as the extension author? You should probably be able to use the message function within the install code.

There's code lying around somewhere that changes the check so it only looks for http: as opposed to the base URL, which works in most cases (obviously not for redirecting to https sites). I don't know it offhand.

Moved to Modifications

937

(4 replies, posted in PunBB 1.3 troubleshooting)

It's actually not a big modification at all wink
And the hiding would involve actually not executing the code.
As you pointed out though, $pun_url would have to be updated. That would be the only change.

938

(2 replies, posted in PunBB 1.2 discussion)

1. Before including common.php. It should be a relative path to the forum files
2. the current user ID? $pun_user['id']

939

(151 replies, posted in PunBB 1.3 extensions)

Those are examples of modifications that you want ported to extensions, not hooks.

940

(151 replies, posted in PunBB 1.3 extensions)

No problem, I'm glad the hook placements are working out smile

yemgi wrote:

Well, in French, Guest is called Invité so you need to change the username when translating

The fact that PunBB.fr has chosen to go overboard with their translation by changing actual strings in the database does not mean that we need to take that into account. You are not supposed to be changing that. wink

942

(4 replies, posted in PunBB 1.3 troubleshooting)

Well, you can do it one of two ways: you can hook into the start of index.php and put your own content is there and tell it not to show the other content unless, say, $_GET['view'] == 'forum'
The alternative is to do the same thing but always hide the other content and have your own forum.php in the extensions folder. That would be the less desirable solution.

The Guest user should not need to be converted because nobody should have been touching that account wink

Moved to the beta talk.
There isn't one as of yet.

You're putting a query within the loop? I assume that's the problem, since it's an unbuffered query.
Moved to Integration.

946

(151 replies, posted in PunBB 1.3 extensions)

gautam.madeshia: It would be great if you could look at the actual code before requesting hooks. I just glanced through your post, but I think most of the hooks you suggest have already been put in.

You have to be more specific about what you're trying to do and what you want to know or I can't help you smile

StevenBullen wrote:

Maybe this (general idea of auto update) could work both ways... so that via punres you could have a page and check one of your domains and see all the mods running and what version.

This would make more sense if you run 13 different punbb installs. I currently run about 11. lol.
But if you did have lots them you could have a single page on punres that covers updates for all your domains.

An idea... havent looked at or even thought about how it would be applied.

Are you thinking of an automated solution, where PunRes would magically detect this? That assumes all the mods you installed are done via PunRes. And that PunRes could identify a unique install of PunBB. Certainly possible with an extension, but not (as far as I know) without one.

game.swf?csrf_token=foo
You can't get the value of csrf_token from that?

When you're writing your own arcade.php file you can't add a call to the CSRF generation function in the right place? o.O