I think your question is "why is there no closing PHP tag"
The answer is that, as StevenBullen said, it's not required. Having the closing tag means that any whitespace after the ?> tag is treated as real whitespace when it's uploaded. This poses a problem in certain files (eg: config.php) and so, since there's no reason to add the closing tag, we don't do it.

102

(12 replies, posted in PunBB 1.2 troubleshooting)

That's actually physically impossible.
Try uploading a copy of include/functions.php from a new download of PunBB from the site.

103

(1 replies, posted in PunBB 1.3 troubleshooting)

Sweet, thanks smile

It is secure.

To change the redirect you need to edit login.php.

105

(4 replies, posted in PunBB 1.2 troubleshooting)

This is from your CSS:

/* Setup all left and right content using floats. */  
.conr {
    FLOAT: right;
    TEXT-ALIGN: right;
    CLEAR: right;
    WIDTH: 40%
}

.conl {
    FLOAT: left;
    WIDTH: 55%;
    OVERFLOW: hidden;
    WHITE-SPACE: nowrap
}

106

(17 replies, posted in PunBB 1.3 troubleshooting)

OK, I think Connor managed to discover the cause of this issue (RSS autodiscovery/prefetching). smile

107

(12 replies, posted in PunBB 1.2 troubleshooting)

Mmm, no, the logout link works fine. That's proven by this site, which uses an unmodified version of 1.2.17. There was, however, an issue with forums that didn't support sha1, so we switched to using pun_hash.

108

(12 replies, posted in PunBB 1.2 troubleshooting)

Apply the 1.2.17 changes/hdiff properly so that your logout link has the csrf_token?

109

(14 replies, posted in PunBB 1.3 troubleshooting)

http://www.w3.org/TR/html401/interact/forms.html
Forms generate URLs like
http://example.org/form.php?first_name= … t_name=bar
Not
http://example.com/form/foo/bar

That's just how they work.

Hmm, I don't know, the hdiff for 1.2.16 to 1.2.17 didn't modify anything having to do with logging in, just with logging out. Could you link to your forum?

And no, same IP shouldn't cause issues with anything.

111

(14 replies, posted in PunBB 1.3 troubleshooting)

Because the issue isn't changing the scheme, the issue is forms.

112

(12 replies, posted in PunBB 1.2 troubleshooting)

If you're using 1.2.17, that's because the new logout link doesn't look like that: it has a CSRF token appended to it.

113

(10 replies, posted in Programming)

MattF wrote:

That'd be using the same method as you suggested, ( and which I did implement, cheers again for that advice, smile ), for the download mod to cater for multiple download locations, would it not?

If my memory serves, then yes smile

114

(10 replies, posted in Programming)

I would take advantage of the fact that I'm using a database and normalize the data tongue
So, add a topic_images table which has an image_id, a topic_id, and an image_name. Then fetch all the images that have the same topic ID as the topic you're viewing and display them. smile

You can interrupt it, you'll just have to start from the beginning.
Try applying this changeset to see if it fixes the issue for you (apply it and then reindex again):
http://dev.punbb.org/changeset/1531

116

(14 replies, posted in PunBB 1.3 troubleshooting)

Smells like an extension to me!

117

(14 replies, posted in PunBB 1.3 troubleshooting)

I guess that's possible, but I don't think that would be a part of the core. Someone could write an extension for it though.

118

(14 replies, posted in PunBB 1.3 troubleshooting)

It's a form, so I don't know that it's physically possible to do. If you come up with a way though, we would love to here it. smile

No, they're not: it's just the wrong code. That's the code used when section is NOT board, which it is here.

Yes, it is possible. The code for it is in include/functions.php, in the generate_navlinks function.

That code is incorrect

if (!$pun_user['is_guest'] && $pun_user['g_id'] != 5)
{
}

or

if ($pun_user['is_guest'] == false && $pun_user['g_id'] != 5)
{
}

You put the == false within the ], which is wrong.

122

(17 replies, posted in PunBB 1.2 troubleshooting)

Well, to be clear, I can maybe deal with the issue if you can figure out what query/queries is/are actually causing the warnings.

123

(17 replies, posted in PunBB 1.2 troubleshooting)

Nope, I'm not a PostgreSQL expert and I really have no idea wink

Check if a user is logged in: $pun_user['is_guest']
Member of a user group: $pun_user['g_id'] == SOME_NUMBER

And yes, if common.php is included then you're properly authenticated, just like on a PunBB page.

125

(13 replies, posted in General discussion)

                <tr><td style="border-left: 0;" class="tc0"><div class="icon"> </div></td>
                    <td class="tc1">
                                <h3><a href="viewforum.php?id=1">Test forum</a></h3>

                                This is just a test forum
                            </div>
                        </div>
                    </td>

Those last two closing divs shouldn't exist.