1,801

(55 replies, posted in PunBB 1.2 discussion)

Could you paste some of that here?

1,802

(55 replies, posted in PunBB 1.2 discussion)

Assuming you're running the converter from the start, that shouldn't be an issue. However, try running it from a clean install.

1,803

(13 replies, posted in Programming)

More info:
http://us.php.net/mysql_real_escape_string

Escapes special characters in the unescaped_string, taking into account the current character set of the connection so that it is safe to place it in a mysql_query(). If binary data is to be inserted, this function must be used.

mysql_real_escape_string() calls MySQL's library function mysql_real_escape_string, which prepends backslashes to the following characters: \x00, \n, \r, \, ', " and \x1a.

This function must always (with few exceptions) be used to make data safe before sending a query to MySQL.

1,804

(55 replies, posted in PunBB 1.2 discussion)

I'm not exactly sure how that's possible, since forum_id is a primary key for phpBB. Unless the converter isn't deleting the old PunBB data, which I've always seen it do, I don't know how that could happen.

1,805

(13 replies, posted in Programming)

It is not about inserting or selecting. It is about escaping input in a query. If you're surrounding something with a " or a ' and the input could potentially have a " or a ' in it, you need to escape it so that it can't "break out," which would be an SQL inject.

1,806

(13 replies, posted in Programming)

Oh, I think you'll want to $db->escape the poster value from the database.

1,807

(13 replies, posted in Programming)

while (false !== ($topic = $db->fetch_assoc($result)))

can be

while ($topic = $db->fetch_assoc($result))

Otherwise, looks fine to me

1,808

(13 replies, posted in Programming)

I just tested the original script you pasted, it worked perfectly for me

1,809

(13 replies, posted in Programming)

There is no num_topics column in users by default: did you mean num_posts?
Other than that, I see no issue, the code looks correct to me.
Yeah, and as you figured out you can safely not use that expensive join

config table, conf value where conf name is o_base_url

It doesn't make up the www-data name, you must have it set in config.php
And if I were you, I would delete all the .php files in the cache directory and make sure base URL is set correctly in the database. That way, there should be no reason for it to reset.

1,812

(2 replies, posted in PunBB 1.2 troubleshooting)

http://punbb.org/about.php
PunBB is open source, it is released under the GPL. You can alter it however you like, you can distribute it as long as you follow the GPL. wink

1,813

(26 replies, posted in General discussion)

Got it and replied

1,814

(3 replies, posted in PunBB 1.2 troubleshooting)

No, because if your base URL is invalid you can't change it except by manually editing the database tongue

1,815

(26 replies, posted in General discussion)

I don't know what to tell you: I just created a Hotmail account and I was able to send myself an email with no issue.

1,816

(26 replies, posted in General discussion)

Could you paste the whole bounce message?

1,817

(26 replies, posted in General discussion)

I just sent myself an email from several different accounts. No bounces.

1,818

(26 replies, posted in General discussion)

bingiman: yup, email, smartys at this domain

1,819

(71 replies, posted in News)

HJH wrote:

Hello All, developers,

I think there is still an oversight in the code for 1.2.16:
in include/functions.php, look for line:

    if ($register_globals === "" || $register_globals === "0" || strtolower($register_globals) === "off")

I think you will find that should be:

    if ($register_globals === "" || $register_globals === "0" || strtolower($register_globals) === "off"))


Hendrik-Jan

Mmm, no, that's an extra closing parenthesis: that would give a parse error wink

1,820

(3 replies, posted in PunBB 1.2 troubleshooting)

Update the base URL and then move the files? wink

1,821

(26 replies, posted in General discussion)

What's the site that's having the issue?

Have you modified your code at all?

http://example.com

Yes, put a ' before admin_loader (the text in the redirect link)

1,825

(5 replies, posted in Programming)

MattF wrote:

From looking at the other code, it seems to be far more 'extravagant' than it has to be, however, or is my view too simplistic? big_smile

It also allows you to mark an entire forum as read, other than that it doesn't seem to extravagant to me.

MattF wrote:

I believe it also fetches the post id's as well as just, (or rather than)?, the topic id's?

Nope

MattF wrote:

Is there any valid reason for serialising the id's before placing into the db as in the existing mod, btw?

Because you can unserialize it when you take it out of the database and keep the array pairing of topic IDs to last viewed times.

MattF wrote:

I'll be honest in that I haven't looked at the existing mod indepth, but from the cursory glance I've had, it would appear possible to do the same with approximately half the code?

I haven't looked at the code for it in a while, but I doubt it tongue