1 Topic by Koos (edited by Koos 2007-12-21 13:47)

  • Koos
  • Koos
  • Member
  • Offline
  • Registered: 2007-03-19
  • Posts: 77

Topic: $pun_user['g_id'] variable empty with guest messages

Why does the $pun_user['g_id'] variable return empty when a message is displayed for a guest?

For example when using:

message($lang_uploadimg['No permission']);

$pun_user['g_id'] is empty when you are a guest, instead of 3.

Koos's Website

2 Reply by MattF

  • MattF
  • Senior Member
  • Offline
  • From: South Yorkshire, England
  • Registered: 2007-03-15
  • Posts: 1,956

Re: $pun_user['g_id'] variable empty with guest messages

I would assume that $pun_user is not a global in the message function, at first guess.

MattF's Website

3 Reply by MattF

  • MattF
  • Senior Member
  • Offline
  • From: South Yorkshire, England
  • Registered: 2007-03-15
  • Posts: 1,956

Re: $pun_user['g_id'] variable empty with guest messages

Just checked. It's not.

function message($message, $no_back_link = false)
{
        global $db, $lang_common, $pun_config, $pun_start, $tpl_main;

Just add $pun_user to that global line to make it available.

MattF's Website

4 Reply by Koos (edited by Koos 2007-12-21 13:58)

  • Koos
  • Koos
  • Member
  • Offline
  • Registered: 2007-03-19
  • Posts: 77

Re: $pun_user['g_id'] variable empty with guest messages

Thanks, that did the trick. Is there a reason why $pun_user was not made global in the message function in the first place?

Koos's Website

  • Smartys
  • Former PunBB Developer
  • Offline
  • Registered: 2004-04-30
  • Posts: 7,844

Re: $pun_user['g_id'] variable empty with guest messages

Because it's not used? wink

6 Reply by Koos (edited by Koos 2007-12-22 17:31)

  • Koos
  • Koos
  • Member
  • Offline
  • Registered: 2007-03-19
  • Posts: 77

Re: $pun_user['g_id'] variable empty with guest messages

Smartys wrote:

Because it's not used? wink

I think it would have been nice to have it there - just for completeness. Why return the correct $pun_user['g_id'] for messages when your are logged in - but have it empty instead of 3 when you're a guest? Some modifications I have done looks at $pun_user['g_id'] when messages are displayed.

Koos's Website

  • Smartys
  • Former PunBB Developer
  • Offline
  • Registered: 2004-04-30
  • Posts: 7,844

Re: $pun_user['g_id'] variable empty with guest messages

I don't know what you mean. The issue isn't setting the value, it's making $pun_user global, which it only is when header.php hasn't been called before the message function (since we need to know the style to use, for example).